Re: queryset.iterator() and prefetch_related()

2020-06-11 Thread '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
Awesome, thank you so much charettes. We're implementing the "private" attribute meanwhile so there's no rush. Have a great day -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this gro

Re: queryset.iterator() and prefetch_related()

2020-06-11 Thread charettes
The code could possibly be removed if the PR gets merged in time for 3.2 yes. Le jeudi 11 juin 2020 09:44:32 UTC-4, 1337 Shadow Hacker a écrit : > > Well that's good to know, thank you charettes ! > > Does that mean that the piece of code from forms that's using "private" > API from QuerySet is

Re: queryset.iterator() and prefetch_related()

2020-06-11 Thread '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
Well that's good to know, thank you charettes ! Does that mean that the piece of code from forms that's using "private" API from QuerySet is going away in the next Django version ? In this case, we probably don't have to do anything on our end ? -- You received this message because you are sub

Re: queryset.iterator() and prefetch_related()

2020-06-11 Thread charettes
FWIW there's ungoing work to allow iterator() to use prefetch_related() which would allow us to lift this restriction. See https://groups.google.com/forum/#!searchin/django-developers/iterator$20prefetch%7Csort:date/django-developers/ADgUd6jRvdw/_ZnETNlcAAAJ Cheers, Simon Le jeudi 11 juin 2020

Re: queryset.iterator() and prefetch_related()

2020-06-11 Thread '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
We've decided to open a ticket and MR for it: https://github.com/percipient/django-querysetsequence/issues/67 (that would happen this weekend) If there's any objection please let us know. Have a great day ‐‐‐ Original Message ‐‐‐ Le mardi, avril 28, 2020 6:39 PM, 1337 Shadow Hacker <1

Re: queryset.iterator() and prefetch_related()

2020-04-28 Thread '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
Sorry I sent the mail prior to finishing, redoing fully from here: I notice a piece of code inside ModelChoiceIterator that seems to keep going a bit back and forth, currently it looks like this: # Can't use iterator() when queryset uses prefetch_related() if not queryset._prefet

queryset.iterator() and prefetch_related()

2020-04-28 Thread '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
Hi all, I notice a piece of code inside ModelChoiceIterator that seems to keep going a bit back and forth, currently it looks like this: # Can't use iterator() when queryset uses prefetch_related() if not queryset._prefetch_related_lookups: queryset = queryset.iterator() But