Author: jacob
Date: 2010-03-01 14:11:24 -0600 (Mon, 01 Mar 2010)
New Revision: 12637
Modified:
django/trunk/django/core/cache/backends/memcached.py
django/trunk/tests/regressiontests/cache/tests.py
Log:
Fixed #11012: don't needless convert cache values to unicode.
This means you can now successfully store binary blogs, such as compressed data,
in the cache.
Thanks to Matt Croydon for the final patch.
Modified: django/trunk/django/core/cache/backends/memcached.py
===================================================================
--- django/trunk/django/core/cache/backends/memcached.py 2010-03-01
20:06:20 UTC (rev 12636)
+++ django/trunk/django/core/cache/backends/memcached.py 2010-03-01
20:11:24 UTC (rev 12637)
@@ -43,15 +43,9 @@
val = self._cache.get(smart_str(key))
if val is None:
return default
- else:
- if isinstance(val, basestring):
- return smart_unicode(val)
- else:
- return val
+ return val
def set(self, key, value, timeout=0):
- if isinstance(value, unicode):
- value = value.encode('utf-8')
self._cache.set(smart_str(key), value,
self._get_memcache_timeout(timeout))
def delete(self, key):
Modified: django/trunk/tests/regressiontests/cache/tests.py
===================================================================
--- django/trunk/tests/regressiontests/cache/tests.py 2010-03-01 20:06:20 UTC
(rev 12636)
+++ django/trunk/tests/regressiontests/cache/tests.py 2010-03-01 20:11:24 UTC
(rev 12637)
@@ -295,6 +295,16 @@
self.cache.set(key, value)
self.assertEqual(self.cache.get(key), value)
+ def test_binary_string(self):
+ # Binary strings should be cachable
+ from zlib import compress, decompress
+ value = 'value_to_be_compressed'
+ compressed_value = compress(value)
+ self.cache.set('binary1', compressed_value)
+ compressed_result = self.cache.get('binary1')
+ self.assertEqual(compressed_value, compressed_result)
+ self.assertEqual(value, decompress(compressed_result))
+
def test_set_many(self):
# Multiple keys can be set using set_many
self.cache.set_many({"key1": "spam", "key2": "eggs"})
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
