#29130: floatformat is rounding off incorrectly
-------------------------------------+-------------------------------------
     Reporter:  Akash Deshpande      |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Template system      |                  Version:  1.11
     Severity:  Normal               |               Resolution:
     Keywords:  template float       |             Triage Stage:
  filter                             |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Old description:

> I think the below changes broke/caused issues in floatformat
>
> https://github.com/django/django/commit/12f7928f5a455e330c0a7f19bc86b37baca12811
>
> Easiest way to replicate the issue is
> 1. Create a simple view with a template
>
> views.py
> \\
>    def test(request):
>         return render('test.html')
>

> test.html
> \\
>          {{ 331.44999999999|floatformat:-1 }}
>
> The above should return 331.5, but returns 331.4. This changed in django
> 1.11. (It returned 331.5 in django 1.8.X )

New description:

 I think 12f7928f5a455e330c0a7f19bc86b37baca12811 caused a regression in
 `floatformat`.

 `{{ 331.44999999999|floatformat:-1 }}`

 The above should return 331.5, but returns 331.4. This changed in django
 1.11. (It returned 331.5 in django 1.8.X )

--

Comment (by Tim Graham):

 The current behavior looks correct to me. If rounding to one decimal
 place, look at the second decimal place (4). Since that's less than five,
 round down. Have I misunderstood the rules for rounding?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29130#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d2846c7b99de0c1f763a610c5989fb59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to