On Wed, Nov 01, 2023 at 12:51:15PM +0800, Herbert Xu wrote:
> Eric Biggers wrote:
> >
> > + driver_name = crypto_ahash_driver_name(ahash);
> > + if (v->version >= 1 /* salt prepended, not appended? */ &&
> > + 1 << v->data_dev_block_bits <= PAGE_SIZE) {
> > +
Eric Biggers wrote:
>
> + driver_name = crypto_ahash_driver_name(ahash);
> + if (v->version >= 1 /* salt prepended, not appended? */ &&
> + 1 << v->data_dev_block_bits <= PAGE_SIZE) {
> + shash = crypto_alloc_shash(alg_name, 0, 0);
I'm sorry but this is
If the IO is marked as readahead. When it is failed, it would better
to pass it to upper layer to handle it.
Consender the following situation:
dm-verity is built over a dm device.
'dm_submit_bio()' will return IO error when dm device is suspended.
And IO get nothing, but it will goto FEC, and
On Wed, Nov 01, 2023 at 03:14:22AM +0100, Marek Marczykowski-Górecki wrote:
> On Wed, Nov 01, 2023 at 09:27:24AM +0800, Ming Lei wrote:
> > On Tue, Oct 31, 2023 at 11:42 PM Marek Marczykowski-Górecki
> > wrote:
> > >
> > > On Tue, Oct 31, 2023 at 03:01:36PM +0100, Jan Kara wrote:
> > > > On Tue
On Wed, Nov 01, 2023 at 03:15:50AM +0100, Marek Marczykowski-Górecki wrote:
> And BTW, an attempt to access another partition on the same disk (not
> covered with dm-crypt) hangs too.
No, not sure about that part, it was rather reading /bin/ls hanging...
--
Best Regards,
Marek
On Wed, Nov 01, 2023 at 03:14:22AM +0100, Marek Marczykowski-Górecki wrote:
> On Wed, Nov 01, 2023 at 09:27:24AM +0800, Ming Lei wrote:
> > On Tue, Oct 31, 2023 at 11:42 PM Marek Marczykowski-Górecki
> > wrote:
> > >
> > > On Tue, Oct 31, 2023 at 03:01:36PM +0100, Jan Kara wrote:
> > > > On Tue
On Wed, Nov 01, 2023 at 09:27:24AM +0800, Ming Lei wrote:
> On Tue, Oct 31, 2023 at 11:42 PM Marek Marczykowski-Górecki
> wrote:
> >
> > On Tue, Oct 31, 2023 at 03:01:36PM +0100, Jan Kara wrote:
> > > On Tue 31-10-23 04:48:44, Marek Marczykowski-Górecki wrote:
> > > > Then tried:
> > > > -
On Tue, Oct 31, 2023 at 11:42 PM Marek Marczykowski-Górecki
wrote:
>
> On Tue, Oct 31, 2023 at 03:01:36PM +0100, Jan Kara wrote:
> > On Tue 31-10-23 04:48:44, Marek Marczykowski-Górecki wrote:
> > > Then tried:
> > > - PAGE_ALLOC_COSTLY_ORDER=4, order=4 - cannot reproduce,
> > > -
The commit 5054e778fcd9c changed dm-crypt to use compound pages to improve
performance. Unfortunatelly, there was an oversight - normal pages are
accounted in a percpu counter cc->n_allocated_pages and dm-crypt is
limited to allocate at most 2% of memory. Compound pages were not
accounted at all.
On Tue, 31 Oct 2023, Mikulas Patocka wrote:
>
>
> On Tue, 31 Oct 2023, Marek Marczykowski-Górecki wrote:
>
> > On Tue, Oct 31, 2023 at 03:01:36PM +0100, Jan Kara wrote:
> > > On Tue 31-10-23 04:48:44, Marek Marczykowski-Górecki wrote:
> > > > Then tried:
> > > > - PAGE_ALLOC_COSTLY_ORDER=4,
On Tue, 31 Oct 2023, Marek Marczykowski-Górecki wrote:
> On Tue, Oct 31, 2023 at 03:01:36PM +0100, Jan Kara wrote:
> > On Tue 31-10-23 04:48:44, Marek Marczykowski-Górecki wrote:
> > > Then tried:
> > > - PAGE_ALLOC_COSTLY_ORDER=4, order=4 - cannot reproduce,
> > > -
On Tue, Oct 31, 2023 at 03:01:36PM +0100, Jan Kara wrote:
> On Tue 31-10-23 04:48:44, Marek Marczykowski-Górecki wrote:
> > Then tried:
> > - PAGE_ALLOC_COSTLY_ORDER=4, order=4 - cannot reproduce,
> > - PAGE_ALLOC_COSTLY_ORDER=4, order=5 - cannot reproduce,
> > - PAGE_ALLOC_COSTLY_ORDER=4,
On Tue 31-10-23 04:48:44, Marek Marczykowski-Górecki wrote:
> On Mon, Oct 30, 2023 at 06:50:35PM +0100, Mikulas Patocka wrote:
> > On Mon, 30 Oct 2023, Marek Marczykowski-Górecki wrote:
> > > Then retried with order=PAGE_ALLOC_COSTLY_ORDER and
> > > PAGE_ALLOC_COSTLY_ORDER back at 3, and also got
On 31/10/2023 07:10, Harshit Mogalapalli wrote:
> When worker thread allocation fails, return error instead of
> zero(success).
>
> Also when kthread_create fails it returns ERR pointers and not NULL, so
> fix that as well.
>
> Fixes: c1fce71d29b2 ("dm delay: for short delays, use kthread
When worker thread allocation fails, return error instead of
zero(success).
Also when kthread_create fails it returns ERR pointers and not NULL, so
fix that as well.
Fixes: c1fce71d29b2 ("dm delay: for short delays, use kthread instead of timers
and wq")
Signed-off-by: Harshit Mogalapalli
---
15 matches
Mail list logo