[PATCH v2] multipathd: make multipathd set priority to RLIMIT_RTPRIO

2024-04-09 Thread Benjamin Marzinski
With this change, if the SCHED_RT_PRIO compiler flag has been removed. Instead multipathd will call getrlimit(RLIMIT_RTPRIO, ...) and look at the hard limit. It it's 0, multipath will do nothing. Otherwise it will change its scheduling policy to SCHED_RR and its priority to the hard limit. This

Re: [PATCH] multipathd: make multipathd set priority to RLIMIT_RTPRIO

2024-04-09 Thread Martin Wilck
On Tue, 2024-04-09 at 12:12 -0400, Benjamin Marzinski wrote: > On Tue, Apr 09, 2024 at 04:38:57PM +0200, Martin Wilck wrote: > > On Fri, 2024-03-29 at 14:28 -0400, Benjamin Marzinski wrote: > > > With this change, if the SCHED_RT_PRIO compiler flag is not set, > > > multipathd will call

Re: [PATCH v3 08/12] 11-dm-mpath.rules: replace DM_NOSCAN by .DM_NOSCAN

2024-04-09 Thread Benjamin Marzinski
On Tue, Apr 09, 2024 at 04:08:13PM +0200, Martin Wilck wrote: > We don't need to restore DM_NOSCAN from the db anymore, so we can rename > it to .DM_NOSCAN, making it a temporary property. > > Signed-off-by: Martin Wilck Reviewed-by: Benjamin Marzinski > --- > multipath/11-dm-mpath.rules.in |

Re: dm-init/dm-verity: Data device lookup failed

2024-04-09 Thread Sven
With the following patch diff --git a/block/early-lookup.c b/block/early-lookup.c index 3effbd0d35e9..9e5b11270f8e 100644 --- a/block/early-lookup.c +++ b/block/early-lookup.c @@ -138,6 +138,7 @@ static dev_t __init blk_lookup_devt(const char *name, int partno) /* We

Re: [PATCH] block: allow device to have both virt_boundary_mask and max segment size

2024-04-09 Thread Ming Lei
On Tue, Apr 09, 2024 at 03:57:58PM +0200, Christoph Hellwig wrote: > On Mon, Apr 08, 2024 at 05:48:02PM +0800, Ming Lei wrote: > > The limit is from commit 09324d32d2a0 ("block: force an unlimited segment > > size on queues with a virt boundary") which claims to fix f6970f83ef79 > > ("block: don't

Re: [PATCH] multipathd: make multipathd set priority to RLIMIT_RTPRIO

2024-04-09 Thread Benjamin Marzinski
On Tue, Apr 09, 2024 at 04:38:57PM +0200, Martin Wilck wrote: > On Fri, 2024-03-29 at 14:28 -0400, Benjamin Marzinski wrote: > > With this change, if the SCHED_RT_PRIO compiler flag is not set, > > multipathd will call getrlimit(RLIMIT_RTPRIO, ...) and look at the > > hard > > limit. It it's 0,

Re: [PATCH] multipathd: make multipathd set priority to RLIMIT_RTPRIO

2024-04-09 Thread Martin Wilck
On Fri, 2024-03-29 at 14:28 -0400, Benjamin Marzinski wrote: > With this change, if the SCHED_RT_PRIO compiler flag is not set, > multipathd will call getrlimit(RLIMIT_RTPRIO, ...) and look at the > hard > limit. It it's 0, multipath will do nothing. Otherwise it will change > its scheduling

Re: dm-init/dm-verity: Data device lookup failed

2024-04-09 Thread Christoph Hellwig
On Tue, Apr 09, 2024 at 01:33:13PM +0200, Sven wrote: > Hi, > > I'm using dm-init to set up a dm-verity rootfs, i.e. my kernel command line > includes: > > root=/dev/dm-0 > dm-mod.waitfor=/dev/mmcblk0p3 > dm-mod.create="rootfs,,0,ro,0 614400 verity 1 /dev/mmcblk0p3 /dev/mmcblk0p3 > 1024 4096

Re: [PATCH] softirq: fix memory corruption when freeing tasklet_struct

2024-04-09 Thread Li Lingfeng
Hi I tried to reproduce the problem by adding mdelay() in tasklet_action_common() after t->func() but failed. Since cc->io_queue is created without WQ_UNBOUND, the work queued to it will be executed by the CPU which queued the work, which means bio_endio() will not be called until

Re: [PATCH v3 00/12] multipath udev rules changes for dm rules V3

2024-04-09 Thread Martin Wilck
On Tue, 2024-04-09 at 16:08 +0200, Martin Wilck wrote: > This patch set adapts the multipath rules to the pending changes > for device mapper rules that update DM_UDEV_RULES_VSN to 3, and > applies some additional clean-ups to the rules files. > > Changes v2 -> v3: > * 08/11 replaced another

[PATCH v3 00/12] multipath udev rules changes for dm rules V3

2024-04-09 Thread Martin Wilck
This patch set adapts the multipath rules to the pending changes for device mapper rules that update DM_UDEV_RULES_VSN to 3, and applies some additional clean-ups to the rules files. Changes v2 -> v3: * 08/11 replaced another UDEV_RULES_VSN test (Benjamin Marzinski) (not resending the patches

[PATCH v3 08/12] 11-dm-mpath.rules: replace DM_NOSCAN by .DM_NOSCAN

2024-04-09 Thread Martin Wilck
We don't need to restore DM_NOSCAN from the db anymore, so we can rename it to .DM_NOSCAN, making it a temporary property. Signed-off-by: Martin Wilck --- multipath/11-dm-mpath.rules.in | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/multipath/11-dm-mpath.rules.in

Re: [PATCH] block: allow device to have both virt_boundary_mask and max segment size

2024-04-09 Thread Christoph Hellwig
On Mon, Apr 08, 2024 at 05:48:02PM +0800, Ming Lei wrote: > The limit is from commit 09324d32d2a0 ("block: force an unlimited segment > size on queues with a virt boundary") which claims to fix f6970f83ef79 > ("block: don't check if adjacent bvecs in one bio can be mergeable"). > > However commit

Re: [PATCH v2 08/11] 11-dm-mpath.rules: replace DM_NOSCAN by .DM_NOSCAN

2024-04-09 Thread Martin Wilck
On Mon, 2024-04-08 at 14:47 -0400, Benjamin Marzinski wrote: > >   > > +# device-mapper rules v2 compatibility for 13-dm-disk.rules > > +ENV{DM_UDEV_RULES_VSN}!="3", ENV{DM_NOSCAN}="$env{.DM_NOSCAN}" > > + > > You missed a DM_UDEV_RULES_VSN change here. Thanks! Martin

Re: [PATCH resend] dm-crypt: add the "high_priority" flag

2024-04-09 Thread Milan Broz
On 4/8/24 9:36 PM, Mikulas Patocka wrote: It was reported that dm-crypt performs badly when the system is loaded[1]. So I'm adding an option "high_priority" that sets the workqueues and the write_thread to nice level -20. This used to be default in the past, but it caused audio skipping, so it

dm-init/dm-verity: Data device lookup failed

2024-04-09 Thread Sven
Hi, I'm using dm-init to set up a dm-verity rootfs, i.e. my kernel command line includes: root=/dev/dm-0 dm-mod.waitfor=/dev/mmcblk0p3 dm-mod.create="rootfs,,0,ro,0 614400 verity 1 /dev/mmcblk0p3 /dev/mmcblk0p3 1024 4096 307200 76801 sha256 HASH HASH" Occasionally, my device refuses to

Re: [PATCH v3 00/17] treewide: Refactor heap related implementation

2024-04-09 Thread Coly Li
> 2024年4月9日 11:40,Kent Overstreet 写道: > > On Sun, Apr 07, 2024 at 12:47:10AM +0800, Kuan-Wei Chiu wrote: >> This patch series focuses on several adjustments related to heap >> implementation. Firstly, a type-safe interface has been added to the >> min_heap, along with the introduction of

Re: [PATCH v3 16/17] bcache: Remove heap-related macros and switch to generic min_heap

2024-04-09 Thread Coly Li
On Sun, Apr 07, 2024 at 12:47:26AM +0800, Kuan-Wei Chiu wrote: > Drop the heap-related macros from bcache and replacing them with the > generic min_heap implementation from include/linux. By doing so, code > readability is improved by using functions instead of macros. Moreover, > the min_heap

Re: [PATCH v3 16/17] bcache: Remove heap-related macros and switch to generic min_heap

2024-04-09 Thread Coly Li
On Sun, Apr 07, 2024 at 12:47:26AM +0800, Kuan-Wei Chiu wrote: > Drop the heap-related macros from bcache and replacing them with the > generic min_heap implementation from include/linux. By doing so, code > readability is improved by using functions instead of macros. Moreover, > the min_heap