Re: [git pull] device mapper fix for 6.10

2024-07-11 Thread pr-tracker-bot
The pull request you sent on Thu, 11 Jul 2024 22:31:27 +0200 (CEST): > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-6.10/dm-fixes-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/43db1e03c086ed20cc75808d3f45e780ec4ca26e Thank yo

Re: [PATCH 23/44] libmultipath: improve dm_get_wwid() return value logic

2024-07-11 Thread Martin Wilck
On Thu, 2024-07-11 at 14:25 +0200, Martin Wilck wrote: > On Wed, 2024-07-10 at 19:34 -0400, Benjamin Marzinski wrote: > > On Tue, Jul 09, 2024 at 11:39:14PM +0200, Martin Wilck wrote: > > > > > >   > > > +/** > > > + * dm_get_wwid(): return WWID for a multipath map > > > + * @returns: > > > + *   

[git pull] device mapper fix for 6.10

2024-07-11 Thread Mikulas Patocka
Hi Linus, The following changes since commit 825d8bbd2f32cb229c3b6653bd454832c3c20acb: dm: always manage discard support in terms of max_hw_discard_sectors (2024-05-20 15:51:19 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-

Re: [PATCH 31/44] libmultipath: add is_mpath_uuid() helper

2024-07-11 Thread Martin Wilck
On Thu, 2024-07-11 at 14:39 -0400, Benjamin Marzinski wrote: > On Thu, Jul 11, 2024 at 02:56:05PM +0200, Martin Wilck wrote: > > On Wed, 2024-07-10 at 23:38 -0400, Benjamin Marzinski wrote: > > > On Tue, Jul 09, 2024 at 11:39:22PM +0200, Martin Wilck wrote: > > > > Export it, as it will be used by

Re: [PATCH 31/44] libmultipath: add is_mpath_uuid() helper

2024-07-11 Thread Benjamin Marzinski
On Thu, Jul 11, 2024 at 02:56:05PM +0200, Martin Wilck wrote: > On Wed, 2024-07-10 at 23:38 -0400, Benjamin Marzinski wrote: > > On Tue, Jul 09, 2024 at 11:39:22PM +0200, Martin Wilck wrote: > > > Export it, as it will be used by multipathd and libmpathpersist. > > > > > > > This is fine. But I w

Re: [PATCH blktests] dm/002: repeat dmsetup remove command on failure with EBUSY

2024-07-11 Thread Bart Van Assche
On 7/11/24 3:39 AM, Shinichiro Kawasaki wrote: It showed "Comm: (udev-worker)" is the process which keeps the DM device open. [ ... ] Just adding "udevadm settle" before "dmsetup remove" will avoid the failure. I'm OK with either the retry loop from the patch at the start of this email thread o

Re: [PATCH 21/44] libmultipath: is_mpath_part(): improve parsing

2024-07-11 Thread Martin Wilck
On Thu, 2024-07-11 at 13:01 -0400, Benjamin Marzinski wrote: > On Thu, Jul 11, 2024 at 01:08:39PM +0200, Martin Wilck wrote: > > On Wed, 2024-07-10 at 18:54 -0400, Benjamin Marzinski wrote: > > > > > > we should probably use "part%u-%n" so we can't match a "-" before > > > the > > > number. > > >

Re: [PATCH 21/44] libmultipath: is_mpath_part(): improve parsing

2024-07-11 Thread Benjamin Marzinski
On Thu, Jul 11, 2024 at 01:08:39PM +0200, Martin Wilck wrote: > On Wed, 2024-07-10 at 18:54 -0400, Benjamin Marzinski wrote: > > On Tue, Jul 09, 2024 at 11:39:12PM +0200, Martin Wilck wrote: > > > Use sscanf to make the parsing of the UUID more robust. > > > > > > Signed-off-by: Martin Wilck > >

Re: [PATCH 23/44] libmultipath: improve dm_get_wwid() return value logic

2024-07-11 Thread Benjamin Marzinski
On Thu, Jul 11, 2024 at 02:25:54PM +0200, Martin Wilck wrote: > On Wed, 2024-07-10 at 19:34 -0400, Benjamin Marzinski wrote: > > On Tue, Jul 09, 2024 at 11:39:14PM +0200, Martin Wilck wrote: > > > Make dm_get_wwid() return different status codes for non-existing > > > maps, > > > maps that exists b

Re: [PATCH 42/44] llibmultipath: fix return code check for dm_is_suspended()

2024-07-11 Thread Martin Wilck
On Thu, 2024-07-11 at 02:27 -0400, Benjamin Marzinski wrote: > On Tue, Jul 09, 2024 at 11:39:33PM +0200, Martin Wilck wrote: > > dm_is_suspended returns non-null if it failed to obtain the device > > information. It's wrong to assume in this case that the device is > > suspended. > > I'm kinda tor

Re: [PATCH 35/44] libmultipath: use libmp_pathinfo() in update_multipath_table()

2024-07-11 Thread Martin Wilck
On Thu, 2024-07-11 at 01:16 -0400, Benjamin Marzinski wrote: > On Tue, Jul 09, 2024 at 11:39:26PM +0200, Martin Wilck wrote: > > This allows us to remove dm_get_status(), and dm_get_map(), of > > which > > update_multipath_table() was the last caller. > > > > Signed-off-by: Martin Wilck > > --- >

Re: dm vdo: replace max_discard_sectors with max_hw_discard_sectors

2024-07-11 Thread Mike Snitzer
On Wed, Jul 10, 2024 at 03:37:30PM -0400, Matthew Sakai wrote: > From: Bruce Johnston > > Commit 4f563a64732d ("block: add a max_user_discard_sectors queue > limit") changed block core to set max_discard_sectors to: > min(lim->max_hw_discard_sectors, lim->max_user_discard_sectors) > > Commit 825

Re: [PATCH 31/44] libmultipath: add is_mpath_uuid() helper

2024-07-11 Thread Martin Wilck
On Wed, 2024-07-10 at 23:38 -0400, Benjamin Marzinski wrote: > On Tue, Jul 09, 2024 at 11:39:22PM +0200, Martin Wilck wrote: > > Export it, as it will be used by multipathd and libmpathpersist. > > > > This is fine. But I was thinking that if you wanted to actually add > some optional flags to th

Re: [PATCH 28/44] libmultipath: implement dm_is_mpath() with new API

2024-07-11 Thread Martin Wilck
On Wed, 2024-07-10 at 20:21 -0400, Benjamin Marzinski wrote: > On Tue, Jul 09, 2024 at 11:39:19PM +0200, Martin Wilck wrote: > > Signed-off-by: Martin Wilck > > --- > >  libmultipath/devmapper.c | 53 ++-- > > > >  1 file changed, 8 insertions(+), 45 deletions(-

Re: [PATCH 23/44] libmultipath: improve dm_get_wwid() return value logic

2024-07-11 Thread Martin Wilck
On Wed, 2024-07-10 at 19:34 -0400, Benjamin Marzinski wrote: > On Tue, Jul 09, 2024 at 11:39:14PM +0200, Martin Wilck wrote: > > Make dm_get_wwid() return different status codes for non-existing > > maps, > > maps that exists but are not multipath maps, and generic error > > case, > > and handle th

Re: [PATCH 21/44] libmultipath: is_mpath_part(): improve parsing

2024-07-11 Thread Martin Wilck
On Wed, 2024-07-10 at 18:54 -0400, Benjamin Marzinski wrote: > On Tue, Jul 09, 2024 at 11:39:12PM +0200, Martin Wilck wrote: > > Use sscanf to make the parsing of the UUID more robust. > > > > Signed-off-by: Martin Wilck > > --- > >  libmultipath/devmapper.c | 17 +++-- > >  1 file cha

Re: [PATCH 17/44] libmultipath: add libmp_mapinfo()

2024-07-11 Thread Martin Wilck
On Wed, 2024-07-10 at 18:53 -0400, Benjamin Marzinski wrote: > On Tue, Jul 09, 2024 at 11:39:08PM +0200, Martin Wilck wrote: > > This is a great idea! I just have a few minor issues. > > > libmp_mapinfo() is intended as a generic abstraction for retrieving > > information from > > the kernel devi

Re: [PATCH blktests] dm/002: repeat dmsetup remove command on failure with EBUSY

2024-07-11 Thread Shinichiro Kawasaki
On Jul 10, 2024 / 17:46, Mikulas Patocka wrote: > > > On Wed, 10 Jul 2024, Bryan Gurney wrote: > > > On Tue, Jul 9, 2024 at 8:44 AM Shin'ichiro Kawasaki > > wrote: > > > > > > The test case dm/002 rarely fails with the message below: > > > > > > dm/002 => nvme0n1 (dm-dust general functionality