Re: [PATCH 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features

2025-06-12 Thread Christoph Hellwig
On Fri, Jun 13, 2025 at 11:15:41AM +0800, Zhang Yi wrote: > Yeah, this solution looks good to me. However, we currently have only > two selections (none and unmap). What if we keep it as is and simply > hide this interface if BLK_FEAT_WRITE_ZEROES_UNMAP is not set, making > it visible only when the

Re: [systemd-devel] [Discussion][device-mapper] Enabling Block Device Access Locking in systemd

2025-06-12 Thread Chengen Du
On Fri, Jun 6, 2025 at 12:18 PM Chengen Du wrote: > > Hi Zdenek, > > Thank you for your feedback on this issue. > Your input has been valuable in moving the discussion forward. > > On Wed, Jun 4, 2025 at 5:06 PM Zdenek Kabelac wrote: > > > > Dne 04. 06. 25 v 5:33 Chengen Du napsal(a): > > > Hi DM

Re: [RFC v2 00/11] dm-pcache – persistent-memory cache for block devices

2025-06-12 Thread Dongsheng Yang
On 2025/6/13 0:57, Mikulas Patocka wrote: Hi On Thu, 5 Jun 2025, Dongsheng Yang wrote: Hi Mikulas and all, ... Generally, the code doesn't seem bad. After reworking the out-of-memory handling and replacing arbitrary waits with wait queues, I can merge it. Hi Mikulas,     Thanks for yo

Re: [PATCH 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features

2025-06-12 Thread Zhang Yi
On 2025/6/12 23:03, Darrick J. Wong wrote: > On Thu, Jun 12, 2025 at 07:20:45PM +0800, Zhang Yi wrote: >> On 2025/6/12 12:47, Christoph Hellwig wrote: >>> On Wed, Jun 11, 2025 at 03:31:21PM +0800, Zhang Yi wrote: >> +/* supports unmap write zeroes command */ >> +#define BLK_FEAT_WRITE_ZEROE

Re: [RFC v2 00/11] dm-pcache – persistent-memory cache for block devices

2025-06-12 Thread Mikulas Patocka
Hi On Thu, 5 Jun 2025, Dongsheng Yang wrote: > Hi Mikulas and all, > > This is *RFC v2* of the *pcache* series, a persistent-memory backed cache. > Compared with *RFC v1* > > > the most important change is that

Re: [PATCH 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features

2025-06-12 Thread Darrick J. Wong
On Thu, Jun 12, 2025 at 07:20:45PM +0800, Zhang Yi wrote: > On 2025/6/12 12:47, Christoph Hellwig wrote: > > On Wed, Jun 11, 2025 at 03:31:21PM +0800, Zhang Yi wrote: > +/* supports unmap write zeroes command */ > +#define BLK_FEAT_WRITE_ZEROES_UNMAP ((__force blk_features_t)(1u << >

Re: [PATCH 07/10] fs: introduce FALLOC_FL_WRITE_ZEROES to fallocate

2025-06-12 Thread Zhang Yi
On 2025/6/11 23:05, Darrick J. Wong wrote: > [cc linux-api about a fallocate uapi change] > > On Wed, Jun 04, 2025 at 10:08:47AM +0800, Zhang Yi wrote: >> From: Zhang Yi >> >> With the development of flash-based storage devices, we can quickly >> write zeros to SSDs using the WRITE_ZERO command i

Re: [PATCH 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features

2025-06-12 Thread Zhang Yi
On 2025/6/12 12:47, Christoph Hellwig wrote: > On Wed, Jun 11, 2025 at 03:31:21PM +0800, Zhang Yi wrote: +/* supports unmap write zeroes command */ +#define BLK_FEAT_WRITE_ZEROES_UNMAP ((__force blk_features_t)(1u << 17)) >>> >>> >>> Should this be exposed through sysfs as a r

Re: [PATCH RFC 3/4] dm-stripe: limit chunk_sectors to the stripe size

2025-06-12 Thread John Garry
On 09/06/2025 16:19, Mikulas Patocka wrote: diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 24a857ff6d0b..4f1f7173740c 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -430,6 +430,10 @@ static int dm_set_device_limits(struct dm_target *ti, struct dm_dev *dev,

Re: [PATCH RFC 3/4] dm-stripe: limit chunk_sectors to the stripe size

2025-06-12 Thread John Garry
On 06/06/2025 16:16, Nilay Shroff wrote: diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 24a857ff6d0b..4f1f7173740c 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -430,6 +430,10 @@ static int dm_set_device_limits(struct dm_target *ti, struct dm_dev *dev,

Re: [PATCH RFC 4/4] block: use chunk_sectors when evaluating stacked atomic write limits

2025-06-12 Thread John Garry
On 06/06/2025 16:23, Nilay Shroff wrote: t->atomic_write_hw_unit_min = min(b->atomic_write_hw_unit_min, t->atomic_write_hw_unit_max); - t->atomic_write_hw_max = min(b->atomic_write_hw_max, t->io_min); + t->atomic_write_hw_max = min(b->