On Tue, Mar 12, 2024 at 02:10:13PM -0700, Christoph Hellwig wrote:
> On Tue, Mar 12, 2024 at 11:22:53AM -0400, Mike Snitzer wrote:
> > blk_validate_limits() is currently very pedantic. I discussed with Jens
> > briefly and we're thinking it might make sense for blk_validate_limits()
> > to be more
On Tue, Mar 12, 2024 at 06:50:51PM -0400, Mike Snitzer wrote:
> Wow, using my 8+ year old commit message against me ;)
Or for you :)
> I've honestly paged most of this out but I'll revisit, likely with
> Mikulas, to pin this down better and then see what possible.
FYI, I don't think this is
On Tue, Mar 12 2024 at 6:30P -0400,
Christoph Hellwig wrote:
> On Tue, Mar 12, 2024 at 06:22:21PM -0400, Mike Snitzer wrote:
> > > The real problem is that we combine the limits while we shouldn't.
> > > Every since we've supported immutable biovecs and do the splitting
> > > down in blk-mq
On Tue, Mar 12, 2024 at 06:22:21PM -0400, Mike Snitzer wrote:
> > The real problem is that we combine the limits while we shouldn't.
> > Every since we've supported immutable biovecs and do the splitting
> > down in blk-mq there is no point to even inherit such limits in the
> > upper drivers.
>
On Tue, Mar 12 2024 at 5:10P -0400,
Christoph Hellwig wrote:
> On Tue, Mar 12, 2024 at 11:22:53AM -0400, Mike Snitzer wrote:
> > blk_validate_limits() is currently very pedantic. I discussed with Jens
> > briefly and we're thinking it might make sense for blk_validate_limits()
> > to be more
On Tue, Mar 12, 2024 at 11:22:53AM -0400, Mike Snitzer wrote:
> blk_validate_limits() is currently very pedantic. I discussed with Jens
> briefly and we're thinking it might make sense for blk_validate_limits()
> to be more forgiving by _not_ imposing hard -EINVAL failure. That in
> the interim,
On Tue, Mar 12, 2024 at 11:22:53AM -0400, Mike Snitzer wrote:
> 4) blk_validate_limits() will reject the limits that
>blk_stack_limits() created:
> /*
> * Devices that require a virtual boundary do not support
> scatter/gather
> * I/O natively, but instead require a
On Mon, Mar 11 2024 at 9:09P -0400,
Christoph Hellwig wrote:
> On Mon, Mar 11, 2024 at 08:28:50PM -0400, Mike Snitzer wrote:
> > All for Jens being made to suffer with dm-crypt but I think we need a
> > proper root cause of what is happening for you and Johannes ;)
>
> I'm going to try to stay