As a global variable waiter_attr of thread attribute was set up in the
daemon,
however,it hasn't been destroyed when the daemon exited.
We need deinitialize waiter_attr.
---
multipathd/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/multipathd/main.c b/multipathd/main.c
index b8
Hi,
Yes this part is wrong and reads are not dropped.
I have a patch ready, just have to send it out.
Lukas
On Wed, Jul 6, 2016 at 8:33 AM, Akira Hayakawa wrote:
> Hi,
>
> I am using dm-flakey to emulate a broken device that should return -EIO on
> both read and write.
> I use the parameter up_
On Mon, Jul 04, 2016 at 06:47:29PM +0800, Ming Lei wrote:
> >> One clean solution may be to convert the loop of generic_make_request()
> >> into the following way:
> >>
> >> do {
> >> struct bio *splitted, *remainder = NULL;
> >> struct request_queue *q = bdev_get_queue(bio->bi_bdev);
> >>
Thanks,
I want the patch in the main-tree quickly.
Because without it, my tests will not be green.
This is really annoying.
I made a quick reproducer of this problem.
If you are looking for one, this will help.
(You need to install sbt first)
https://github.com/akiradeveloper/writeboost-test-sui
On Mon, Jul 04 2016 at 11:25am -0400,
Minfei Huang wrote:
> kthread function is used to process kthread_work. And there is no return
> value checking during create this thread. Add this checking to fix this
> issue.
>
> Signed-off-by: Minfei Huang
> ---
> drivers/md/dm.c | 11 +--
> 1
On 07/06/16 at 09:16P, Mike Snitzer wrote:
> On Mon, Jul 04 2016 at 11:25am -0400,
> Minfei Huang wrote:
>
> > kthread function is used to process kthread_work. And there is no return
> > value checking during create this thread. Add this checking to fix this
> > issue.
> >
> > Signed-off-by: Mi
On Wed, Jul 06 2016 at 9:27am -0400,
Minfei Huang wrote:
> On 07/06/16 at 09:16P, Mike Snitzer wrote:
> > On Mon, Jul 04 2016 at 11:25am -0400,
> > Minfei Huang wrote:
> >
> > > kthread function is used to process kthread_work. And there is no return
> > > value checking during create this thr
On Mon, Jul 04 2016 at 6:53pm -0400,
Mikulas Patocka wrote:
> Hi
>
> This is the second version of patches that fix deadlocks by redirecting
> bios from current->bio_list to rescuer workqueues.
>
> I found out that the original patches caused deadlock with the loopback
> device. When the loo
On 07/06/16 at 09:31P, Mike Snitzer wrote:
> On Wed, Jul 06 2016 at 9:27am -0400,
> Minfei Huang wrote:
>
> > On 07/06/16 at 09:16P, Mike Snitzer wrote:
> > > On Mon, Jul 04 2016 at 11:25am -0400,
> > > Minfei Huang wrote:
> > >
> > > > kthread function is used to process kthread_work. And the
On Wed, Jul 06 2016 at 9:53am -0400,
Mikulas Patocka wrote:
>
>
> On Wed, 6 Jul 2016, Mike Snitzer wrote:
>
> > On Mon, Jul 04 2016 at 6:53pm -0400,
> > Mikulas Patocka wrote:
> >
> > > Hi
> > >
> > > This is the second version of patches that fix deadlocks by redirecting
> > > bios from
On Wed, 6 Jul 2016, Mike Snitzer wrote:
> On Mon, Jul 04 2016 at 6:53pm -0400,
> Mikulas Patocka wrote:
>
> > Hi
> >
> > This is the second version of patches that fix deadlocks by redirecting
> > bios from current->bio_list to rescuer workqueues.
> >
> > I found out that the original patc
On Wed, 6 Jul 2016, Mike Snitzer wrote:
> > > I'd much preferred you just send an incremental fix that built on the
> > > tree you know I started, here:
> > > http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/log/?h=wip
> >
> > You need to change three patches in your git:
> > * blo
On Wed, Jul 6, 2016 at 8:38 PM, Lars Ellenberg
wrote:
> On Mon, Jul 04, 2016 at 06:47:29PM +0800, Ming Lei wrote:
>> >> One clean solution may be to convert the loop of generic_make_request()
>> >> into the following way:
>> >>
>> >> do {
>> >> struct bio *splitted, *remainder = NULL;
>> >>
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index a382985..b1dbf28 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1221,7 +122
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 4bf7747..e8e9b6a 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1297,6 +1297,12 @@ stat
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index f6120e1..cc6eb7c 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2510,10 +
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 248053d..4bf7747 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -366,14 +366,12 @@ static
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 2fb5a9b..14b3d93 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-rai
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 4caf51fe..2ea3982 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index d387d24..f6120e1 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1610,7 +1
From: Heinz Mauelshagen
Patch series vs. kernel.org linux-dm, branch dm-4.8 to address
issues identified:
- superfluous memory bariers
- missing constructor argument checks (sync/nosync)
- typo in write_mostly constructor argument
- function argument types
- recovery ad raid set size issues
-
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index e4d0bc1..0aaf4ef 100644
--- a/drivers/md/dm-raid.c
+++ b/driver
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 7a33af9..109d698 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -300,7 +300,7
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 5e41bf3..7a33af9 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2772,10
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 6dc4940..8118f1e 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -622,8 +622,16 @@ stat
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 4572202..5e41bf3 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2850,8 +285
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 14b3d93..1ff469f 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -372,7 +37
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 1ff469f..846c58d 100644
--- a/drivers/md/dm-raid.c
+++ b/d
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 64
1 file changed, 55 insertions(+), 9 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 63883f4..7e334b6 100644
--- a/drivers/md/
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 2ea3982..e4d0bc1 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -3186,8 +3
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index cc6eb7c..62e31b4 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -617,9
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index b1dbf28..d387d24 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1487,8 +1487,6 @@ static int
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 62e31b4..63883f4 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -616,
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 8118f1e..4572202 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-ra
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 7e334b6..6dc4940 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 109d698..2fb5a9b 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 167 ---
1 file changed, 106 insertions(+), 61 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 846c58d..473c6d9 100644
--- a/drivers/m
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index e8e9b6a..0eceee8 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1784,7
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 92
1 file changed, 49 insertions(+), 43 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 473c6d9..4caf51fe 100644
--- a/drivers/m
From: Heinz Mauelshagen
Signed-off-by: Heinz Mauelshagen
---
drivers/md/dm-raid.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 0eceee8..a382985 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1025,7
On 06/29/2016 03:36 PM, Xose Vazquez Perez wrote:
> spotted by clang-3.8.0:
>
> make[1]: Entering directory
> '/home/xose/tmp/arrays/multipath-tools.x1/multipathd'
> clang -O2 -g -pipe -Wformat-security -Wall -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -Wunused -Wstrict-prototype
On Wed, Jun 22 2016, Lars Ellenberg wrote:
> For a long time, generic_make_request() converts recursion into
> iteration by queuing recursive arguments on current->bio_list.
>
> This is convenient for stacking drivers,
> the top-most driver would take the originally submitted bio,
> and re-submit
On 07/06/2016 09:54 PM, Xose Vazquez Perez wrote:
> On 06/29/2016 03:36 PM, Xose Vazquez Perez wrote:
>
>> spotted by clang-3.8.0:
>>
>> make[1]: Entering directory
>> '/home/xose/tmp/arrays/multipath-tools.x1/multipathd'
>> clang -O2 -g -pipe -Wformat-security -Wall -fexceptions -fstack-protecto
43 matches
Mail list logo