[dm-devel] [PATCH] multipathd: fix waiter_attr resource leak

As a global variable waiter_attr of thread attribute was set up in the daemon, however,it hasn't been destroyed when the daemon exited. We need deinitialize waiter_attr. --- multipathd/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/multipathd/main.c b/multipathd/main.c index b8

Re: [dm-devel] dm-flakey NOT to return -EIO on READ?

Hi, Yes this part is wrong and reads are not dropped. I have a patch ready, just have to send it out. Lukas On Wed, Jul 6, 2016 at 8:33 AM, Akira Hayakawa wrote: > Hi, > > I am using dm-flakey to emulate a broken device that should return -EIO on > both read and write. > I use the parameter up_

Re: [dm-devel] [RFC] block: fix blk_queue_split() resource exhaustion

On Mon, Jul 04, 2016 at 06:47:29PM +0800, Ming Lei wrote: > >> One clean solution may be to convert the loop of generic_make_request() > >> into the following way: > >> > >> do { > >> struct bio *splitted, *remainder = NULL; > >> struct request_queue *q = bdev_get_queue(bio->bi_bdev); > >>

Re: [dm-devel] dm-flakey NOT to return -EIO on READ?

Thanks, I want the patch in the main-tree quickly. Because without it, my tests will not be green. This is really annoying. I made a quick reproducer of this problem. If you are looking for one, this will help. (You need to install sbt first) https://github.com/akiradeveloper/writeboost-test-sui

Re: [dm-devel] [PATCH RESENT] dm: Check kthread_run's return value

On Mon, Jul 04 2016 at 11:25am -0400, Minfei Huang wrote: > kthread function is used to process kthread_work. And there is no return > value checking during create this thread. Add this checking to fix this > issue. > > Signed-off-by: Minfei Huang > --- > drivers/md/dm.c | 11 +-- > 1

Re: [dm-devel] [PATCH RESENT] dm: Check kthread_run's return value

On 07/06/16 at 09:16P, Mike Snitzer wrote: > On Mon, Jul 04 2016 at 11:25am -0400, > Minfei Huang wrote: > > > kthread function is used to process kthread_work. And there is no return > > value checking during create this thread. Add this checking to fix this > > issue. > > > > Signed-off-by: Mi

Re: [dm-devel] [PATCH RESENT] dm: Check kthread_run's return value

On Wed, Jul 06 2016 at 9:27am -0400, Minfei Huang wrote: > On 07/06/16 at 09:16P, Mike Snitzer wrote: > > On Mon, Jul 04 2016 at 11:25am -0400, > > Minfei Huang wrote: > > > > > kthread function is used to process kthread_work. And there is no return > > > value checking during create this thr

Re: [dm-devel] [PATCH 0/3] offload bios to a thread

On Mon, Jul 04 2016 at 6:53pm -0400, Mikulas Patocka wrote: > Hi > > This is the second version of patches that fix deadlocks by redirecting > bios from current->bio_list to rescuer workqueues. > > I found out that the original patches caused deadlock with the loopback > device. When the loo

Re: [dm-devel] [PATCH RESENT] dm: Check kthread_run's return value

On 07/06/16 at 09:31P, Mike Snitzer wrote: > On Wed, Jul 06 2016 at 9:27am -0400, > Minfei Huang wrote: > > > On 07/06/16 at 09:16P, Mike Snitzer wrote: > > > On Mon, Jul 04 2016 at 11:25am -0400, > > > Minfei Huang wrote: > > > > > > > kthread function is used to process kthread_work. And the

Re: [dm-devel] [PATCH 0/3] offload bios to a thread

On Wed, Jul 06 2016 at 9:53am -0400, Mikulas Patocka wrote: > > > On Wed, 6 Jul 2016, Mike Snitzer wrote: > > > On Mon, Jul 04 2016 at 6:53pm -0400, > > Mikulas Patocka wrote: > > > > > Hi > > > > > > This is the second version of patches that fix deadlocks by redirecting > > > bios from

Re: [dm-devel] [PATCH 0/3] offload bios to a thread

On Wed, 6 Jul 2016, Mike Snitzer wrote: > On Mon, Jul 04 2016 at 6:53pm -0400, > Mikulas Patocka wrote: > > > Hi > > > > This is the second version of patches that fix deadlocks by redirecting > > bios from current->bio_list to rescuer workqueues. > > > > I found out that the original patc

Re: [dm-devel] [PATCH 0/3] offload bios to a thread

On Wed, 6 Jul 2016, Mike Snitzer wrote: > > > I'd much preferred you just send an incremental fix that built on the > > > tree you know I started, here: > > > http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/log/?h=wip > > > > You need to change three patches in your git: > > * blo

Re: [dm-devel] [RFC] block: fix blk_queue_split() resource exhaustion

On Wed, Jul 6, 2016 at 8:38 PM, Lars Ellenberg wrote: > On Mon, Jul 04, 2016 at 06:47:29PM +0800, Ming Lei wrote: >> >> One clean solution may be to convert the loop of generic_make_request() >> >> into the following way: >> >> >> >> do { >> >> struct bio *splitted, *remainder = NULL; >> >>

[dm-devel] [PATCH 05/26] dm raid: more restricting data_offset value checks

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index a382985..b1dbf28 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -1221,7 +122

[dm-devel] [PATCH 02/26] dm raid: prohibit to pass in both sync and nosync ctr flags

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 4bf7747..e8e9b6a 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -1297,6 +1297,12 @@ stat

[dm-devel] [PATCH 08/26] dm raid: fix comment typos

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index f6120e1..cc6eb7c 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2510,10 +

[dm-devel] [PATCH 01/26] dm raid: avoid superfluous memory barriers on static metadata

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 248053d..4bf7747 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -366,14 +366,12 @@ static

[dm-devel] [PATCH 19/26] dm raid: fix rebuild and catch bogus sync/resync flags

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 2fb5a9b..14b3d93 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-rai

[dm-devel] [PATCH 24/26] dm raid: use rs->raid_disks to avoid memory leaks on free and more consistent throughout

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 4caf51fe..2ea3982 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -

[dm-devel] [PATCH 07/26] dm raid: enhance comments in takeover checks

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index d387d24..f6120e1 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -1610,7 +1

[dm-devel] [PATCH 00/26] dm raid: fix/cleanup for dm-4.8 inclusion

From: Heinz Mauelshagen Patch series vs. kernel.org linux-dm, branch dm-4.8 to address issues identified: - superfluous memory bariers - missing constructor argument checks (sync/nosync) - typo in write_mostly constructor argument - function argument types - recovery ad raid set size issues -

[dm-devel] [PATCH 26/26] dm raid: change logical functions to actually return bool

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index e4d0bc1..0aaf4ef 100644 --- a/drivers/md/dm-raid.c +++ b/driver

[dm-devel] [PATCH 17/26] dm raid: fix typo in write_mostly flag

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 7a33af9..109d698 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -300,7 +300,7

[dm-devel] [PATCH 16/26] dm raid: also reject size change during recovery

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 5e41bf3..7a33af9 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2772,10

[dm-devel] [PATCH 13/26] dm raid: fix raid10 device size error on out-of-place reshape

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 6dc4940..8118f1e 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -622,8 +622,16 @@ stat

[dm-devel] [PATCH 15/26] dm raid: fix new superblock/bitmap creation on disk addition

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 4572202..5e41bf3 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2850,8 +285

[dm-devel] [PATCH 20/26] dm raid: fix rs_is_recovering() to allow for lvextend

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 14b3d93..1ff469f 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -372,7 +37

[dm-devel] [PATCH 21/26] dm raid: found way to allow resize during shrink

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 1ff469f..846c58d 100644 --- a/drivers/md/dm-raid.c +++ b/d

[dm-devel] [PATCH 11/26] dm raid: clearify and fix recovery

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 64 1 file changed, 55 insertions(+), 9 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 63883f4..7e334b6 100644 --- a/drivers/md/

[dm-devel] [PATCH 25/26] dm raid: use rdev_for_each in status

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 2ea3982..e4d0bc1 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3186,8 +3

[dm-devel] [PATCH 09/26] dm raid: make rs_set_capacity to work on shrinking reshape

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index cc6eb7c..62e31b4 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -617,9

[dm-devel] [PATCH 06/26] dm raid: remove bogus comment

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index b1dbf28..d387d24 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -1487,8 +1487,6 @@ static int

[dm-devel] [PATCH 10/26] dm raid: fix rs_set_capacity on growing reshape

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 62e31b4..63883f4 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -616,

[dm-devel] [PATCH 14/26] dm raid: comments and fixed typos

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 8118f1e..4572202 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-ra

[dm-devel] [PATCH 12/26] dm raid: prohibit 'nosync' on new raid6 and reject resize during reshape

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 7e334b6..6dc4940 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid

[dm-devel] [PATCH 18/26] dm raid: fix ctr memory leaks on error paths

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 109d698..2fb5a9b 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md

[dm-devel] [PATCH 22/26] dm raid: enhance reshape check and factor out reshape setup

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 167 --- 1 file changed, 106 insertions(+), 61 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 846c58d..473c6d9 100644 --- a/drivers/m

[dm-devel] [PATCH 03/26] dm raid: the sync_page_io() metadata_op argument is bool

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index e8e9b6a..0eceee8 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -1784,7

[dm-devel] [PATCH 23/26] dm raid: support delta_disk for raid1, fix table output

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 92 1 file changed, 49 insertions(+), 43 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 473c6d9..4caf51fe 100644 --- a/drivers/m

[dm-devel] [PATCH 04/26] dm raid: reject too many write_mostly devices

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-raid.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 0eceee8..a382985 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -1025,7

Re: [dm-devel] [BUG] multipath-tools: multipathd/main.c: cannot jump from this goto statement to its label

On 06/29/2016 03:36 PM, Xose Vazquez Perez wrote: > spotted by clang-3.8.0: > > make[1]: Entering directory > '/home/xose/tmp/arrays/multipath-tools.x1/multipathd' > clang -O2 -g -pipe -Wformat-security -Wall -fexceptions -fstack-protector > --param=ssp-buffer-size=4 -Wunused -Wstrict-prototype

Re: [dm-devel] [RFC] block: fix blk_queue_split() resource exhaustion

On Wed, Jun 22 2016, Lars Ellenberg wrote: > For a long time, generic_make_request() converts recursion into > iteration by queuing recursive arguments on current->bio_list. > > This is convenient for stacking drivers, > the top-most driver would take the originally submitted bio, > and re-submit

Re: [dm-devel] [BUG] multipath-tools: multipathd/main.c: cannot jump from this goto statement to its label

On 07/06/2016 09:54 PM, Xose Vazquez Perez wrote: > On 06/29/2016 03:36 PM, Xose Vazquez Perez wrote: > >> spotted by clang-3.8.0: >> >> make[1]: Entering directory >> '/home/xose/tmp/arrays/multipath-tools.x1/multipathd' >> clang -O2 -g -pipe -Wformat-security -Wall -fexceptions -fstack-protecto