[dm-devel] [PATCH 5/5] multipath-tools: hwtable housekeeping

2016-07-22 Thread Xose Vazquez Perez
Mainly: arrange some families, clean redundant labels, detail IBM devices, add remaining attributes to last member(NULL) and add missing vendor labels. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 299 ++

[dm-devel] [PATCH 2/5] multipath-tools: Clarify template rules of hwtable

2016-07-22 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 8eec209..6f9adc9 100644 --- a/libmultipath/hwtable.c

[dm-devel] [PATCH 4/5] multipath-tools: replace leading spaces with tabs II

2016-07-22 Thread Xose Vazquez Perez
Mainly replace less than 8 ^spaces with tabs where is required and remove ^space from goto labels. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- kpartx/Makefile | 2 +- kpartx/dasd.c | 2 +- kpartx/gpt.c

[dm-devel] [PATCH 3/5] multipath-tools: use parentheses() to cover a regex with pipe|

2016-07-22 Thread Xose Vazquez Perez
Easier to read, and maintain consistency with the rest. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath

[dm-devel] [PATCH 1/5] multipath-tools: delete no_path_retry attribute when it is equal to default value

2016-07-22 Thread Xose Vazquez Perez
Defaul value is already 0 (NO_PATH_RETRY_UNDEF) Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index a1fc3e8..8eec209 100644 ---

Re: [dm-devel] [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread NeilBrown
On Fri, Jul 22 2016, Michal Hocko wrote: > On Fri 22-07-16 18:46:57, Neil Brown wrote: >> On Mon, Jul 18 2016, Michal Hocko wrote: >> >> > From: Michal Hocko >> > >> > Mikulas has reported that a swap backed by dm-crypt doesn't work >> > properly because the swapout cannot make a sufficient forw

[dm-devel] During systemd/udev, device-mapper trying to work with non-LVM volumes

2016-07-22 Thread james harvey
If I understand what's going on here, I think device-mapper is trying to work with two volumes that don't involve LVM, causing the errors. Is this a device-mapper bug? A udev bug? Something I have configured wrong? During boot, I see the following messages: === start

[dm-devel] [RFC] multipathd: memory leak from orphan_path()

2016-07-22 Thread Gi-Oh Kim
Hello, I checked the memory consuming of the multipathd and found it consumes too much memory. Following is the result I have got from 6 servers. Longer running multipathd consumes more memory. # ps -eo user,pid,ppid,rss,size,vsize,pmem,pcpu,time,cmd --sort -rss | grep multipath root 2948

Re: [dm-devel] [RFC PATCH 1/2] mempool: do not consume memory reserves from the reclaim path

2016-07-22 Thread Andrew Morton
On Fri, 22 Jul 2016 14:26:19 +0200 Vlastimil Babka wrote: > On 07/22/2016 08:37 AM, Michal Hocko wrote: > > On Thu 21-07-16 16:53:09, Michal Hocko wrote: > >> From d64815758c212643cc1750774e2751721685059a Mon Sep 17 00:00:00 2001 > >> From: Michal Hocko > >> Date: Thu, 21 Jul 2016 16:40:59 +0200

Re: [dm-devel] [RFC PATCH 1/2] mempool: do not consume memory reserves from the reclaim path

2016-07-22 Thread Vlastimil Babka
On 07/22/2016 08:37 AM, Michal Hocko wrote: On Thu 21-07-16 16:53:09, Michal Hocko wrote: From d64815758c212643cc1750774e2751721685059a Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Thu, 21 Jul 2016 16:40:59 +0200 Subject: [PATCH] Revert "mm, mempool: only set __GFP_NOMEMALLOC if there are

[dm-devel] [PATCH] multipathd: Correctly invalidate configuration during shutdown

2016-07-22 Thread Hannes Reinecke
We still need to use rcu primitives when shutting down the system; the original configuration might have become invalidated. Signed-off-by: Hannes Reinecke --- libmultipath/structs_vec.c | 2 ++ multipathd/main.c | 16 +--- 2 files changed, 15 insertions(+), 3 deletions(-)

Re: [dm-devel] [RFC PATCH 1/2] mempool: do not consume memory reserves from the reclaim path

2016-07-22 Thread Johannes Weiner
On Thu, Jul 21, 2016 at 04:53:10PM +0200, Michal Hocko wrote: > From: Michal Hocko > Date: Thu, 21 Jul 2016 16:40:59 +0200 > Subject: [PATCH] Revert "mm, mempool: only set __GFP_NOMEMALLOC if there are > free elements" > > This reverts commit f9054c70d28bc214b2857cf8db8269f4f45a5e23. > > There

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-22 Thread Eric Wheeler
[+cc Mikulas Patocka, Jeff Moyer; Do either of you have any input on Lars' commentary related to patchwork #'s 9204125 and 7398411 and BZ#119841? ] On Tue, 19 Jul 2016, Lars Ellenberg wrote: > On Tue, Jul 12, 2016 at 10:32:33PM -0400, Mike Snitzer wrote: > > On Tue, Jul 12 2016 at 10:18pm -0400,

Re: [dm-devel] [PATCH] multipathd: fix typo that breaks failure path

2016-07-22 Thread Christophe Varoqui
Merged. Thanks. On Thu, Jul 21, 2016 at 10:59 PM, Benjamin Marzinski wrote: > There wasn't supposed to be a semicolon after the "else" when checking > paths in checkerloop(). > > Signed-off-by: Benjamin Marzinski > --- > multipathd/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [dm-devel] [PATCH 0/6] Delete attributes with default values

2016-07-22 Thread Christophe Varoqui
Ok. All defaults settings tweaks and removal patches from Xosé are merged. Thanks. On Wed, Jul 13, 2016 at 6:17 PM, Benjamin Marzinski wrote: > On Sat, Jul 09, 2016 at 10:17:05AM +0200, Christophe Varoqui wrote: > >I'll wait for comments from distribution maintainers on this patchset. > >

Re: [dm-devel] [PATCH] multipath-tools: add template to add new hardware

2016-07-22 Thread Christophe Varoqui
Merged. Thanks. On Tue, Jul 12, 2016 at 4:41 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > --- > libmultipath/hwtable.c | 42 ++ > 1 file changed, 42 insertions(+) > > diff

Re: [dm-devel] [PATCH] kpartx: Fix check whether to detach loop device

2016-07-22 Thread Christophe Varoqui
Merged. Thanks. On Wed, Jul 13, 2016 at 7:23 PM, Christian Kastner wrote: > From: Christian Kastner > > When invoking kpartx -d $FOO with $FOO being a regular file, the intention > is > to also detach the loop device backing $FOO using del_loop(), but this > currently doesn't happen, as can be

Re: [dm-devel] [PATCH] libmultipath:fix loop traversed partly

2016-07-22 Thread Christophe Varoqui
Your fix is now merged. Thanks. On Thu, Jul 14, 2016 at 2:09 PM, wrote: > From: "zhang.kai" > > Problem: > With each iteration of the vector_foreach_slot() loop statement, > some slots couldn't be traversed when a slot is deleted from vector. > > Reasons: > Currently,loop's index 'i' is not dec

Re: [dm-devel] [PATCH 0/3] sysfs prioritizer

2016-07-22 Thread Christophe Varoqui
Finally merged. Thanks. On Fri, Jul 15, 2016 at 8:48 AM, Hannes Reinecke wrote: > Hi all, > > this is a resend of a previous patchset for adding a 'sysfs' > prioritizer. This prioritizer uses the sysfs attributes > 'access_state' and 'exclusive_pref_bit' to generate the > path priority. > Priori

Re: [dm-devel] [PATCH] multipath-tools: remove final \ in fprintf

2016-07-22 Thread Christophe Varoqui
Merged. On Mon, Jul 18, 2016 at 3:23 PM, Xose Vazquez Perez wrote: > Useless. > > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > --- > multipath/main.c | 64 > > 1 file changed, 32 insertio

Re: [dm-devel] [PATCH 2/3] multipath-tools: merge OPTFLAGS into CFLAGS

2016-07-22 Thread Christophe Varoqui
Reverted. On Fri, Jul 15, 2016 at 12:19 PM, Hannes Reinecke wrote: > On 07/08/2016 06:28 PM, Xose Vazquez Perez wrote: > > OPTFLAGS is not used anywhere, but maybe it's intrusive for > distributions. > > > > Cc: Mathieu Trudel-Lapierre > > Cc: Dragan Stancevic > > Cc: Louis Bouchard > > Cc: R

Re: [dm-devel] [PATCH] multipath-tools: replace with

2016-07-22 Thread Christophe Varoqui
I merged all the pending 'include'-related patches. Thanks. On Fri, Jul 22, 2016 at 12:01 AM, Xose Vazquez Perez wrote: > The standard place of wait.h is under /usr/include/sys/ > Spotted by musl libc. > > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Per

Re: [dm-devel] [PATCH 1/6] multipath-tools: delete attributes with DEFAULT_* values in hwtable.c

2016-07-22 Thread Christophe Varoqui
Merged. On Sat, Jul 9, 2016 at 1:58 AM, Xose Vazquez Perez wrote: > 48 .features = DEFAULT_FEATURES, > 44 .hwhandler = DEFAULT_HWHANDLER, > 28 .prio_name = DEFAULT_PRIO, > 1 .minio = DEFAULT

Re: [dm-devel] [PATCH] multipathd: fix memory leak in reconfigure()

2016-07-22 Thread Christophe Varoqui
Merged. Thanks. On Mon, Jul 18, 2016 at 2:14 PM, wrote: > From: "tang.junhui" > > Problem: > Memory leak exists in reconfigure() when multipathd command reconfigure is > executed. > > Reasons: > * The following judgment condition is not satisfied when there is no path, >free_pathvec() is n

Re: [dm-devel] [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread Michal Hocko
On Fri 22-07-16 18:46:57, Neil Brown wrote: > On Mon, Jul 18 2016, Michal Hocko wrote: > > > From: Michal Hocko > > > > Mikulas has reported that a swap backed by dm-crypt doesn't work > > properly because the swapout cannot make a sufficient forward progress > > as the writeout path depends on d

Re: [dm-devel] [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread NeilBrown
On Fri, Jul 22 2016, NeilBrown wrote: > > Looking at the current code, __GFP_DIRECT_RECLAIM is disabled the first > time through, but if the pool is empty, direct-reclaim is allowed on the > next attempt. Presumably this is where the throttling comes in ?? I > suspect that it really shouldn't do

Re: [dm-devel] [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread NeilBrown
On Mon, Jul 18 2016, Michal Hocko wrote: > From: Michal Hocko > > Mikulas has reported that a swap backed by dm-crypt doesn't work > properly because the swapout cannot make a sufficient forward progress > as the writeout path depends on dm_crypt worker which has to allocate > memory to perform t