Re: [dm-devel] dm-mq and end_clone_request()

2016-08-08 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Bart Van Assche" > Cc: dm-devel@redhat.com, "Mike Snitzer" , > linux-s...@vger.kernel.org, "Johannes Thumshirn" > > Sent: Monday, August 8,

Re: [dm-devel] dm-mq and end_clone_request()

2016-08-08 Thread Laurence Oberman
- Original Message - > From: "Bart Van Assche" > To: "Laurence Oberman" > Cc: dm-devel@redhat.com, "Mike Snitzer" , > linux-s...@vger.kernel.org, "Johannes Thumshirn" > > Sent: Monday, August 8,

Re: [dm-devel] dm-mq and end_clone_request()

2016-08-08 Thread Bart Van Assche
On 08/08/2016 08:26 AM, Laurence Oberman wrote: > I will test this as well. > I have lost my DDN array today (sadly:)) but I have two systems > back to back again using ramdisk on the one to serve LUNS. > > If I pull from https://github.com/bvanassche/linux again, and > switch branch to

Re: [dm-devel] dm-mq and end_clone_request()

2016-08-08 Thread Bart Van Assche
On 08/08/16 06:44, Johannes Thumshirn wrote: So __scsi_remove_device() is also checking for sdev->sdev_state == SDEV_DEL and returns if so. If it would have the chance to do so the goto restart would be hit and we'd reatart the list traverse. The if in turn just continues and I've seen endless

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

2016-08-08 Thread Jens Axboe
On 08/08/2016 10:32 AM, Benjamin Block wrote: On 12:06 Fri 05 Aug , Mike Snitzer wrote: On Fri, Aug 05 2016 at 11:54am -0400, Jens Axboe wrote: On 08/05/2016 09:42 AM, Mike Snitzer wrote: On Fri, Aug 05 2016 at 11:33P -0400, Jens Axboe wrote: On

Re: [dm-devel] dm-mq and end_clone_request()

2016-08-08 Thread Bart Van Assche
On 08/06/16 07:47, Laurence Oberman wrote: > [66814.772851] [] ? panic+0x1eb/0x233 > [66814.800207] [] oops_end+0xb8/0xd0 > [66814.827454] [] no_context+0x13e/0x3a0 > [66814.858368] [] ? __slab_free+0x9b/0x280 > [66814.890365] [] __bad_area_nosemaphore+0xee/0x1d0 > [66814.926508] []

[dm-devel] [PATCH -next] dm flakey: fix error return code in flakey_ctr()

2016-08-08 Thread Wei Yongjun
Fix to return error code -EINVAL instead of 0(r is overwrote to 0 by dm_read_arg() call), as done elsewhere in this function. Fixes: e80d1c805a3b ("dm: do not override error code returned from dm_get_device()") Signed-off-by: Wei Yongjun --- drivers/md/dm-flakey.c | 2 ++ 1

Re: [dm-devel] dm-mq and end_clone_request()

2016-08-08 Thread Johannes Thumshirn
On Mon, Aug 08, 2016 at 08:45:59AM -0400, Laurence Oberman wrote: > > > - Original Message - > > From: "Bart Van Assche" > > To: "Laurence Oberman" > > Cc: "Mike Snitzer" , dm-devel@redhat.com, > > linux-s...@vger.kernel.org

Re: [dm-devel] dm-mq and end_clone_request()

2016-08-08 Thread Laurence Oberman
- Original Message - > From: "Bart Van Assche" > To: "Laurence Oberman" > Cc: "Mike Snitzer" , dm-devel@redhat.com, > linux-s...@vger.kernel.org > Sent: Sunday, August 7, 2016 6:31:11 PM > Subject: Re: [dm-devel] dm-mq and

[dm-devel] [PATCH 3/4] multipath-tools: Add rbd checker.

2016-08-08 Thread Mike Christie
This checker currently only handles the case where a path is failed due to it being blacklisted by the ceph cluster. The specific use case for me is when LIO exports rbd images through multiple LIO instances. The problem it handles is when rbd instance1 has the exclusive lock, but becomes

[dm-devel] [PATCH 1/4] libmultipath: add rbd discovery

2016-08-08 Thread Mike Christie
rbd is a block device interface for Ceph. It does not support any SCSI commands, so this patch adds bus detection and virtual vendor/product pathinfo. Changes since v1: 1. Drop ID_UID use and implemented sysfs getuid support. Signed-off-by: Mike Christie ---

[dm-devel] PATCH 0/4] multipath-tools: Ceph rbd support v2

2016-08-08 Thread Mike Christie
The following patches made over Christophe's tree today, add Ceph rbd support for handling blacklisted devices. This is not general support for rbd and multipath. There is no boot/root support and it does not support features like multibus. My use is for HA configurations, specifically for

[dm-devel] [PATCH 4/4] multipath-tools: Add rbd to the hwtable

2016-08-08 Thread Mike Christie
Add rbd to hwtable. These defaults are for the HA type of setup supported by the checker. We do no support features like multibus at the dm-multipath level yet. Changes since v1: 1. Drop settings that were defaults and follow template. 2. Drop ID_UID use. Signed-off-by: Mike Christie

[dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-08 Thread Mike Christie
This patch adds a callback which can be used to repair a path if check() has determined it is in the PATH_DOWN state. The next patch that adds rbd checker support which will use this to handle the case where a rbd device is blacklisted. Signed-off-by: Mike Christie ---