Re: [dm-devel] dm-crypt: Fix error with too large bios

2016-08-30 Thread Mikulas Patocka
On Tue, 30 Aug 2016, Mike Snitzer wrote: > On Tue, Aug 30 2016 at 8:19P -0400, > Mikulas Patocka wrote: > > > > > > > On Tue, 30 Aug 2016, Ming Lei wrote: > > > > > On Tue, Aug 30, 2016 at 5:57 AM, Mikulas Patocka > > > wrote: > > > > > > > > > > > > On Mon, 29 Aug 2016, Ming Lei wrote:

[dm-devel] [PATCH] dm-bufio: Remove deprecated create_singlethread_workqueue

2016-08-30 Thread Bhaktipriya Shridhar
The workqueue "dm_bufio_wq" queues a single work item &dm_bufio_work and hence it doesn't require execution ordering. Hence, alloc_workqueue has been used to replace the deprecated create_singlethread_workqueue instance. The WQ_MEM_RECLAIM flag has been set since md / dm are block multi disk drive

[dm-devel] [PATCH] dm crypt: fix free of bad values after tfm allocation failure

2016-08-30 Thread Eric Biggers
If crypt_alloc_tfms() had to allocate multiple tfms and it failed before the last allocation, then it would call crypt_free_tfms() and free pointers from uninitialized memory. Fix by allocating zeroed memory. Signed-off-by: Eric Biggers --- drivers/md/dm-crypt.c | 2 +- 1 file changed, 1 insert

Re: [dm-devel] dm-crypt: Fix error with too large bios

2016-08-30 Thread Mike Snitzer
On Tue, Aug 30 2016 at 8:19P -0400, Mikulas Patocka wrote: > > > On Tue, 30 Aug 2016, Ming Lei wrote: > > > On Tue, Aug 30, 2016 at 5:57 AM, Mikulas Patocka > > wrote: > > > > > > > > > On Mon, 29 Aug 2016, Ming Lei wrote: > > > > > >> On Sat, Aug 27, 2016 at 11:09 PM, Mikulas Patocka > >

Re: [dm-devel] dm-crypt: Fix error with too large bios

2016-08-30 Thread Mikulas Patocka
On Tue, 30 Aug 2016, Ming Lei wrote: > On Tue, Aug 30, 2016 at 5:57 AM, Mikulas Patocka wrote: > > > > > > On Mon, 29 Aug 2016, Ming Lei wrote: > > > >> On Sat, Aug 27, 2016 at 11:09 PM, Mikulas Patocka > >> wrote: > >> > > >> > But this patch won't work for device mapper, blk_bio_segment_spl

Re: [dm-devel] dm-crypt: Fix error with too large bios

2016-08-30 Thread Ming Lei
On Tue, Aug 30, 2016 at 5:57 AM, Mikulas Patocka wrote: > > > On Mon, 29 Aug 2016, Ming Lei wrote: > >> On Sat, Aug 27, 2016 at 11:09 PM, Mikulas Patocka >> wrote: >> > >> > >> > On Fri, 26 Aug 2016, Mike Snitzer wrote: >> > >> >> On Thu, Aug 25 2016 at 4:13pm -0400, >> >> Jens Axboe wrote: >>