Re: [dm-devel] dm-mpath: Handling SCSI-3 PR RELEASE in multi-controller environment

2016-09-21 Thread Christoph Hellwig
On Wed, Sep 21, 2016 at 11:04:27AM -0400, Mike Snitzer wrote: > Which kernel are you using? Christoph (now cc'd) has introduced a new > PR api. I merged a fix from him relatively recently (commit 9c72bad1f3 > "dm: call PR reserve/unreserve on each underlying device") The PR API will handle this

Re: [dm-devel] dm-mpath: Handling SCSI-3 PR RELEASE in multi-controller environment

2016-09-21 Thread Mike Snitzer
On Wed, Sep 21 2016 at 5:14am -0400, jiangyiwen wrote: > Hi guys, > > I'm sorry if someone else has already asked the same question before, but > here's what we are facing with generic multipath. > > We were evaluating SCSI-3 PR and hit the following issue: > > Our IPSAN has two controllers (

[dm-devel] [PATCH] dm crypt: fix crash on exit

2016-09-21 Thread Rabin Vincent
From: Rabin Vincent As the documentation for kthread_stop() says, "if threadfn() may call do_exit() itself, the caller must ensure task_struct can't go away". dm-crypt does not ensure this and therefore crashes when crypt_dtr() calls kthread_stop(). The crash is trivially reproducible by adding

Re: [dm-devel] dm crypt: fix crash on exit

2016-09-21 Thread Mike Snitzer
On Wed, Sep 21 2016 at 10:22am -0400, Rabin Vincent wrote: > From: Rabin Vincent > > As the documentation for kthread_stop() says, "if threadfn() may call > do_exit() itself, the caller must ensure task_struct can't go away". > dm-crypt does not ensure this and therefore crashes when crypt_dtr(

[dm-devel] dm-mpath: Handling SCSI-3 PR RELEASE in multi-controller environment

2016-09-21 Thread jiangyiwen
Hi guys, I'm sorry if someone else has already asked the same question before, but here's what we are facing with generic multipath. We were evaluating SCSI-3 PR and hit the following issue: Our IPSAN has two controllers (C1/C2). Our host is connected to both controllers. So we have 2 I_T nexus.

[dm-devel] [PATCH] dm flakey: add DAX support

2016-09-21 Thread Dave Jiang
Change dm-flakey to implement direct_access function, flakey_direct_access(), which maps sector and calls direct_access function of its physical target device. This pretty much is a copy from DM Linear. This allows fs with DAX to pass in xfstests. It does not actually introduce data corruption and

[dm-devel] [PATCH] mpathpersist: memset length is wrong

2016-09-21 Thread tang . junhui
From: "tang.junhui" variable transportids is cleared by memset() with wrong length MPATH_MX_TIDS, the length should be MPATH_MX_TIDS*sizeof(struct transportid). Signed-off-by: tang.junhui --- mpathpersist/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mpathpersist/m