Re: [dm-devel] [PATCH v5 0/3] init: add support to directly boot to a mapped device

2016-11-16 Thread Barry Kauler
Hi, I have just joined this list. I am a newcomer to using device-mapper. I currently maintain Quirky Linux, prior to that, Puppy Linux. Puppy uses overlay filesystems, usually aufs, to achieve what could also be done, partly, with device-mapper. Puppy has a initramfs, however, Quirky is a traditi

Re: [dm-devel] Improve processing efficiency for addition and deletion of multipath devices

2016-11-16 Thread tang . junhui
Hi Martin, Nice to see you, May you success in your team and our open source community. You have put forward a good proposal to queued more uevent messages by kicking uevent processing thread in a predefined time intervals. It is also a good idea to have such intervals configuration. As to

Re: [dm-devel] [PATCH 2/7] dm: Simplify dm_table_determine_type()

2016-11-16 Thread Mike Snitzer
On Wed, Nov 16 2016 at 4:53pm -0500, Bart Van Assche wrote: > On 11/16/2016 01:11 PM, Mike Snitzer wrote: > >On Wed, Nov 16 2016 at 3:14pm -0500, > >Bart Van Assche wrote: > >>After having added WARN_ON_ONCE(sq_count == 0 && mq_count == 0) > >>close to the end of dm_table_determine_type() the

Re: [dm-devel] [PATCH 2/7] dm: Simplify dm_table_determine_type()

2016-11-16 Thread Bart Van Assche
On 11/16/2016 01:11 PM, Mike Snitzer wrote: On Wed, Nov 16 2016 at 3:14pm -0500, Bart Van Assche wrote: After having added WARN_ON_ONCE(sq_count == 0 && mq_count == 0) close to the end of dm_table_determine_type() the following output appeared: WARNING: CPU: 0 PID: 2458 at drivers/md/dm-table

Re: [dm-devel] [PATCH 2/7] dm: Simplify dm_table_determine_type()

2016-11-16 Thread Mike Snitzer
On Wed, Nov 16 2016 at 3:14pm -0500, Bart Van Assche wrote: > On 11/16/2016 06:54 AM, Mike Snitzer wrote: > >On Tue, Nov 15 2016 at 6:33pm -0500, > >Bart Van Assche wrote: > >>+/* > >>+ * Returns true if all paths are blk-mq devices. Returns false if all paths > >>+ * are single queue block de

[dm-devel] [PATCH v2] dm-crypt: add ability to use keys from the kernel key retention service

2016-11-16 Thread Ondrej Kozina
(Please still consider it to be RFC only, I need to modify the uspace teststuite again due to changes in key_string format. Also the changes to dm-crypt documentation will follow before final submit. Feature wide I'd consider the patch being complete unless any bugs would emerge) The kernel key

Re: [dm-devel] [PATCH 2/7] dm: Simplify dm_table_determine_type()

2016-11-16 Thread Bart Van Assche
On 11/16/2016 06:54 AM, Mike Snitzer wrote: On Tue, Nov 15 2016 at 6:33pm -0500, Bart Van Assche wrote: +/* + * Returns true if all paths are blk-mq devices. Returns false if all paths + * are single queue block devices or if there are no paths. + */ This code isn't specific to multipath. S

Re: [dm-devel] [PATCH 0/7] dm-mpath: Fix a race condition in the blk-mq path

2016-11-16 Thread Mike Snitzer
On Wed, Nov 16 2016 at 1:22pm -0500, Bart Van Assche wrote: > On 11/16/2016 06:56 AM, Mike Snitzer wrote: > >7 is not acceptable. It complicates the code for no reason (the > >scenario that it is meant to address isn't possible). > > Hello Mike, > > With patch (a) applied I see warning (b) ap

Re: [dm-devel] [PATCH 0/7] dm-mpath: Fix a race condition in the blk-mq path

2016-11-16 Thread Bart Van Assche
On 11/16/2016 06:56 AM, Mike Snitzer wrote: 7 is not acceptable. It complicates the code for no reason (the scenario that it is meant to address isn't possible). Hello Mike, With patch (a) applied I see warning (b) appear a few seconds after I start test 02-sq from the srp-test suite. I thin

[dm-devel] [PATCH] multipath-tools: update bl info for nvme in multipath.conf.5

2016-11-16 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index f8e413c..fb2bc5b 100644 --- a/multipath/multipa

[dm-devel] [PATCH] multipath-tools: merge nvme in similar blacklist regex

2016-11-16 Thread Xose Vazquez Perez
Similar patterns, /dev/nvme[0-9] . Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/blacklist.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libmultipath/blacklist.c b/libmultipath/blacklist.c index f6c4506..9

Re: [dm-devel] dm-cache issue

2016-11-16 Thread Teodor Milkov
On 16.11.2016 11:24, Zdenek Kabelac wrote: Dne 15.11.2016 v 13:38 Teodor Milkov napsal(a): On 14.11.2016 17:34, Zdenek Kabelac wrote: Dne 14.11.2016 v 16:02 Alexander Pashaliyski napsal(a): The server is booting for hours, because of IO load. It seems is triggered a flush from SSD disk (that

Re: [dm-devel] [PATCH 2/7] dm: Simplify dm_table_determine_type()

2016-11-16 Thread Mike Snitzer
On Tue, Nov 15 2016 at 6:33pm -0500, Bart Van Assche wrote: > Use a single loop instead of two loops to determine whether or not > all_blk_mq has to be set. > > Signed-off-by: Bart Van Assche > --- > drivers/md/dm-table.c | 25 - > 1 file changed, 12 insertions(+), 13

Re: [dm-devel] [PATCH 0/7] dm-mpath: Fix a race condition in the blk-mq path

2016-11-16 Thread Mike Snitzer
On Wed, Nov 16 2016 at 2:39am -0500, Hannes Reinecke wrote: > On 11/16/2016 12:31 AM, Bart Van Assche wrote: > > Hello Mike, > > > > The seven patches in this series is what I came up with while reviewing > > and testing the dm-mpath single queue and multiqueue code. It would be > > appreciated

Re: [dm-devel] dm-cache issue

2016-11-16 Thread Zdenek Kabelac
Dne 16.11.2016 v 14:45 Teodor Milkov napsal(a): On 16.11.2016 11:24, Zdenek Kabelac wrote: Dne 15.11.2016 v 13:38 Teodor Milkov napsal(a): On 14.11.2016 17:34, Zdenek Kabelac wrote: Dne 14.11.2016 v 16:02 Alexander Pashaliyski napsal(a): The server is booting for hours, because of IO load. It

Re: [dm-devel] Improve processing efficiency for addition and deletion of multipath devices

2016-11-16 Thread Martin Wilck
Hi Tang, On Wed, 2016-11-16 at 16:45 +0800, tang.jun...@zte.com.cn wrote: > I think we can merger most of uevent messages and reduce most of > unnecessary DM change  > uevent messages during creation/deletion of multipath devices by this > way.  > The method you mentioned I think that it is a lit

Re: [dm-devel] dm-cache issue

2016-11-16 Thread Zdenek Kabelac
Dne 15.11.2016 v 13:38 Teodor Milkov napsal(a): On 14.11.2016 17:34, Zdenek Kabelac wrote: Dne 14.11.2016 v 16:02 Alexander Pashaliyski napsal(a): The server is booting for hours, because of IO load. It seems is triggered a flush from SSD disk (that is used for a cache device) to the raid contr

Re: [dm-devel] dm-cache issue

2016-11-16 Thread Teodor Milkov
On 14.11.2016 17:34, Zdenek Kabelac wrote: Dne 14.11.2016 v 16:02 Alexander Pashaliyski napsal(a): The server is booting for hours, because of IO load. It seems is triggered a flush from SSD disk (that is used for a cache device) to the raid controllers (they are with slow SATA disks). I have 1

Re: [dm-devel] Improve processing efficiency for addition and deletion of multipath devices

2016-11-16 Thread tang . junhui
Hello Hannes: Since the received uevent messages store in the queue, and the speed uevent messages received is much faster than the speed uevent messages processed, so, we can merge these queued uevent message first, and then process it in the next step. Of course, some paths ’ uevent messages