[dm-devel] error propagation problem on xfs over dm stripe

2017-01-31 Thread Eric Sandeen
xfstest generic/108 creates a stripe then fails one leg to see if io errors on only a subset of an io get reported to userspace: # Test partial block device failure. Calls like fsync() should report failure # on partial I/O failure, e.g. a single failed disk in a raid 0 stripe. # # Test motivated

Re: [dm-devel] split scsi passthrough fields out of struct request V2

2017-01-31 Thread Jens Axboe
On 01/31/2017 01:55 PM, Bart Van Assche wrote: > On Tue, 2017-01-31 at 13:34 -0800, Bart Van Assche wrote: >> On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: >>> That's a known bug in mainline. Pull it into 4.10-rc6, >>> or use my for-next where everything is already merged. >> >> Hello Jens,

Re: [dm-devel] split scsi passthrough fields out of struct request V2

2017-01-31 Thread Bart Van Assche
On Tue, 2017-01-31 at 13:34 -0800, Bart Van Assche wrote: > On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: > > That's a known bug in mainline. Pull it into 4.10-rc6, > > or use my for-next where everything is already merged. > > Hello Jens, > > With your for-next branch (commit c2e60b3a260

Re: [dm-devel] split scsi passthrough fields out of struct request V2

2017-01-31 Thread Bart Van Assche
On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: > That's a known bug in mainline. Pull it into 4.10-rc6, > or use my for-next where everything is already merged. Hello Jens, With your for-next branch (commit c2e60b3a2602) I haven't hit any block layer crashes so far. The only issue I encoun

Re: [dm-devel] [PATCH v2] dm-crypt: replace RCU read-side section with rwsem

2017-01-31 Thread Mikulas Patocka
Reviewed-by: Mikulas Patocka On Tue, 31 Jan 2017, Ondrej Kozina wrote: > The lockdep splat bellow hints a bug in RCU usage in dm-crypt > since kernel keyring fn user_key_payload() is in fact a wrapper > for rcu_dereference_protected() which must not be called > with only rcu_read_lock() sectio

[dm-devel] [PATCH v2] dm-crypt: replace RCU read-side section with rwsem

2017-01-31 Thread Ondrej Kozina
The lockdep splat bellow hints a bug in RCU usage in dm-crypt since kernel keyring fn user_key_payload() is in fact a wrapper for rcu_dereference_protected() which must not be called with only rcu_read_lock() section mark. Unfortunately there's currently no correct function in kernel keyring subsy

Re: [dm-devel] [PATCH] dm-crypt: fix wrong use of RCU on key payload handling

2017-01-31 Thread Mikulas Patocka
Hi I think that touching the internals of the key structure and duplicating the function user_key_payload in dm-crypt is not quite right. Duplicating the code is bad and duplicating it in a different module is even worse - after long time it becomes problematic to find all the duplicates. I su

[dm-devel] [PATCH] dm-crypt: fix wrong use of RCU on key payload handling

2017-01-31 Thread Ondrej Kozina
This fixes following lockdep splat emerging on table load with a key in kernel keyring service. In fact it hints a bug in RCU usage in dm-crypt since kernel keyring fn user_key_payload() is in fact a wrapper for rcu_dereference_protected() which must not be used with only rcu_read_lock() mark. ==

Re: [dm-devel] [PATCH v3 1/1] DM: inplace compressed DM target

2017-01-31 Thread kbuild test robot
Hi Ram, [auto build test ERROR on dm/for-next] [also build test ERROR on v4.10-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ram-Pai/DM-inplace-compressed-DM-target/20170131-154811 base

Re: [dm-devel] [PATCH v3 1/1] DM: inplace compressed DM target

2017-01-31 Thread kbuild test robot
/20170131-154811 base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next config: cris-allyesconfig (attached as .config) compiler: cris-linux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross