Re: [dm-devel] [PATCH 03/23] sd: implement REQ_OP_WRITE_ZEROES

2017-03-29 Thread Martin K. Petersen
Bart Van Assche writes: Hi Bart, > A quote from SBC: "An OPTIMAL UNMAP GRANULARITY field set to a > non-zero value indicates the optimal granularity in logical blocks for > unmap requests (e.g., an UNMAP command or a WRITE SAME (16) command > with the UNMAP bit set

Re: [dm-devel] [multipath-tools] [BUG] segfault in uev_update_path

2017-03-29 Thread Martin Wilck
On Tue, 2017-03-28 at 11:42 -0500, Benjamin Marzinski wrote: > Now the question is, what to we do if the path changes wwid, but it's > not part of a multipath device yet. We could simply print a warning > message that the wwid has changed, and allow it to happen, since > there's > no multipath

Re: [dm-devel] [PATCH 03/23] sd: implement REQ_OP_WRITE_ZEROES

2017-03-29 Thread Paolo Bonzini
On 29/03/2017 18:28, Bart Van Assche wrote: > On Wed, 2017-03-29 at 16:51 +0200, Paolo Bonzini wrote: >> On 28/03/2017 20:50, Bart Van Assche wrote: >>> This means that just like the start and end of a discard must be aligned on >>> a >>> discard_granularity boundary, WRITE SAME commands with

Re: [dm-devel] [PATCH 03/23] sd: implement REQ_OP_WRITE_ZEROES

2017-03-29 Thread Bart Van Assche
On Wed, 2017-03-29 at 16:51 +0200, Paolo Bonzini wrote: > On 28/03/2017 20:50, Bart Van Assche wrote: > > This means that just like the start and end of a discard must be aligned on > > a > > discard_granularity boundary, WRITE SAME commands with the UNMAP bit set > > must > > also respect that

Re: [dm-devel] [PATCH 03/23] sd: implement REQ_OP_WRITE_ZEROES

2017-03-29 Thread Paolo Bonzini
On 28/03/2017 20:50, Bart Van Assche wrote: > > This means that just like the start and end of a discard must be aligned on a > discard_granularity boundary, WRITE SAME commands with the UNMAP bit set must > also respect that granularity. I think this means that either >

Re: [dm-devel] [PATCH 12/23] sd: handle REQ_UNMAP

2017-03-29 Thread Paolo Bonzini
On 28/03/2017 18:48, Bart Van Assche wrote: >> +if (rq->cmd_flags & REQ_UNMAP) { >> +switch (sdkp->provisioning_mode) { >> +case SD_LBP_WS16: >> +return sd_setup_write_same16_cmnd(cmd, true); >> +case SD_LBP_WS10: >> +

Re: [dm-devel] RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload

2017-03-29 Thread Paolo Bonzini
On 23/03/2017 23:53, Lars Ellenberg wrote: > Thin does not claim to zero data on discard. which is ok, and correct, > because it only punches holes on full chunks (or whatever you call > them), and leaves the rest in the mapping tree as is. > > And that behaviour would prevent DRBD from

Re: [dm-devel] [PATCH 23/23] block: remove the discard_zeroes_data flag

2017-03-29 Thread Paolo Bonzini
On 28/03/2017 19:00, Bart Van Assche wrote: > On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote: >> Now that we use the proper REQ_OP_WRITE_ZEROES operation everywhere we can >> kill this hack. >> >> [ ... ] >> >> diff --git a/Documentation/ABI/testing/sysfs-block >>

[dm-devel] [PATCH] dm: move dm_table_destroy() to same header as dm_table_create()

2017-03-29 Thread Brian Norris
If anyone is going to use dm_table_create(), they probably should be able to use dm_table_destroy() too. Move the dm_table_destroy() definition outside the private header, near dm_table_create() Signed-off-by: Brian Norris --- drivers/md/dm.h | 1 -