Re: [dm-devel] [PATCH v2 10/10] dm-zoned: Drive-managed zoned block device target

2017-05-02 Thread Bart Van Assche
On Tue, 2017-05-02 at 02:53 +0900, damien.lem...@wdc.com wrote: > +static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, > +  struct shrink_control *sc) > +{ > +   struct dmz_target *dmz = > +   container_of(shrink,

Re: [dm-devel] [mdadm PATCH 4/4] Create: tell udev device is not ready when first created.

2017-05-02 Thread NeilBrown
I'm sorry, but I didn't read all your words. You seemed to be telling me about extra complexity in udev, and extra complexity that you think belongs in mdadm, which together might achieve your vision for how things should work. But to me, complexity is the enemy. Give me "simple" any day.

[dm-devel] [PATCH] dm-bufio: make the parameter "retain_bytes" unsigned long

2017-05-02 Thread Mikulas Patocka
Change the type of the parameter "retain_bytes" from unsigned to unsigned long, so that on 64-bit machines the user can set more than 4GiB of data to be retained. Also, change the type of the variable "count" in the function "__evict_old_buffers" to unsigned long. The assignment "count =

[dm-devel] [git pull] device mapper post-merge changes for 4.12

2017-05-02 Thread Mike Snitzer
Hi Linus, Here are some changes from Christoph that needed to be rebased ontop of changes that were already merged into the 'tags/for-4.12/dm-changes'. In addition, these changes depend on the 'for-4.12/block' changes that you've already merged. So once you've pulled 'tags/for-4.12/dm-changes'

[dm-devel] [git pull] device mapper changes for 4.12

2017-05-02 Thread Mike Snitzer
Hi Linus, The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-4.12/dm-changes for you to fetch

[dm-devel] [PATCH 0/7] Fix fallout from changes to FUA and PREFLUSH definitions

2017-05-02 Thread Jan Kara
Hello, this series addresses a performance issue caused by commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous". We know for certain this problem significanly regresses (over 10%, in some cases up to 100%) ext4 and btrfs for dbench4 and reaim benchmarks. Based on this I

[dm-devel] [PATCH 7/7] md: Make flush bios explicitely sync

2017-05-02 Thread Jan Kara
Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous" removed REQ_SYNC flag from WRITE_{FUA|PREFLUSH|...} definitions. generic_make_request_checks() however strips REQ_FUA and REQ_PREFLUSH flags from a bio when the storage doesn't report volatile write cache and thus write

Re: [dm-devel] [mdadm PATCH 4/4] Create: tell udev device is not ready when first created.

2017-05-02 Thread Peter Rajnoha
On 05/01/2017 06:35 AM, NeilBrown wrote: > On Fri, Apr 28 2017, Peter Rajnoha wrote: > >> On 04/28/2017 05:55 AM, NeilBrown wrote: >>> On Wed, Apr 26 2017, Peter Rajnoha wrote: >>> On 04/20/2017 11:35 PM, NeilBrown wrote: > If we wanted an more permanent udev rule, we would need to

Re: [dm-devel] [PATCH 25/27] block: remove the discard_zeroes_data flag

2017-05-02 Thread Nicholas A. Bellinger
On Mon, 2017-05-01 at 23:43 -0700, Nicholas A. Bellinger wrote: > On Mon, 2017-05-01 at 20:45 +, Bart Van Assche wrote: > > On Wed, 2017-04-05 at 19:21 +0200, Christoph Hellwig wrote: > > > Now that we use the proper REQ_OP_WRITE_ZEROES operation everywhere we can > > > kill this hack. > > >

Re: [dm-devel] [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-05-02 Thread Logan Gunthorpe
On 28/04/17 11:51 AM, Herbert Xu wrote: > On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote: >> >> >> On 28/04/17 12:30 AM, Herbert Xu wrote: >>> You are right. Indeed the existing code looks buggy as they >>> don't take sg->offset into account when doing the kmap. Could >>> you

Re: [dm-devel] [PATCH 25/27] block: remove the discard_zeroes_data flag

2017-05-02 Thread Nicholas A. Bellinger
On Mon, 2017-05-01 at 20:45 +, Bart Van Assche wrote: > On Wed, 2017-04-05 at 19:21 +0200, Christoph Hellwig wrote: > > Now that we use the proper REQ_OP_WRITE_ZEROES operation everywhere we can > > kill this hack. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Martin

Re: [dm-devel] [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-05-02 Thread Logan Gunthorpe
On 28/04/17 12:30 AM, Herbert Xu wrote: > You are right. Indeed the existing code looks buggy as they > don't take sg->offset into account when doing the kmap. Could > you send me some patches that fix these problems first so that > they can be easily backported? Ok, I think the only buggy

Re: [dm-devel] [PATCH 25/27] block: remove the discard_zeroes_data flag

2017-05-02 Thread h...@lst.de
On Tue, May 02, 2017 at 12:16:13AM -0700, Nicholas A. Bellinger wrote: > Or, another options is use bdev_write_zeroes_sectors() to determine when > dev_attrib->unmap_zeroes_data should be set. Yes, that in combination with your patch to use bdev_write_zeroes_sectors for zeroing from write same