On Thu, 2017-06-22 at 14:21 -0500, Benjamin Marzinski wrote:
> On Thu, Jun 22, 2017 at 08:23:44AM +0200, Hannes Reinecke wrote:
> > On 06/21/2017 05:06 PM, Martin Wilck wrote:
> > > We set the queue_if_no_path feature in assemble_map() already,
> > > no need to set it here again.
> > >
> > > Signe
Hi Linus,
The following changes since commit 32c1431eea4881a6b17bd7c639315010aeefa452:
Linux 4.12-rc5 (2017-06-11 16:48:20 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
tags/for-4.12/dm-fixes-4
for you to fetch chan
On Thu, Jun 22, 2017 at 08:23:44AM +0200, Hannes Reinecke wrote:
> On 06/21/2017 05:06 PM, Martin Wilck wrote:
> > We set the queue_if_no_path feature in assemble_map() already,
> > no need to set it here again.
> >
> > Signed-off-by: Martin Wilck
> > ---
> > libmultipath/configure.c | 15 --
On Thu, Jun 22, 2017 at 04:59:12PM +0200, Martin Wilck wrote:
> Setting a device handler only works if retain_attached_hw_handler
> is 'no', or if the kernel didn't auto-assign a handler. If this
> is not the case, don't even attempt to set a different handler.
>
> This requires reading the sysfs
On Thu, Jun 22, 2017 at 04:59:11PM +0200, Martin Wilck wrote:
> Kernels 4.3 and newer (commit 1bab0de0 "dm-mpath, scsi_dh: don't
> let dm detach device handlers") imply "retain_attached_hw_handler yes".
>
> Clarify this in the propsel code, log messages, and documentation.
ACK
-Ben
>
> Signed-
Mainly running scripts/Lindent, from kernel dir, to replace indent spaces
by tabs.
Cc: Yang Feng
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/prioritizers/path_latency.c | 354 +++
1 file changed, 177 inser
We set the queue_if_no_path feature in assemble_map() already,
no need to set it here again.
Signed-off-by: Martin Wilck
---
libmultipath/configure.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/libmultipath/configure.c b/libmultipath/configure.c
index 03874f47..98589150 1
The logic applied here should match the logic in select_features().
This is achieved by calling reconcile_features_with_options().
Signed-off-by: Martin Wilck
Acked-by: Benjamin Marzinski
---
libmultipath/config.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git
Change the argument type for the feature to add or remove to
const char*, making it possible to pass const strings without
warnings.
Signed-off-by: Martin Wilck
Acked-by: Benjamin Marzinski
Reviewed-by: Hannes Reinecke
---
libmultipath/structs.c | 30 --
libmultipat
It is wrong to remove the queue_if_no_path feature if no_path_retry
is unset. Rather, in this case the feature should neither be added
nor removed.
Signed-off-by: Martin Wilck
Acked-by: Benjamin Marzinski
Reviewed-by: Hannes Reinecke
---
libmultipath/dmparser.c | 5 ++---
1 file changed, 2 ins
Clarify the documentation about option precedence.
Signed-off-by: Martin Wilck
Acked-by: Benjamin Marzinski
Reviewed-by: Hannes Reinecke
---
multipath/multipath.conf.5 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
The "features" option in multipath.conf can possibly conflict
with "no_path_retry" and "retain_attached_hw_handler".
Currently, "no_path_retry" takes precedence, unless it is set to
"fail", in which case it's overridden by "queue_if_no_path".
This is odd, either "features" or "no_path_retry" shoul
We have the logic for setting defaults for paths and maps
in propsel.c. By pre-setting conf values with defaults in
load_config(), we generate irritating log messages like
'features = "0" (setting: multipath.conf defaults/devices section)'
if multipath.conf doesn't contain a features setting at all
The device-mapper features "queue_if_no_path" and
"retain_attached_hw_handler" should be set via the configuration
keywords "no_path_retry" and "retain_attached_hw_handler",
respectively, not via "features".
Print a warning if these "features" settings are encountered.
So far these "features" sett
Remove the FIXME markers by filling in missing content,
and make some other minor fixes.
Signed-off-by: Martin Wilck
Acked-by: Benjamin Marzinski
Reviewed-by: Hannes Reinecke
---
multipath/multipath.conf.5 | 48 +-
1 file changed, 26 insertions(+), 2
Kernels 4.3 and newer (commit 1bab0de0 "dm-mpath, scsi_dh: don't
let dm detach device handlers") imply "retain_attached_hw_handler yes".
Clarify this in the propsel code, log messages, and documentation.
Signed-off-by: Martin Wilck
Reviewed-by: Hannes Reinecke
---
libmultipath/configure.c |
This patch set attempts to sanitize the logic used for consistently handling
options that can be set both via the "features" string and explicit
multipath.conf
options. This is most prominently "no_path_retry" vs. "queue_if_no_path", but
also
"retain_attached_hw_handler" vs. the feature of the sa
Setting a device handler only works if retain_attached_hw_handler
is 'no', or if the kernel didn't auto-assign a handler. If this
is not the case, don't even attempt to set a different handler.
This requires reading the sysfs "dh_state" path attribute.
Signed-off-by: Martin Wilck
---
libmultipa
On Thu, 2017-06-22 at 08:21 +0200, Hannes Reinecke wrote:
> On 06/21/2017 05:06 PM, Martin Wilck wrote:
> > Setting a device handler only works if retain_attached_hw_handler
> > is 'no', or if the kernel didn't auto-assign a handler. If this
> > is not the case, don't even attempt to set a differen
On Thu, 2017-06-22 at 08:23 +0200, Hannes Reinecke wrote:
> On 06/21/2017 05:06 PM, Martin Wilck wrote:
> > We set the queue_if_no_path feature in assemble_map() already,
> > no need to set it here again.
> >
> > Signed-off-by: Martin Wilck
> > ---
> > libmultipath/configure.c | 15 -
20 matches
Mail list logo
