Re: [dm-devel] [PATCH 2/2] dm log writes: add support for DAX

2017-10-24 Thread Ross Zwisler
On Mon, Oct 23, 2017 at 01:34:09PM -0400, Josef Bacik wrote: > On Thu, Oct 19, 2017 at 11:24:04PM -0600, Ross Zwisler wrote: > > Now that we have the ability log filesystem writes using a flat buffer, add > > support for DAX. Unfortunately we can't easily track data that has been > > written via m

Re: [dm-devel] md: Convert timers to use timer_setup()

2017-10-24 Thread Mike Snitzer
On Wed, Oct 18 2017 at 11:12pm -0400, Jens Axboe wrote: > > > On Oct 18, 2017, at 9:06 PM, Kees Cook wrote: > > > >> On Mon, Oct 16, 2017 at 8:06 PM, Michael Lyle wrote: > >>> On 10/16/2017 05:01 PM, Kees Cook wrote: > >>> In preparation for unconditionally passing the struct timer_list point

Re: [dm-devel] md: Convert timers to use timer_setup()

2017-10-24 Thread Jens Axboe
On 10/24/2017 12:15 PM, Mike Snitzer wrote: > On Wed, Oct 18 2017 at 11:12pm -0400, > Jens Axboe wrote: > >> >>> On Oct 18, 2017, at 9:06 PM, Kees Cook wrote: >>> On Mon, Oct 16, 2017 at 8:06 PM, Michael Lyle wrote: > On 10/16/2017 05:01 PM, Kees Cook wrote: > In preparation for un

Re: [dm-devel] [PATCH 1/2] dm log writes: Add support for inline data buffers

2017-10-24 Thread Mike Snitzer
On Fri, Oct 20 2017 at 1:24am -0400, Ross Zwisler wrote: > Currently dm-log-writes supports writing filesystem data via BIOs, and > writing internal metadata from a flat buffer via write_metadata(). > > For DAX writes, though, we won't have a BIO, but will instead have an > iterator that we'll

Re: [dm-devel] [PATCH 2/2] dm log writes: add support for DAX

2017-10-24 Thread Mike Snitzer
On Fri, Oct 20 2017 at 1:24am -0400, Ross Zwisler wrote: > Now that we have the ability log filesystem writes using a flat buffer, add > support for DAX. Unfortunately we can't easily track data that has been > written via mmap() now that the dax_flush() abstraction was removed by this > commit

[dm-devel] [dm:for-next 8/9] drivers//md/dm-log-writes.c:279:17: note: in expansion of macro 'min'

2017-10-24 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next head: ae613bbb0144e84cb3c0ebfa9f4fd4d1507c2f0e commit: 6a697d036324c7fbe63fb49599027269006161e7 [8/9] dm log writes: add support for inline data buffers config: i386-randconfig-x014-201743 (attached as

Re: [dm-devel] [dm:for-next 8/9] drivers//md/dm-log-writes.c:279:17: note: in expansion of macro 'min'

2017-10-24 Thread Mike Snitzer
On Tue, Oct 24 2017 at 5:50pm -0400, Ross Zwisler wrote: > So I think this just needs to be > > pg_datalen = min((int)datalen, > PAGE_SIZE); > > since the resulting pg_datalen is also an int. > > Mike can you fix up, or would you like an updated patch