Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Austin S. Hemmelgarn
On 2017-11-16 09:06, Qu Wenruo wrote: On 2017年11月16日 20:33, Zdenek Kabelac wrote: Dne 16.11.2017 v 11:04 Qu Wenruo napsal(a): On 2017年11月16日 17:43, Zdenek Kabelac wrote: Dne 16.11.2017 v 09:08 Qu Wenruo napsal(a): [What we have] The nearest infrastructure I found in kernel is bio_int

Re: [dm-devel] [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

2017-11-20 Thread Ross Zwisler
On Thu, Nov 16, 2017 at 02:28:15PM -0700, Ross Zwisler wrote: > On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > > Perhaps stat -c %b $SCRATCH_MNT/test ? > > Maybe, but doesn't the output of 'stat -c %b' depend on the block size the > filesystem is using? I think to use stat I'd ha

Re: [dm-devel] [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

2017-11-20 Thread Ross Zwisler
On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > On Wed, Oct 25, 2017 at 02:47:04PM -0600, Ross Zwisler wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an mmap(), but never syncs > > via fsync/msync. This process i

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Qu Wenruo
On 2017年11月17日 06:32, Chris Murphy wrote: > On Thu, Nov 16, 2017 at 3:04 AM, Qu Wenruo wrote: > >> For example, if we use the following device mapper layout: >> >> FS (can be any fs with metadata csum) >> | >> dm-integrity >> | >>

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Chris Murphy
On Thu, Nov 16, 2017 at 6:22 PM, Qu Wenruo wrote: > > > On 2017年11月17日 06:32, Chris Murphy wrote: > >> It's good the file system can stay alive, but data is the much >> bigger target in terms of percent space on the physical media, > > It's also true. > (Although working on btrfs sometimes makes m

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Austin S. Hemmelgarn
On 2017-11-16 20:30, Qu Wenruo wrote: On 2017年11月17日 00:47, Austin S. Hemmelgarn wrote: This is at least less complicated than dm-integrity. Just a new hook for READ bio. And it can start from easy part. Like starting from dm-raid1 and other fs support. It's less complicated for end users

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Chris Murphy
On Thu, Nov 16, 2017 at 6:54 PM, Chris Murphy wrote: > The user doesn't have to setup dm-verity to get this. Or dm-integrity, rather. -- Chris Murphy -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

2017-11-20 Thread Ross Zwisler
On Thu, Oct 26, 2017 at 07:59:39AM +0300, Amir Goldstein wrote: > On Wed, Oct 25, 2017 at 11:47 PM, Ross Zwisler > wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an mmap(), but never syncs > > via fsync/msync. This process is tr

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Qu Wenruo
On 2017年11月17日 00:47, Austin S. Hemmelgarn wrote: >> >> This is at least less complicated than dm-integrity. >> >> Just a new hook for READ bio. And it can start from easy part. >> Like starting from dm-raid1 and other fs support. > It's less complicated for end users (in theory, but cryptsetup

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Chris Murphy
On Thu, Nov 16, 2017 at 3:04 AM, Qu Wenruo wrote: > For example, if we use the following device mapper layout: > > FS (can be any fs with metadata csum) > | > dm-integrity > | > dm-raid1 >/ \ > disk1 di

Re: [dm-devel] [PATCH 3/4] libmultipath: path latency: simplify getprio()

2017-11-20 Thread Martin Wilck
Hello Guan, > On 2017/11/18 8:11, Martin Wilck wrote: > > The log standard deviation can be calculated much more simply > > by realizing > > > >sum_n (x_i - avg(x))^2 == sum_n x_i^2 - n * avg(x)^2 > > > > I derive the equation: > sum_n {(x_i - avg(x))^2} = sum_n{x_i^2 -2*x_i*avg(x) + avg(x

Re: [dm-devel] [PATCH 0/4] path latency prio fixes

2017-11-20 Thread Martin Wilck
Hi Guan, while staring at this code the other day, I realized another possible issue with your latency prioritizer. It will cause significant IO to every path of a map during multipath / multipathd startup. If any paths really have latencies as long as your patch considers (up to 100s), or worse

Re: [dm-devel] [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.

2017-11-20 Thread Mike Snitzer
On Sun, Jun 18, 2017 at 5:36 PM, NeilBrown wrote: > On Sun, Jun 18 2017, Jens Axboe wrote: > >> On Sun, Jun 18 2017, NeilBrown wrote: >>> This is a resend of my series of patches working >>> towards removing the bioset work queues. >>> >>> This set is based on for-4.13/block. >>> >>> It incorporat

[dm-devel] [PATCH] block: early return from blk_queue_split() if q->bio_split is NULL

2017-11-20 Thread Mike Snitzer
DM appears to be the only block driver that doesn't lean on the block core's bio splitting. My hope is to fix that but in the meantime it doesn't make sense for a device that doesn't need blk_queue_split() to go through the associated work. Signed-off-by: Mike Snitzer --- block/blk-merge.c | 3

[dm-devel] [PATCH] libmultipath: fix return code of sysfs_get_timeout

2017-11-20 Thread Martin Wilck
This function should return 1 on success, as the other sysfs_get_XXX functions. The callers actually expect this - therefore timeout values from sysfs are never used. Signed-off-by: Martin Wilck --- libmultipath/discovery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libm

[dm-devel] [PATCH] multipath-tools: add README.alua with instructions to enable ALUA

2017-11-20 Thread Xose Vazquez Perez
ALUA is supported in some storage devices, but usually it's disabled by default. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- README.alua | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 README.alua diff --git a/README.alu

Re: [dm-devel] [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Mike Snitzer
On Sun, Nov 19, 2017 at 9:00 PM, Joseph Qi wrote: > From: Joseph Qi > > dm device set QUEUE_FLAG_NONROT in resume, which is after register > queue. That is to mean, the previous initialization in > blk_throtl_register_queue is wrong in this case. > Fix it by checking and then updating the info du

Re: [dm-devel] [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Shaohua Li
On Mon, Nov 20, 2017 at 04:02:03PM -0500, Mike Snitzer wrote: > On Sun, Nov 19, 2017 at 9:00 PM, Joseph Qi wrote: > > From: Joseph Qi > > > > dm device set QUEUE_FLAG_NONROT in resume, which is after register > > queue. That is to mean, the previous initialization in > > blk_throtl_register_queue

Re: [dm-devel] [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.

2017-11-20 Thread NeilBrown
On Mon, Nov 20 2017, Mike Snitzer wrote: > On Sun, Jun 18, 2017 at 5:36 PM, NeilBrown wrote: >> On Sun, Jun 18 2017, Jens Axboe wrote: >> >>> On Sun, Jun 18 2017, NeilBrown wrote: This is a resend of my series of patches working towards removing the bioset work queues. This se

Re: [dm-devel] [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Mike Snitzer
On Mon, Nov 20 2017 at 4:23pm -0500, Shaohua Li wrote: > On Mon, Nov 20, 2017 at 04:02:03PM -0500, Mike Snitzer wrote: > > On Sun, Nov 19, 2017 at 9:00 PM, Joseph Qi wrote: > > > From: Joseph Qi > > > > > > dm device set QUEUE_FLAG_NONROT in resume, which is after register > > > queue. That is

Re: [dm-devel] [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.

2017-11-20 Thread Mike Snitzer
On Mon, Nov 20 2017 at 7:34pm -0500, NeilBrown wrote: > On Mon, Nov 20 2017, Mike Snitzer wrote: > > > On Sun, Jun 18, 2017 at 5:36 PM, NeilBrown wrote: > >> On Sun, Jun 18 2017, Jens Axboe wrote: > >> > >>> On Sun, Jun 18 2017, NeilBrown wrote: > This is a resend of my series of patches

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Theodore Ts'o
On Thu, Nov 16, 2017 at 03:32:05PM -0700, Chris Murphy wrote: > > XFS by default does metadata csums. But ext4 doesn't use it for either > metadata or the journal by default still, it is still optional. So for > now it mainly benefits XFS. Metadata checksums are enabled by default in the version