Re: [dm-devel] [PATCH v2 RESEND] x86: optimize memcpy_flushcache

2018-06-21 Thread Ingo Molnar
* Mikulas Patocka wrote: > On Thu, 21 Jun 2018, Ingo Molnar wrote: > > > > > * Mike Snitzer wrote: > > > > > From: Mikulas Patocka > > > Subject: [PATCH v2] x86: optimize memcpy_flushcache > > > > > > In the context of constant short length stores to persistent memory, > > >

Re: [dm-devel] [PATCH v2 RESEND] x86: optimize memcpy_flushcache

2018-06-21 Thread Mikulas Patocka
On Thu, 21 Jun 2018, Ingo Molnar wrote: > > * Mike Snitzer wrote: > > > From: Mikulas Patocka > > Subject: [PATCH v2] x86: optimize memcpy_flushcache > > > > In the context of constant short length stores to persistent memory, > > memcpy_flushcache suffers from a 2% performance

Re: [dm-devel] dm bufio: Reduce dm_bufio_lock contention

2018-06-21 Thread Mikulas Patocka
On Tue, 19 Jun 2018, Michal Hocko wrote: > On Mon 18-06-18 18:11:26, Mikulas Patocka wrote: > [...] > > I grepped the kernel for __GFP_NORETRY and triaged them. I found 16 cases > > without a fallback - those are bugs that make various functions randomly > > return -ENOMEM. > > Well, maybe

[dm-devel] [PATCH] dm cache: require io_mode cache feature selection to be mutually exclusive

2018-06-21 Thread John Pittman
Due to commit 629d0a8a1a10 ("dm cache metadata: add "metadata2" feature"), when creating a dm cache device, more than one io_mode can be selected. As the io_mode selections are incompatible with one another, we should force them to be selected exclusively. Add simple ctr to check for more than

Re: [dm-devel] [PATCH 04/11] dm verity fec: Remove VLA usage

2018-06-21 Thread Kees Cook
On Wed, Jun 20, 2018 at 7:30 PM, Herbert Xu wrote: > On Wed, Jun 20, 2018 at 12:04:01PM -0700, Kees Cook wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> uses the newly defined max digest size macro. Also adds a sanity-check >> at use-time. >> >> [1] >>

Re: [dm-devel] [PATCH v2 RESEND] x86: optimize memcpy_flushcache

2018-06-21 Thread Ingo Molnar
* Mike Snitzer wrote: > From: Mikulas Patocka > Subject: [PATCH v2] x86: optimize memcpy_flushcache > > In the context of constant short length stores to persistent memory, > memcpy_flushcache suffers from a 2% performance degradation compared to > explicitly using the "movnti" instruction.

Re: [dm-devel] [PATCH 4.17.0-rc3 1/2] dm: Reduce line length

2018-06-21 Thread Mike Snitzer
On Thu, Jun 21 2018 at 8:02am -0400, Ssemagoye Umar Munddu wrote: > Signed-off-by: Ssemagoye Umar Munddu > --- > drivers/md/dm.c | 187 > +--- > 1 file changed, 123 insertions(+), 64 deletions(-) There is absolutely no way I'm taking this.

Re: [dm-devel] [PATCH] multipath-tools: fix help for hds prio

2018-06-21 Thread Christophe Varoqui
Done, thanks. On Thu, Jun 21, 2018 at 10:59 AM Xose Vazquez Perez wrote: > Hi Christophe, > > This one is missing. > > Thank you. > > On 05/21/2018 10:03 PM, Xose Vazquez Perez wrote: > > Cc: Christophe Varoqui > > Cc: DM-DEV ML > > Signed-off-by: Xose Vazquez Perez > > --- > >

Re: [dm-devel] [PATCH] multipath-tools: fix help for hds prio

2018-06-21 Thread Xose Vazquez Perez
Hi Christophe, This one is missing. Thank you. On 05/21/2018 10:03 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: DM-DEV ML > Signed-off-by: Xose Vazquez Perez > --- > multipath/multipath.conf.5 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [dm-devel] [PATCH v3 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()

2018-06-21 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 2:10 AM, Andrew Morton wrote: > On Mon, 18 Jun 2018 15:01:43 -0700 Dmitry Torokhov > wrote: >> We can't as we end up including bitmap.h (by the way of cpumask.h) >> form slab.h, so we gen circular dependency. > It's not just so easy. See below. > That info should have

Re: [dm-devel] [PATCH 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK

2018-06-21 Thread Christophe Leroy
On 06/20/2018 07:04 PM, Kees Cook wrote: In the quest to remove all stack VLA usage from the kernel[1], this caps the skcipher request size similar to other limits and adds a sanity check at registration. [1]

Re: [dm-devel] [PATCH 03/11] crypto: ahash: Remove VLA usage

2018-06-21 Thread Christophe Leroy
On 06/20/2018 07:04 PM, Kees Cook wrote: In the quest to remove all stack VLA usage from the kernel[1], this introduces max size macros for ahash, as already done for shash, and adjust the crypto user to max state size. [1]

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-21 Thread Dmitry Torokhov
On Wed, Jun 20, 2018 at 11:13:21AM +0300, Yury Norov wrote: > On Tue, Jun 19, 2018 at 11:33:16AM -0700, Dmitry Torokhov wrote: > > External Email > > > > On Sat, Jun 16, 2018 at 12:42:31AM +0300, Yury Norov wrote: > > > Hi Andy, > > > > > > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy

Re: [dm-devel] [PATCH 01/11] crypto: shash: Remove VLA usage

2018-06-21 Thread Christophe LEROY
Le 20/06/2018 à 22:36, Kees Cook a écrit : On Wed, Jun 20, 2018 at 12:30 PM, Christophe Leroy wrote: On 06/20/2018 07:03 PM, Kees Cook wrote: In the quest to remove all stack VLA usage from the kernel[1], this removes the VLAs in SHASH_DESC_ON_STACK (via crypto_shash_descsize()) by using

Re: [dm-devel] [PATCH 06/11] crypto: cbc: Remove VLA usage

2018-06-21 Thread Christophe Leroy
On 06/20/2018 07:04 PM, Kees Cook wrote: In the quest to remove all stack VLA usage from the kernel[1], this uses the upper bounds on blocksize. [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com Signed-off-by: Kees Cook crypto/cbc.c: In

Re: [dm-devel] [PATCH 01/11] crypto: shash: Remove VLA usage

2018-06-21 Thread Christophe Leroy
On 06/20/2018 07:03 PM, Kees Cook wrote: In the quest to remove all stack VLA usage from the kernel[1], this removes the VLAs in SHASH_DESC_ON_STACK (via crypto_shash_descsize()) by using the maximum allowable size (which is now more clearly captured in a macro). Similar limits are turned into