Re: [dm-devel] [PATCH v5 0/3] Fix DM DAX handling

2018-06-26 Thread Dan Williams
On Tue, Jun 26, 2018 at 3:30 PM, Ross Zwisler wrote: > This series fixes a few issues that I found with DM's handling of DAX > devices. Here are some of the issues I found: > > * We can create a dm-stripe or dm-linear device which is made up of an >fsdax PMEM namespace and a raw PMEM

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Dan Williams
On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi wrote: > On Tue, 2018-06-26 at 14:28 -0700, Dan Williams wrote: >> On Tue, Jun 26, 2018 at 2:23 PM, Kani, Toshi wrote: >> > On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote: >> > > On Tue, Jun 26, 2018 at 1:54 PM, Kani, Toshi wrote: >> >> [..]

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Kani, Toshi
On Tue, 2018-06-26 at 14:28 -0700, Dan Williams wrote: > On Tue, Jun 26, 2018 at 2:23 PM, Kani, Toshi wrote: > > On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote: > > > On Tue, Jun 26, 2018 at 1:54 PM, Kani, Toshi wrote: > > [..] > > > > When this dm change was made, the pmem driver

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Dan Williams
On Tue, Jun 26, 2018 at 2:23 PM, Kani, Toshi wrote: > On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote: >> On Tue, Jun 26, 2018 at 1:54 PM, Kani, Toshi wrote: [..] >> > When this dm change was made, the pmem driver supported DAX for both raw >> > and memory modes (note: sector mode does not

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Kani, Toshi
On Tue, 2018-06-26 at 14:02 -0700, Dan Williams wrote: > On Tue, Jun 26, 2018 at 1:54 PM, Kani, Toshi wrote: > > On Tue, 2018-06-26 at 15:13 -0400, Mike Snitzer wrote: > > > On Tue, Jun 26 2018 at 3:07pm -0400, > > > Dan Williams wrote: > > > > > > > On Tue, Jun 26, 2018 at 11:58 AM, Mike

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Dan Williams
On Tue, Jun 26, 2018 at 1:54 PM, Kani, Toshi wrote: > On Tue, 2018-06-26 at 15:13 -0400, Mike Snitzer wrote: >> On Tue, Jun 26 2018 at 3:07pm -0400, >> Dan Williams wrote: >> >> > On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote: >> > > On Tue, Jun 26 2018 at 2:52pm -0400, >> > > Dan

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Kani, Toshi
On Tue, 2018-06-26 at 15:13 -0400, Mike Snitzer wrote: > On Tue, Jun 26 2018 at 3:07pm -0400, > Dan Williams wrote: > > > On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote: > > > On Tue, Jun 26 2018 at 2:52pm -0400, > > > Dan Williams wrote: > > > > > > > On Tue, Jun 26, 2018 at 10:59

Re: [dm-devel] dm-thin metadata operation failed due to -ENOSPC returned by dm_pool_alloc_data_block() after processing DISCARD bios

2018-06-26 Thread Mike Snitzer
On Tue, Jun 26 2018 at 4:01pm -0400, Mike Snitzer wrote: > On Tue, Apr 03 2018 at 12:07am -0400, > Dennis Yang wrote: > > > Hi, > > > > Recently we have came across an issue that dm-thin pool will be > > switched to READ_ONLY mode because dm_pool_alloc_data_block() returns > > -ENOSPC.

Re: [dm-devel] dm-thin metadata operation failed due to -ENOSPC returned by dm_pool_alloc_data_block() after processing DISCARD bios

2018-06-26 Thread Mike Snitzer
On Tue, Apr 03 2018 at 12:07am -0400, Dennis Yang wrote: > Hi, > > Recently we have came across an issue that dm-thin pool will be > switched to READ_ONLY mode because dm_pool_alloc_data_block() returns > -ENOSPC. AFAIK, this should not happen since alloc_data_block() will > check if there is

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Dan Williams
On Tue, Jun 26, 2018 at 12:13 PM, Mike Snitzer wrote: > On Tue, Jun 26 2018 at 3:07pm -0400, > Dan Williams wrote: > >> On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote: >> > On Tue, Jun 26 2018 at 2:52pm -0400, >> > Dan Williams wrote: >> > >> >> On Tue, Jun 26, 2018 at 10:59 AM, Ross

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Mike Snitzer
On Tue, Jun 26 2018 at 3:07pm -0400, Dan Williams wrote: > On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote: > > On Tue, Jun 26 2018 at 2:52pm -0400, > > Dan Williams wrote: > > > >> On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler > >> wrote: > >> > QUEUE_FLAG_DAX is an indication that a

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Dan Williams
On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer wrote: > On Tue, Jun 26 2018 at 2:52pm -0400, > Dan Williams wrote: > >> On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler >> wrote: >> > QUEUE_FLAG_DAX is an indication that a given block device supports >> > filesystem DAX and should not be set for

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Mike Snitzer
On Tue, Jun 26 2018 at 2:52pm -0400, Dan Williams wrote: > On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler > wrote: > > QUEUE_FLAG_DAX is an indication that a given block device supports > > filesystem DAX and should not be set for PMEM namespaces which are in "raw" > > or "sector" modes.

Re: [dm-devel] [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode

2018-06-26 Thread Dan Williams
On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler wrote: > QUEUE_FLAG_DAX is an indication that a given block device supports > filesystem DAX and should not be set for PMEM namespaces which are in "raw" > or "sector" modes. These namespaces lack struct page and are prevented > from participating

Re: [dm-devel] [PATCH v3 0/3] Fix DM DAX handling

2018-06-26 Thread Mike Snitzer
On Tue, Jun 26 2018 at 1:59pm -0400, Ross Zwisler wrote: > This series fixes a few issues that I found with DM's handling of DAX > devices. Here are some of the issues I found: > > * We can create a dm-stripe or dm-linear device which is made up of an >fsdax PMEM namespace and a raw PMEM

Re: [dm-devel] [PATCH v3 3/3] dm: prevent DAX mounts if not supported

2018-06-26 Thread Mike Snitzer
On Tue, Jun 26 2018 at 1:59pm -0400, Ross Zwisler wrote: > Currently device_supports_dax() just checks to see if the QUEUE_FLAG_DAX > flag is set on the device's request queue to decide whether or not the > device supports filesystem DAX. Really we should be using > bdev_dax_supported() like

Re: [dm-devel] [PATCH v2 10/11] crypto: ahash: Remove VLA usage for AHASH_REQUEST_ON_STACK

2018-06-26 Thread Kees Cook
On Tue, Jun 26, 2018 at 2:19 AM, Herbert Xu wrote: > On Mon, Jun 25, 2018 at 03:56:09PM -0700, Eric Biggers wrote: >> >> > diff --git a/include/crypto/internal/hash.h >> > b/include/crypto/internal/hash.h >> > index a0b0ad9d585e..d96ae5f52125 100644 >> > --- a/include/crypto/internal/hash.h >> >

Re: [dm-devel] [PATCH v2 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK

2018-06-26 Thread Kees Cook
On Tue, Jun 26, 2018 at 2:20 AM, Herbert Xu wrote: > On Mon, Jun 25, 2018 at 02:10:26PM -0700, Kees Cook wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> caps the skcipher request size similar to other limits and adds a >> sanity check at registration. In a manual

[dm-devel] [PATCH] multipath-tools: update Hitachi maintainer email

2018-06-26 Thread Xose Vazquez Perez
Cc: Matthias Rudolph Cc: Matthias Rudolph Cc: Christophe Varoqui Cc: DM-DEV ML Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 287d501..07dd6b6 100644

Re: [dm-devel] [PATCH v3 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()

2018-06-26 Thread Andy Shevchenko
On Fri, 2018-06-22 at 11:46 -0700, Dmitry Torokhov wrote: > On Thu, Jun 21, 2018 at 05:13:39AM +0300, Andy Shevchenko wrote: > > On Tue, Jun 19, 2018 at 2:10 AM, Andrew Morton > > wrote: > > > On Mon, 18 Jun 2018 15:01:43 -0700 Dmitry Torokhov > > v...@gmail.com> wrote: > > > > We can't as we

Re: [dm-devel] [PATCH v2 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK

2018-06-26 Thread Herbert Xu
On Mon, Jun 25, 2018 at 02:10:26PM -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > caps the skcipher request size similar to other limits and adds a > sanity check at registration. In a manual review of the callers of > crypto_skcipher_set_reqsize(),

Re: [dm-devel] [PATCH v2 10/11] crypto: ahash: Remove VLA usage for AHASH_REQUEST_ON_STACK

2018-06-26 Thread Herbert Xu
On Mon, Jun 25, 2018 at 03:56:09PM -0700, Eric Biggers wrote: > > > diff --git a/include/crypto/internal/hash.h b/include/crypto/internal/hash.h > > index a0b0ad9d585e..d96ae5f52125 100644 > > --- a/include/crypto/internal/hash.h > > +++ b/include/crypto/internal/hash.h > > @@ -142,6 +142,7 @@

Re: [dm-devel] [PATCH v2 4/7] dm: prevent DAX mounts if not supported

2018-06-26 Thread Ross Zwisler
On Wed, Jun 20, 2018 at 11:17:49AM -0400, Mike Snitzer wrote: > On Mon, Jun 04 2018 at 7:15pm -0400, > Ross Zwisler wrote: > > > On Fri, Jun 01, 2018 at 05:55:13PM -0400, Mike Snitzer wrote: > > > On Tue, May 29 2018 at 3:51pm -0400, > > > Ross Zwisler wrote: > > > > > > > Currently the code