Re: [dm-devel] [PATCH 0/5] crypto: add IV generation templates

2018-07-19 Thread Ard Biesheuvel
On 20 July 2018 at 00:50, Mark Brown wrote: > On Thu, Jul 19, 2018 at 11:08:52PM +0900, Ard Biesheuvel wrote: > >> But this will only be the case if the accelerator is capable of doing >> the IV generation and en/decryption of multiple contiguous sectors in >> a single call. Otherwise, you are jus

Re: [dm-devel] [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-19 Thread Kees Cook
On Thu, Jul 19, 2018 at 7:54 AM, Ard Biesheuvel wrote: > On 19 July 2018 at 12:13, Ard Biesheuvel wrote: >> >>> On 19 Jul 2018, at 12:09, Kees Cook wrote: >>> >>> On Wed, Jul 18, 2018 at 7:55 PM, Ard Biesheuvel >>> wrote: I have only build tested it, so if you make sure that it does not br

Re: [dm-devel] [PATCH 4/5] crypto: Add IV generation templates

2018-07-19 Thread kbuild test robot
Hi Xiongfeng, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on v4.18-rc5 next-20180719] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [dm-devel] [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-19 Thread Ard Biesheuvel
On 19 July 2018 at 12:13, Ard Biesheuvel wrote: > >> On 19 Jul 2018, at 12:09, Kees Cook wrote: >> >> On Wed, Jul 18, 2018 at 7:55 PM, Ard Biesheuvel >> wrote: >>> I have only build tested it, so if you make sure that it does not break >>> anything, please go ahead. >> >> I can give it a spin;

Re: [dm-devel] [PATCH 0/5] crypto: add IV generation templates

2018-07-19 Thread Ard Biesheuvel
On 19 July 2018 at 19:55, Xiongfeng Wang wrote: > Hi, > > On 2018/7/18 23:34, Ard Biesheuvel wrote: >> On 18 July 2018 at 19:59, Arnd Bergmann wrote: >>> On Wed, Jul 18, 2018 at 9:30 AM, Xiongfeng Wang >>> wrote: I tested the performance of software implemented ciphers before and after

Re: [dm-devel] [PATCH 4/5] crypto: Add IV generation templates

2018-07-19 Thread Mark Brown
On Wed, Jul 18, 2018 at 07:17:45PM +0200, Milan Broz wrote: > I think the last iteration was this patch > https://lore.kernel.org/lkml/1498106510-19793-2-git-send-email-binoy.ja...@linaro.org/ Thanks! I'd got v5 but v6 went AWOL for some reason :( > 2) If the reason is performance, please provi

Re: [dm-devel] [PATCH 4/5] crypto: Add IV generation templates

2018-07-19 Thread Xiongfeng Wang
Hi, On 2018/7/19 1:17, Milan Broz wrote: > On 18/07/18 18:46, Mark Brown wrote: >> On Wed, Jul 18, 2018 at 10:16:05AM +0200, Milan Broz wrote: >> >>> So we are here again and moving INTERNAL dm-crypt functionality into >>> cryptoapi. > (namely TCW and LMK) do much more that IV - they modify encry

Re: [dm-devel] [PATCH 4/5] crypto: Add IV generation templates

2018-07-19 Thread Mark Brown
On Wed, Jul 18, 2018 at 10:16:05AM +0200, Milan Broz wrote: > So we are here again and moving INTERNAL dm-crypt functionality into > cryptoapi. > The TCW,LMK IVs generator make sense only for dm-crypt > for compatible old disk encryption mappings. > I strongly disagree to move this outside of

Re: [dm-devel] [PATCH 4/5] crypto: Add IV generation templates

2018-07-19 Thread Herbert Xu
On Thu, Jul 19, 2018 at 10:50:12AM +0200, Arnd Bergmann wrote: > > There seems to be some support for at least essiv(aes) in > drivers/crypto/ccree/cc_cipher.c, is that compatible with your essiv(*) > template, or is that something else? Whatever it is it should be removed. We should not be addin

Re: [dm-devel] [PATCH 4/5] crypto: Add IV generation templates

2018-07-19 Thread Arnd Bergmann
On Thu, Jul 19, 2018 at 3:46 AM, Xiongfeng Wang wrote: > Hi, > > On 2018/7/19 1:17, Milan Broz wrote: >> On 18/07/18 18:46, Mark Brown wrote: >>> On Wed, Jul 18, 2018 at 10:16:05AM +0200, Milan Broz wrote: >>> So we are here again and moving INTERNAL dm-crypt functionality into cryptoapi