Re: [dm-devel] [PATCH v3 02/19] libmultipath: fix tur checker double locking

2018-10-04 Thread Benjamin Marzinski
On Mon, Oct 01, 2018 at 10:44:06PM +0200, Martin Wilck wrote: > On Mon, 2018-10-01 at 22:09 +0200, Martin Wilck wrote: > > > > I like the lock removal a lot, but not so much the conversion into a > > string. Why not keep the dev_t? > > > > Or maybe even easier, the other way around: why don't we

Re: [dm-devel] [PATCH v3 02/19] libmultipath: fix tur checker double locking

2018-10-04 Thread Benjamin Marzinski
On Mon, Oct 01, 2018 at 10:09:41PM +0200, Martin Wilck wrote: > On Fri, 2018-09-21 at 18:05 -0500, Benjamin Marzinski wrote: > > tur_devt() locks ct->lock. However, it is ocassionally called while > > ct->lock is already locked. In reality, there is no reason why we > > need > > to lock all the acc

Re: [dm-devel] [PATCH v3 01/19] libmultipath: fix tur checker timeout

2018-10-04 Thread Benjamin Marzinski
On Mon, Oct 01, 2018 at 09:51:22PM +0200, Martin Wilck wrote: > On Fri, 2018-09-21 at 18:05 -0500, Benjamin Marzinski wrote: > > The code previously was timing out mode if ct->thread was 0 but > > ct->running wasn't. This combination never happens. The idea was to > > timeout if for some reason th

Re: [dm-devel] extracting thin mappings in real time

2018-10-04 Thread Joe Thornber
On Wed, Oct 03, 2018 at 04:47:41PM +0100, Thanos Makatos wrote: > poo metadata object can return this information? I've started looking > at thin_bio_map(), is this the best place to start? See thin-metadata.h - Joe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/li

Re: [dm-devel] libblkid filesystem block size

2018-10-04 Thread Karel Zak
Ahoj, On Wed, Oct 03, 2018 at 05:41:59PM -0400, Mikulas Patocka wrote: > As you maintain libblkid, I'd like to ask - would it be possible to add > detection of filesystem block size to it? libblkid already has description > of various filesystem superblocks, so it shouldn't be too hard. we h

[dm-devel] extracting thin mappings in real time

2018-10-04 Thread Thanos Makatos
I have a kernel module that sits on top of a thin device mapper target that receives block I/O requests and re-submits then to the thin target. I would like to implement the following functionality: whenever I receive a write completion from the thin target (assuming that it's the first time a bloc

[dm-devel] [PATCH] dm ioctl: fix a missing-check bug

2018-10-04 Thread Wenwen Wang
In copy_params(), the struct 'dm_ioctl' is firstly copied from the user space buffer 'user' to 'param_kernel' and the field 'data_size' is checked against 'minimum_data_size'. If the check fails, an error code EINVAL will be returned. Otherwise, the 'data_size' is used to do the second copy, which