Re: [dm-devel] dm writecache: remove unused variable sz in writecache_status

2018-10-24 Thread Mike Snitzer
On Wed, Oct 24 2018 at 10:38pm -0400, Shenghui Wang wrote: > sz defined but not used in writecache_status. Remove it. > > Signed-off-by: Shenghui Wang > --- > drivers/md/dm-writecache.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecac

Re: [dm-devel] [RFC] dm-bow working prototype

2018-10-24 Thread Alasdair G Kergon
On Wed, Oct 24, 2018 at 03:24:29PM -0400, Mikulas Patocka wrote: > What about allocating a big file, using the FIEMAP ioctl to find the For reference, dmfilemapd in the lvm2 tree (in daemons/) uses FIEMAP (in libdm/libdm-stats.c) for monitoring I/O by file. > If you decide that rollback is no lo

Re: [dm-devel] [RFC] dm-bow working prototype

2018-10-24 Thread Mikulas Patocka
On Wed, 24 Oct 2018, Paul Lawrence wrote: > Android has had the concept of A/B updates for since Android N, which means > that if an update is unable to boot for any reason three times, we revert to > the older system. However, if the failure occurs after the new system has > started modifying

Re: [dm-devel] Multipathd failed when I remove faulted disk. "segfault at 648 error 4 in libmultipath.so.0"

2018-10-24 Thread Martin Wilck
On Tue, 2018-10-23 at 14:46 +0300, Özkan Göksu wrote: > > > Versions: > device-mapper 2.02.177-5 > multipath-tools 0.7.6-1 > kernel: 4.14.30-1-lts Thanks for the core. I haven't been able to locate the multipath-tools 0.7.6-1 package (searched https://git.launchpad.net/ubuntu/+source/multipa

Re: [dm-devel] [RFC] dm-bow working prototype

2018-10-24 Thread Paul Lawrence
Android has had the concept of A/B updates for since Android N, which means that if an update is unable to boot for any reason three times, we revert to the older system. However, if the failure occurs after the new system has started modifying userdata, we will be attempting to start an older

Re: [dm-devel] [PATCH v4 00/11] Zoned block device support improvements

2018-10-24 Thread Martin K. Petersen
Mike, >> You keep mentioning this, but I don't recall ever seeing anything to >> that effect. The rest of the kernel appears to be either arbitrary >> ordering or favoring author SoB as the first tag. > > I've always felt the proper order is how Jens likes it too (all dm > commits from me follow

Re: [dm-devel] [PATCH v4 00/11] Zoned block device support improvements

2018-10-24 Thread Bart Van Assche
On Wed, 2018-10-24 at 11:37 -0400, Martin K. Petersen wrote: > Mike, > > > > You keep mentioning this, but I don't recall ever seeing anything to > > > that effect. The rest of the kernel appears to be either arbitrary > > > ordering or favoring author SoB as the first tag. > > > > I've always fe

Re: [dm-devel] [PATCH v4 00/11] Zoned block device support improvements

2018-10-24 Thread Mike Snitzer
On Tue, Oct 23 2018 at 10:26pm -0400, Martin K. Petersen wrote: > > Jens, > > > 2) The ordering of the signed-off-by. Someone told me that this is > >patchwork, but I absolutely hate it. SOB should go last, not before > >the reviewed-by. I fixed that up too. > > You keep mentioning thi

Re: [dm-devel] [PATCH] dm writecache: fix typo in error msg for creating writecache_flush_thread

2018-10-24 Thread Mikulas Patocka
On Wed, 24 Oct 2018, Shenghui Wang wrote: > The error msg should be "flush thread" instead of "endio thread" > for writecache_flush_thread. > > Signed-off-by: Shenghui Wang OK. Acked-by: Mikulas Patocka > --- > drivers/md/dm-writecache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [dm-devel] [PATCH] dm writecache: flush metadata in single commit in init_memory

2018-10-24 Thread Mikulas Patocka
On Wed, 24 Oct 2018, Shenghui Wang wrote: > Do not flush sb ->magic in second commit. This is intentional. The magic is written last, so that if the machine crashes while formatting the device, the incomplete superblock won't be misidentified as already formatted. Mikulas > Signed-off-by:

Re: [dm-devel] [PATCH] multipath-tools: delete trailing whitespaces

2018-10-24 Thread Martin Wilck
On Wed, 2018-10-10 at 21:51 +0200, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: DM-DEV ML > Signed-off-by: Xose Vazquez Perez > --- > libmultipath/checkers/tur.c | 2 +- > tests/dmevents.c| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Nack. This just pollute

Re: [dm-devel] [PATCH] multipatd: display the host WWNN fields.

2018-10-24 Thread Martin Wilck
On Thu, 2018-10-18 at 09:28 +0800, s90006763 wrote: > When the iSCSI path information is displayed using the multipath > command, the host WWNN in the path information is not fully > displayed, as follows: > Multipathd show paths format "%N%R" > Host WWNN host WWPN > [undef] iqn.xxx-xx.com.xx:ocean

Re: [dm-devel] [PATCH] multipath-tools: refresh kernel-doc from kernel sources

2018-10-24 Thread Martin Wilck
On Sat, 2018-08-18 at 22:38 +0200, Xose Vazquez Perez wrote: > Cc: Gris Ge > Cc: Christophe Varoqui > Cc: DM-DEV ML > Signed-off-by: Xose Vazquez Perez > --- > libdmmp/docs/kernel-doc | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Martin Wilck ..

Re: [dm-devel] Multipathd failed when I remove faulted disk. "segfault at 648 error 4 in libmultipath.so.0"

2018-10-24 Thread Özkan Göksu
Hello Martin. You can download the core dump here: https://drive.google.com/file/d/10egy9RXch6-s4x6PX6UjoEfIk3g_gpb9/view?usp=sharing Martin Wilck , 23 Eki 2018 Sal, 16:55 tarihinde şunu yazdı: > On Tue, 2018-10-23 at 14:46 +0300, Özkan Göksu wrote: > > Hello. > > > > I was have a faulted disk

Re: [dm-devel] [PATCH v4 00/11] Zoned block device support improvements

2018-10-24 Thread Damien Le Moal
Jens, On 2018/10/23 16:59, Jens Axboe wrote: > On 10/12/18 4:08 AM, Damien Le Moal wrote: >> This series improves zoned block device support (reduce overhead) and >> introduces many simplifications to the code (overall, there are more >> deletions >> than insertions). >> >> In more details: >> *