[dm-devel] [PATCH] multipathd: display the host WWNN fields When the iSCSI path information is displayed using the multipath command, the host WWNN in the path information is not fully displayed, as f

2018-10-26 Thread s90006763
This patch solves this problem and gets the complete display of host WWNN related fields,as follows:multipathd show paths format "%N %n" Host WWNN Target WWPN Iqn.xx-x.com.redhat:86329 iqn.xxx-xx.com.xx:oceanstor:::xx:x.x Iqn.xx-x.com.redhat:86329 iqn.xxx-xx.com.xx:oceanstor:::xx:x.x ---

Re: [dm-devel] [PATCH 7/7] multipathd: only grab conf once for filter_path()

2018-10-26 Thread Benjamin Marzinski
On Wed, Oct 24, 2018 at 12:05:52AM +0200, Martin Wilck wrote: > This saves a possibly large number of cleanup push/pop calls and > slightly improves readability. > Reviewed-by: Benjamin Marzinsk > Signed-off-by: Martin Wilck > --- > multipathd/main.c | 7 --- > 1 file changed, 4

Re: [dm-devel] [PATCH 6/7] multipathd: make DAEMON_SHUTDOWN a terminal state

2018-10-26 Thread Benjamin Marzinski
On Wed, Oct 24, 2018 at 12:05:51AM +0200, Martin Wilck wrote: > It can happen that, before the main thread reacts on DAEMON_SHUTDOWN > and starts cancelling threads, another thread resets the state to > something else. Fix that. > Reviewed-by: Benjamin Marzinsk > Signed-off-by: Martin Wilck >

Re: [dm-devel] [PATCH 5/7] multipathd: set DAEMON_CONFIGURE from uxlsnr thread

2018-10-26 Thread Benjamin Marzinski
On Wed, Oct 24, 2018 at 12:05:50AM +0200, Martin Wilck wrote: > Commit ee01e841 had the intention to make multipathd quit if > the client socket couldn't be set up, because the unix socket > listener is vital for signal handling in multipathd. > But during startup, this condition might be lost if

Re: [dm-devel] [RFC] dm-bow working prototype

2018-10-26 Thread Mikulas Patocka
On Thu, 25 Oct 2018, Paul Lawrence wrote: > Thank you for the suggestion. I spent part of yesterday experimenting with > this idea, and it is certainly very promising. However, it does have some > disadvantages as compared to dm-bow, if I am understanding the setup > correctly: > > 1) Since

Re: [dm-devel] [git pull] device mapper changes for 4.20

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 8:28 AM Mike Snitzer wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-4.20/dm-changes Pulled, thanks, Linus -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 4/7] multipathd: open client socket early

2018-10-26 Thread Benjamin Marzinski
On Wed, Oct 24, 2018 at 12:05:49AM +0200, Martin Wilck wrote: > Open the unix socket in multipathd code and pass the fd to > uxsock_listen(). This will enable us to make the main thread > wait for successful socket initialization in a follow-up patch. > > Signed-off-by: Martin Wilck > --- >

Re: [dm-devel] [PATCH 3/7] multipathd: print error message if checkint is not initialized

2018-10-26 Thread Benjamin Marzinski
On Wed, Oct 24, 2018 at 12:05:48AM +0200, Martin Wilck wrote: > This is just a safety measure in case I overlooked something wrt > the checkint initialization. It could be reverted once we know the > error message isn't triggered. > Reviewed-by: Benjamin Marzinsk > Signed-off-by: Martin Wilck

Re: [dm-devel] [PATCH 1/7] libmultipath: set pp->checkint in store_pathinfo()

2018-10-26 Thread Benjamin Marzinski
On Wed, Oct 24, 2018 at 12:05:46AM +0200, Martin Wilck wrote: > store_pathinfo is called with valid conf pointer anyway, so > checkint is available. pp->checkint is now valid for every > path after path_discovery(). > > This fixes a bad conf access in cli_add_path(). > Reviewed-by: Benjamin

[dm-devel] [git pull] device mapper changes for 4.20

2018-10-26 Thread Mike Snitzer
Hi Linus, Welcome back! The following changes since commit 118aa47c7072bce05fc39bd40a1c0a90caed72ab: dm linear: fix linear_end_io conditional definition (2018-10-10 23:22:24 -0400) are available in the Git repository at:

Re: [dm-devel] [PATCH 17/21] libmultipath: pathinfo: don't blank wwid if checker fails

2018-10-26 Thread Benjamin Marzinski
On Fri, Oct 26, 2018 at 11:16:23AM +0200, Martin Wilck wrote: > On Thu, 2018-10-25 at 16:50 -0500, Benjamin Marzinski wrote: > > On Fri, Oct 12, 2018 at 12:27:03AM +0200, Martin Wilck wrote: > > > Blanking a WWID is a dangerous operation. E.g. configure() would > > > consider the path in

Re: [dm-devel] [PATCH 17/21] libmultipath: pathinfo: don't blank wwid if checker fails

2018-10-26 Thread Martin Wilck
On Thu, 2018-10-25 at 16:50 -0500, Benjamin Marzinski wrote: > On Fri, Oct 12, 2018 at 12:27:03AM +0200, Martin Wilck wrote: > > Blanking a WWID is a dangerous operation. E.g. configure() would > > consider the path in question as invalid and orphan it if the > > WWID is blank. Don't do this for

Re: [dm-devel] [PATCH 13/21] libmultipath: clariion checker: leave unsupported paths alone

2018-10-26 Thread Benjamin Marzinski
On Fri, Oct 12, 2018 at 12:26:59AM +0200, Martin Wilck wrote: > A checker shouldn't set the path state to PATH_DOWN if it fails > to obtain information about the path in the first place. Add logic > to the checker to distinguish a failed path from an unsupported path. > > Signed-off-by: Martin

Re: [dm-devel] [RFC] dm-bow working prototype

2018-10-26 Thread MegaBrutal
Paul Lawrence ezt írta (időpont: 2018. okt. 23., K, 23:27): > > bow == backup on write > > Similar to dm-snap, add the ability to take a snapshot of a device. > Unlike dm-snap, a separate volume is not required. > The concept intrigued me, so I actually went on to try your prototype. I could

Re: [dm-devel] dm-integrity stalls with iMX6q CAAM

2018-10-26 Thread Neil Armstrong
On 17/10/2018 15:35, Horia Geanta wrote: > On 9/21/2018 3:06 PM, Neil Armstrong wrote: >> Hi, >> >> I recently configured dm-crypt + dm-integrity on an iMX6q platform with CAAM >> Hash functions enabled using the following command lines : >> >> Linux 4.14.71 >> >> cryptsetup luksFormat