Re: [dm-devel] [PATCH v2 4/7] multipathd: open client socket early

2018-11-01 Thread Benjamin Marzinski
On Tue, Oct 30, 2018 at 10:22:46PM +0100, Martin Wilck wrote: > Open the unix socket in multipathd code and pass the fd to > uxsock_listen(). This will enable us to make the main thread > wait for successful socket initialization in a follow-up patch. > > Signed-off-by: Martin Wilck > --- >

Re: [dm-devel] dm crypt: use unsigned long long instead of sector_t to store iv_offset

2018-11-01 Thread Mike Snitzer
On Thu, Nov 01 2018 at 4:53am -0400, AliOS system security wrote: > The iv_offset in the mapping table of crypt target is a 64bit number > when iv mode is plain64 or plain64be. It will be assigned to iv_offset of > struct crypt_config, cc_sector of struct convert_context and iv_sector of >

Re: [dm-devel] [PATCH v3 22/22] libmultipath: make checker_message thread safe

2018-11-01 Thread Benjamin Marzinski
On Tue, Oct 30, 2018 at 10:06:53PM +0100, Martin Wilck wrote: > Get rid of the static char buffer in checker_message() > introduced in the previous "replace message by msgid" patch. What you have is fine, but why not something like this, which doesn't need to do any allocating? diff --git

Re: [dm-devel] [PATCH v4 03/22] libmultipath/checkers: replace message by msgid

2018-11-01 Thread Benjamin Marzinski
On Wed, Oct 31, 2018 at 11:59:38AM +0100, Martin Wilck wrote: > Replace the character array "message" in struct checker with > a "message ID" field. > > The generic checker code defines a couple of standard message IDs > and corresponding messages. Checker-specific message IDs start > at

Re: [dm-devel] Some questions on commit 3db2776d9fca (dm snapshot: improve performance by switching out_of_order_list to rbtree)

2018-11-01 Thread Nikos Tsironis
Hi Mikulas! Thanks a lot for your answer, Nikos -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel