Re: [dm-devel] [PATCH 08/19] libmultipath: decrease log level of word splitting

2018-11-29 Thread Benjamin Marzinski
On Wed, Nov 21, 2018 at 11:18:28AM +0100, Martin Wilck wrote: > This will make log level 4 actually usable. condlog doesn't actually handle verbosity levels gerater than 4 correctly when logging to syslog (there is no loglevel 8). I didn't even realize that there were any condlog(5, ...) calls.

Re: [dm-devel] [PATCH 16/19] libmultipath: coalesce_paths: fix size mismatch handling

2018-11-29 Thread Benjamin Marzinski
On Wed, Nov 21, 2018 at 11:18:36AM +0100, Martin Wilck wrote: > When there are paths with the same WWID but different sizes, and > coalesce_paths() walks the pathvec, it checks paths _after_ > the current one for size mismatch and sets ACT_REJECT. However, > these paths will be reached in the main

Re: [dm-devel] [PATCH 00/19] multipath-tools: improve logging at -v3

2018-11-29 Thread Benjamin Marzinski
On Wed, Nov 21, 2018 at 11:18:20AM +0100, Martin Wilck wrote: > Hi Christophe, > > most of the patches in this series reduce log levels of frequently > printed messages at verbosity level 3. My goal was to limit the > output of multipathd to one line per path per checker invocation, > which is suf

Re: [dm-devel] [PATCH 2/3] block: switch to per-cpu in-flight counters

2018-11-29 Thread Mike Snitzer
On Tue, Nov 27 2018 at 7:42pm -0500, Mikulas Patocka wrote: > Now when part_round_stats is gone, we can switch to per-cpu in-flight > counters. > > We use the local-atomic type local_t, so that if part_inc_in_flight or > part_dec_in_flight is reentrantly called from an interrupt, the value will

Re: [dm-devel] [PATCH 2/3] block: switch to per-cpu in-flight counters

2018-11-29 Thread Mikulas Patocka
On Thu, 29 Nov 2018, Mike Snitzer wrote: > On Tue, Nov 27 2018 at 7:42pm -0500, > Mikulas Patocka wrote: > > > Now when part_round_stats is gone, we can switch to per-cpu in-flight > > counters. > > > > We use the local-atomic type local_t, so that if part_inc_in_flight or > > part_dec_in_f

[dm-devel] [PATCH v2 0/1] Fix false removes

2018-11-29 Thread Benjamin Marzinski
This is a resend of my previous patch 2/2, incorporating both of Martin's suggestions. Benjamin Marzinski (1): libmultipath: fix false removes in dmevents polling code libmpathpersist/mpath_persist.c | 4 ++-- libmultipath/devmapper.c| 41 + mul

[dm-devel] [PATCH v2 1/1] libmultipath: fix false removes in dmevents polling code

2018-11-29 Thread Benjamin Marzinski
dm_is_mpath() would return 0 if either a device was not a multipath device or if the libdevmapper command failed. Because dm_is_mpath() didn't distinguish between these situations, dm_get_events() could assume that a device was not really a multipath device, when in fact it was, and the libdevmappe

Re: [dm-devel] [PATCH 2/3] block: switch to per-cpu in-flight counters

2018-11-29 Thread Jens Axboe
On 11/29/18 3:05 PM, Mikulas Patocka wrote: > > > On Thu, 29 Nov 2018, Mike Snitzer wrote: > >> On Tue, Nov 27 2018 at 7:42pm -0500, >> Mikulas Patocka wrote: >> >>> Now when part_round_stats is gone, we can switch to per-cpu in-flight >>> counters. >>> >>> We use the local-atomic type local_t

Re: [dm-devel] [PATCH 2/3] block: switch to per-cpu in-flight counters

2018-11-29 Thread Mike Snitzer
On Thu, Nov 29 2018 at 5:05pm -0500, Mikulas Patocka wrote: > > > On Thu, 29 Nov 2018, Mike Snitzer wrote: > > > On Tue, Nov 27 2018 at 7:42pm -0500, > > Mikulas Patocka wrote: > > > > > Now when part_round_stats is gone, we can switch to per-cpu in-flight > > > counters. > > > > > > We u

Re: [dm-devel] [PATCH 3/3] block: return just one value from part_in_flight

2018-11-29 Thread Mike Snitzer
On Tue, Nov 27 2018 at 7:42pm -0500, Mikulas Patocka wrote: > The previous patches deleted all the code that needed the second value > returned from part_in_flight - now the kernel only uses the first value. > > Consequently, part_in_flight (and blk_mq_in_flight) may be changed so that > it onl

[dm-devel] [PATCH] dm-zoned: Fix target BIO completion handling

2018-11-29 Thread Damien Le Moal
struct bioctx includes the ref refcount_t to track the number of I/O fragments used to process a target BIO as well as ensure that the zone of the BIO is kept in the active state throughout the lifetime of the BIO. However, since decrementing of this reference count is done in the target .end_io me