Re: [dm-devel] block: Fix a WRITE SAME BUG_ON

2019-02-13 Thread Martin K. Petersen
zhangxiaoxu, > Any progress about the problme? > Should we disable the write same when stack the different LBA disks? Yes, please. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v2 2/4] multipath: blacklist zram devices

2019-02-13 Thread Benjamin Marzinski
Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- libmultipath/blacklist.c | 2 +- multipath/multipath.conf.5 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/blacklist.c b/libmultipath/blacklist.c index 709895e..e0d0279 100644 --- a/libmultipat

[dm-devel] [PATCH v2 3/4] multipathd: fix pp->initialized state ping-ponging

2019-02-13 Thread Benjamin Marzinski
When a multipath device fails to get a wwid in pathinfo, it moves to the INIT_MISSING_UDEV state. After a device in this state sends retrigger_tries change uevents in check_path(), it moves to the INIT_FAILED state. However, when check_path() is run on a device in INIT_FAILED, it can call pathinfo

[dm-devel] [PATCH v2 4/4] multipathd: don't resend change events for unknown devices

2019-02-13 Thread Benjamin Marzinski
If multipath fails to get the wwid for a device, and the device is of an unknown type (pp->bus == SYSFS_BUS_UNDEF), don't send change events. Instead, assume that the device was not meant to be used and skip it. Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- libmultipath/discov

[dm-devel] [PATCH v2 1/4] multipathd: avoid null pointer dereference in LOG_MSG

2019-02-13 Thread Benjamin Marzinski
From: Martin Wilck LOG_MSG() will dereference pp->mpp. Commit cb5ec664 added a call to LOG_MSG() before the check for (!pp->mpp) in check_path. This can cause multipathd to crash. LOG_MSG() should check the fields before dereferencing them. Make checker_selected() an inline function to allow th

[dm-devel] [PATCH v2 0/4] multipath: fixes for invalid path device handling

2019-02-13 Thread Benjamin Marzinski
I recently got a bug from a user with a bad property blacklist_exceptions line, where multipath tried to use a zram device, which caused multipathd to crash. This patch set fixes that crash, and then adds some additional safeguards to prevent things like this happening in the future. The first pat

Re: [dm-devel] Possible bug in mirror target

2019-02-13 Thread Zdenek Kabelac
Dne 13. 02. 19 v 16:01 Bryn M. Reeves napsal(a): On Wed, Feb 13, 2019 at 03:21:52PM +0100, Zdenek Kabelac wrote: If you have this free space it's surely not a bad thing - but there are many cases, you can get any free space - majority of filesystems does not support shrinking - so the only 'free

Re: [dm-devel] Possible bug in mirror target

2019-02-13 Thread Bryn M. Reeves
On Wed, Feb 13, 2019 at 03:21:52PM +0100, Zdenek Kabelac wrote: > If you have this free space it's surely not a bad thing - but there > are many cases, you can get any free space - majority of filesystems > does not support shrinking - so the only 'free' space you can > get is by adding new storage

Re: [dm-devel] Possible bug in mirror target

2019-02-13 Thread Zdenek Kabelac
Hi Dne 12. 02. 19 v 23:36 John Stoffel napsal(a): "Zdenek" == Zdenek Kabelac writes: Zdenek> Dne 10. 02. 19 v 22:58 John Stoffel napsal(a): Zdenek> The old dm mirror works differently then new dm raid - so if Zdenek> you have an old one present/running (i.e. LVM mirrored volume) Zdenek> usin

[dm-devel] [PATCH 1/3] dm: remove redundant unlikely annotation in dm-integrity.c

2019-02-13 Thread Chengguang Xu
unlikely has already included in IS_ERR(), so just remove redundant unlikely annotation. Signed-off-by: Chengguang Xu --- drivers/md/dm-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c index 457200ca6287..f1ab81

[dm-devel] [PATCH 3/3] dm: remove redundant unlikely annotation in dm-block-manager.c

2019-02-13 Thread Chengguang Xu
unlikely has already included in IS_ERR(), so just remove redundant unlikely annotation. Signed-off-by: Chengguang Xu --- drivers/md/persistent-data/dm-block-manager.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/md/persistent-data/dm-block-manager.c b/dri

[dm-devel] [PATCH 2/3] dm: remove redundant unlikely annotation in dm-verity-fec.c

2019-02-13 Thread Chengguang Xu
unlikely has already included in IS_ERR(), so just remove redundant unlikely annotation. Signed-off-by: Chengguang Xu --- drivers/md/dm-verity-fec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-verity-fec.c b/drivers/md/dm-verity-fec.c index 0ce04e5b4af