Re: [dm-devel] dm: rename max_io_len to io_boundary

2019-03-21 Thread Mike Snitzer
On Thu, Mar 21 2019 at 6:57pm -0400, John Dorminy wrote: > Perhaps this wording might be clearer? > > /* If non-zero, I/O submitted to a target will be split so as to not > straddle any multiple of this length (in bytes) */ .max_io_len is a pretty well-worn DM target attribute. I'd prefer to

Re: [dm-devel] [PATCH] dm: rename max_io_len to io_boundary

2019-03-21 Thread John Dorminy
I'm thankful for this change making it explicit that this parameter is not a max IO length but something else. I've been confused by the name more than once when trying to figure out why IOs weren't coming in as large as I expected. I wish there were a way for targets to say "I can accept IO of up

Re: [dm-devel] [PATCH 0/3] New approach at handling changed WWIDs

2019-03-21 Thread Benjamin Marzinski
On Wed, Mar 20, 2019 at 09:37:35AM +0100, Martin Wilck wrote: > On Tue, 2019-03-19 at 19:44 +0100, Martin Wilck wrote: > > On Tue, 2019-03-19 at 12:11 -0500, Benjamin Marzinski wrote: > > > On Mon, Mar 18, 2019 at 01:12:32PM +0100, Martin Wilck wrote: > > > > > > > > Note also that if a

[dm-devel] [PATCH] dm: rename max_io_len to io_boundary

2019-03-21 Thread Mikulas Patocka
This patch renames dm_set_target_max_io_len to dm_set_target_io_boundary and max_io_len to io_boundary. This variable is really a boundary, not a length. If a bio crosses this boundary, the device mapper core splits it before submitting it to the target. Signed-off-by: Mikulas Patocka ---

[dm-devel] [PATCH] dm: revert 8f50e358153d ("dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE")

2019-03-21 Thread Mikulas Patocka
The limit was already incorporated to dm-crypt (4e870e948fba - "dm crypt: fix error with too large bios"), so we don't need to apply it globally to all targets. The quantity BIO_MAX_PAGES * PAGE_SIZE is wrong anyway because the variable ti->max_io_len it is supposed to be in the units of 512-byte

Re: [dm-devel] dm_set_target_max_io_len

2019-03-21 Thread Ming Lei
Hi Mikulas, On Thu, Mar 21, 2019 at 06:33:32AM -0400, Mikulas Patocka wrote: > Hi > > I'm looking at the patch 8f50e358153dd68182c714626be4a90b64179cf4. The > patch claims that dm-crypt can't deal with large bios - but I fixed this > problem with dm-crypt a year before (see the patch >

Re: [dm-devel] Where to read the WWID of a multipath device

2019-03-21 Thread Sahid Orentino Ferdjaoui
On Thu, Mar 21, 2019 at 01:57:39AM -0600, Russell Weber wrote: > I would assume that most linux distributions at this point in time support > getting the wwids through: > ```cat /etc/multipath/wwids This path can be changed via multipath.conf I can't really use it. Also I just have a list of

Re: [dm-devel] Where to read the WWID of a multipath device

2019-03-21 Thread Russell Weber
I would assume that most linux distributions at this point in time support getting the wwids through: ```cat /etc/multipath/wwids This can also be parsed out of multipath -ll ``` [USER ~]# multipath -ll mpathak (26639613661623365) dm-3 FUSIONIO,ION LUN size=2.7T features='3 queue_if_no_path