Re: [dm-devel] linux-next: Tree for Apr 29 (drivers/md/dm-dust)

2019-04-29 Thread Randy Dunlap
On 4/29/19 2:03 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190426: > on i386: ld: drivers/md/dm-dust.o: in function `dust_map': dm-dust.c:(.text+0x28d): undefined reference to `__udivdi3' ld: drivers/md/dm-dust.o: in function `dust_message': dm-dust.c:(.text+0x9a4): undefined ref

[dm-devel] [PATCH 07/10] dm-integrity: update documentation

2019-04-29 Thread Mikulas Patocka
Update documentation with the "meta_device" parameter and flags. Signed-off-by: Mikulas Patocka --- Documentation/device-mapper/dm-integrity.txt | 10 +- drivers/md/dm-integrity.c|4 +++- 2 files changed, 12 insertions(+), 2 deletions(-) Index: linux-2.6/Docum

[dm-devel] [PATCH 00/10] dm-integrity bitmap patches

2019-04-29 Thread Mikulas Patocka
Hi Here I'm sending the dm-integrity patches that use bitmap of dirty regions instead of a journal. The bitmap mode is activated by using the letter 'B' on the target line. Mikulas -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 04/10] dm-ingerity: pass size to dm_integrity_alloc_page_list

2019-04-29 Thread Mikulas Patocka
Pass size to dm_integrity_alloc_page_list. The following patches will need a size that is different from ic->journal_pages. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) Index: linux-2.6/dri

[dm-devel] [PATCH 10/10] dm-integrity: implement synchronous mode for reboot handling

2019-04-29 Thread Mikulas Patocka
Unfortunatelly, there may be bios coming even after the reboot notifier was called. We don't want these bios to make the bitmap dirty again. This patch implements a synchronous mode - when a bio is about to be terminated, we clean the bitmap and terminate the bio after the clean operation succeeds

[dm-devel] [PATCH 03/10] dm-integrity: introduce rw_journal_sectors

2019-04-29 Thread Mikulas Patocka
Introduce a function rw_journal_sectors that takess sector and length as its arguments instead of a section and the number of sections. This functions will be used in further patches. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c | 20 ++-- 1 file changed, 14 i

[dm-devel] [PATCH 08/10] dm-integrity: add a bitmap mode

2019-04-29 Thread Mikulas Patocka
Add a new bitmap mode for dm-integrity. Signed-off-by: Mikulas Patocka --- Documentation/device-mapper/dm-integrity.txt | 23 + drivers/md/dm-integrity.c| 534 +-- 2 files changed, 525 insertions(+), 32 deletions(-) Index: linux-2.6/drivers/md/dm-

[dm-devel] [PATCH 01/10] dm-integrity: dont check null pointer before kvfree and vfree

2019-04-29 Thread Mikulas Patocka
The functions kfree, vfree and kvfree do nothing if we pass a NULL pointer to them. So we don't need to test the pointer for NULL. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) Index: linux-2.6/drivers/md/dm-integrit

[dm-devel] [PATCH 05/10] dm-integrity: allow large ranges

2019-04-29 Thread Mikulas Patocka
This patch changes the type of the variable n_sectors from unsigned to n_sectors. The following patches will need to lock large ranges. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.6/drivers/md/dm-int

[dm-devel] [PATCH 02/10] dm-integrity: dont report unused options

2019-04-29 Thread Mikulas Patocka
If we are not journaling, don't report journaling options in the table status. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Index: linux-2.6/drivers/md/dm-integrity.c

[dm-devel] [PATCH 09/10] dm-integrity: handle machine reboot in bitmap mode

2019-04-29 Thread Mikulas Patocka
When we are in bitmap mode, we need to clear the bitmap when we are rebooting. This patch adds the reboot hook. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c | 24 1 file changed, 24 insertions(+) Index: linux-2.6/drivers/md/dm-integrity.c

[dm-devel] [PATCH 06/10] dm-integrity: introduce a function add_new_range_and_wait

2019-04-29 Thread Mikulas Patocka
Introduce a function add_new_range_and_wait in order to avoid repetitive code. It will be used in the following patch. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) Index: linux-2.6/drivers/md/dm-integrity.c ==

Re: [dm-devel] [PATCH v2] dm mpath: fix missing call of path selector type->end_io

2019-04-29 Thread Martin Wilck
On Thu, 2019-04-25 at 15:45 -0400, Mike Snitzer wrote: > On Thu, Apr 25 2019 at 5:25am -0400, > yuyufen wrote: > > > > "CANCAL" looks strange - did you mean "CANCEL"? > > > > This is a spelling error. > > > > > Anyway, what do you need this new enum for? Couldn't you just > > > pass the > > >

[dm-devel] [PATCH] dm mpath: parse_path: always free attached_handler_name

2019-04-29 Thread Martin Wilck
Commit b592211c33f7 "dm mpath: fix attached_handler_name leak and dangling hw_handler_name pointer" fixed a memory leak for the case where setup_scsi_dh() returns failure. But setup_scsi_dh may return success and not "use" attached_handler_name if the retain_attached_hwhandler flag is not set on th

Re: [dm-devel] [PATCH] dm mpath: fix memory leak for attached_handler_name

2019-04-29 Thread Martin Wilck
On Sat, 2019-04-27 at 18:54 +0800, Yufen Yu wrote: > If multipath does not set flag MPATHF_RETAIN_ATTACHED_HW_HANDLER, > parse_path() would forget to free attached_handler_name when > successfully exit, resulting in memory leak. I believe this should rather be done in parse_path(), as setup_scsi_d

Re: [dm-devel] [PATCH] dm-writecache: avoid unnecessary lookups in writecache_find_entry

2019-04-29 Thread Huaisheng HS1 Ye
From: Mikulas Patocka Sent: Friday, April 26, 2019 9:59 PM > > > On Wed, 24 Apr 2019, Huaisheng HS1 Ye wrote: > > > From: Mikulas Patocka > > Sent: Tuesday, April 23, 2019 11:44 PM > > > > > > On Sun, 21 Apr 2019, Huaisheng Ye wrote: > > > > > > > From: Huaisheng Ye > > > > > > > > Only when