Re: [dm-devel] [PATCH V2 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath

2019-07-29 Thread Benjamin Block
Hey Ming Lei, On Sat, Jul 20, 2019 at 11:06:35AM +0800, Ming Lei wrote: > Hi, > > When one request is dispatched to LLD via dm-rq, if the result is > BLK_STS_*RESOURCE, dm-rq will free the request. However, LLD may allocate > private data for this request, so this way will cause memory leak. I a

Re: [dm-devel] memory leak in bio_copy_user_iov

2019-07-29 Thread syzbot
syzbot has bisected this bug to: commit 664820265d70a759dceca87b6eb200cd2b93cda8 Author: Mike Snitzer Date: Thu Feb 18 20:44:39 2016 + dm: do not return target from dm_get_live_table_for_ioctl() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13f4eb6460 start commit:

Re: [dm-devel] memory leak in bio_copy_user_iov

2019-07-29 Thread Bob Liu
On 7/29/19 8:38 AM, syzbot wrote: > syzbot has bisected this bug to: > > commit 664820265d70a759dceca87b6eb200cd2b93cda8 > Author: Mike Snitzer > Date:   Thu Feb 18 20:44:39 2016 + > >     dm: do not return target from dm_get_live_table_for_ioctl() > This(and previous bisection) look not r

Re: [dm-devel] [PATCH V2 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath

2019-07-29 Thread Ming Lei
On Fri, Jul 26, 2019 at 06:20:46PM +0200, Benjamin Block wrote: > Hey Ming Lei, > > On Sat, Jul 20, 2019 at 11:06:35AM +0800, Ming Lei wrote: > > Hi, > > > > When one request is dispatched to LLD via dm-rq, if the result is > > BLK_STS_*RESOURCE, dm-rq will free the request. However, LLD may allo

Re: [dm-devel] snapshot-origin with no snapshot may lead to BUG() in bio_split()

2019-07-29 Thread Mike Snitzer
On Sat, Jul 20 2019 at 5:26am -0400, Cédric Delmas wrote: > Hello, > > I encountered a bug while working with DM snapshot targets: having a > snapshot-origin target with all snapshots removed may lead to > BUG_ON(sectors <= 0) in function bio_split() (file block/bio.c). ... > Steps to reprod

Re: [dm-devel] [RFC PATCH 1/1] dm: add clone target

2019-07-29 Thread Heinz Mauelshagen
Hi Nikos, thanks for providing these benchmarks which  seem to confirm the advantages of clone vs. a snapshot/raid1 stack. Can you please provide 'dmsetup table' for both configurations for completeness? Heinz On 7/22/19 10:16 PM, Nikos Tsironis wrote: On 7/17/19 5:41 PM, Heinz Mauelshagen

Re: [dm-devel] [PATCH] md/raid0: Fail BIOs if their underlying block device is gone

2019-07-29 Thread NeilBrown
On Mon, Jul 29 2019, Guilherme G. Piccoli wrote: > Currently md/raid0 is not provided with any mechanism to validate if > an array member got removed or failed. The driver keeps sending BIOs > regardless of the state of array members. This leads to the following > situation: if a raid0 array mem

Re: [dm-devel] [PATCH 1/2] md/raid0: Introduce new array state 'broken' for raid0

2019-07-29 Thread NeilBrown
On Mon, Jul 29 2019, Guilherme G. Piccoli wrote: > Currently if a md/raid0 array gets one or more members removed while > being mounted, kernel keeps showing state 'clean' in the 'array_state' > sysfs attribute. Despite udev signaling the member device is gone, 'mdadm' > cannot issue the STOP_AR