Re: [dm-devel] [PATCH 2/2] scsi: core: fix dh and multipathing for SCSI hosts without request batching

2019-08-07 Thread kbuild test robot
Hi Steffen, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc3 next-20190807] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Steffen

Re: [dm-devel] [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching

2019-08-07 Thread kbuild test robot
Hi Steffen, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc3 next-20190807] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Steffen

Re: [dm-devel] [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching

2019-08-07 Thread Martin K. Petersen
Ming, >> + .cleanup_rq = scsi_cleanup_rq, >> .busy = scsi_mq_lld_busy, >> .map_queues = scsi_map_queues, >> }; > > This one is a cross-tree thing, either scsi/5.4/scsi-queue needs to > pull for-5.4/block, or do it after both land linus tree. I'll set up

Re: [dm-devel] [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching

2019-08-07 Thread Ming Lei
On Wed, Aug 7, 2019 at 10:55 PM Steffen Maier wrote: > > This was missing from scsi_mq_ops_no_commit of linux-next commit > 8930a6c20791 ("scsi: core: add support for request batching") > from Martin's scsi/5.4/scsi-queue or James' scsi/misc. > > See also linux-next commit b7e9e1fb7a92 ("scsi: imp

RE: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-07 Thread Pascal Van Leeuwen
> -Original Message- > From: Horia Geanta > Sent: Wednesday, August 7, 2019 5:52 PM > To: Pascal Van Leeuwen ; Ard Biesheuvel > > Cc: Milan Broz ; Herbert Xu > ; dm- > de...@redhat.com; linux-cry...@vger.kernel.org > Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext stealin

Re: [dm-devel] [PATCH 0/2] scsi: core: regression fixes for request batching

2019-08-07 Thread Bart Van Assche
On 8/7/19 7:49 AM, Steffen Maier wrote: Hi James, Martin, Paolo, Ming, multipathing with linux-next is broken since 20190723 in our CI. The patches fix a memleak and a severe dh/multipath functional regression. It would be nice if we could get them to 5.4/scsi-queue and also next. > I would ha

Re: [dm-devel] [PATCH 0/2] scsi: core: regression fixes for request batching

2019-08-07 Thread Paolo Bonzini
On 07/08/19 16:49, Steffen Maier wrote: > Hi James, Martin, Paolo, Ming, > > multipathing with linux-next is broken since 20190723 in our CI. > The patches fix a memleak and a severe dh/multipath functional regression. > It would be nice if we could get them to 5.4/scsi-queue and also next. > > I

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-07 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, August 7, 2019 5:40 PM > To: Pascal Van Leeuwen > Cc: linux-cry...@vger.kernel.org; herb...@gondor.apana.org.au; > ebigg...@kernel.org; > a...@redhat.com; snit...@redhat.com; dm-devel@redhat.com; gmazyl...@gmail.com > Subject

Re: [dm-devel] [PATCH] ALUA support for PURE FlashArray

2019-08-07 Thread Xose Vazquez Perez
On 6/26/19 7:37 PM, Brian Bunker wrote: > It has been some time since we updated our PURE FlashArray configuration. The > Linux vendors that we had been seeing in the field were using very old > versions > of multipath-tools, so we haven’t needed to change anything for some time. > With > the re

Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-07 Thread Horia Geanta
On 7/26/2019 10:59 PM, Horia Geantă wrote: > On 7/26/2019 1:31 PM, Pascal Van Leeuwen wrote: >> Ok, find below a patch file that adds your vectors from the specification >> plus my set of additional vectors covering all CTS alignments combined >> with the block sizes you desired. Please note though

Re: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-07 Thread Ard Biesheuvel
On Wed, 7 Aug 2019 at 16:52, Pascal Van Leeuwen wrote: > > Ard, > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Wednesday, August 7, 2019 3:17 PM > > To: Pascal Van Leeuwen > > Cc: linux-cry...@vger.kernel.org; herb...@gondor.apana.org.au; > > ebigg...@kernel.org; > > a...@r

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-07 Thread Pascal Van Leeuwen
Ard, > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, August 7, 2019 3:17 PM > To: Pascal Van Leeuwen > Cc: linux-cry...@vger.kernel.org; herb...@gondor.apana.org.au; > ebigg...@kernel.org; > a...@redhat.com; snit...@redhat.com; dm-devel@redhat.com; gmazyl...@gmail.com > S

Re: [dm-devel] [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-07 Thread Ard Biesheuvel
On Wed, 7 Aug 2019 at 10:28, Pascal Van Leeuwen wrote: > > Ard, > > I've actually been following this discussion with some interest, as it has > some relevance for some of the things I am doing at the moment as well. > > For example, for my CTS implementation I need to crypt one or two > seperate

Re: [dm-devel] [PATCH 3/3] dm-zoned: properly handle backing device failure

2019-08-07 Thread Damien Le Moal
On 2019/08/06 10:06, Dmitry Fomichev wrote: > dm-zoned is observed to lock up or livelock in case of hardware > failure or some misconfiguration of the backing zoned device. > > This patch adds a new function in the target code that checks the > status of the backing device request queue. If it go

Re: [dm-devel] [PATCH 2/3] dm-zoned: improve error handling in i/o map code

2019-08-07 Thread Damien Le Moal
On 2019/08/06 10:06, Dmitry Fomichev wrote: > Some errors are ignored in the I/O path during queueing chunks > for processing by chunk works. Since at least these errors are > transient in nature, it should be possible to retry the failed > incoming commands. > > The fix - > > Errors that can hap

Re: [dm-devel] [PATCH 1/3] dm-zoned: improve error handling in reclaim

2019-08-07 Thread Damien Le Moal
On 2019/08/06 10:06, Dmitry Fomichev wrote: > There are several places in reclaim code where errors are not > propagated to the main function, dmz_reclaim(). This function > is responsible for unlocking zones that might be still locked > at the end of any failed reclaim iterations. As the result, >

Re: [dm-devel] [PATCH] dm kcopyd: always complete failed jobs

2019-08-07 Thread Damien Le Moal
On 2019/08/06 8:56, Dmitry Fomichev wrote: > This patch fixes a problem in dm-kcopyd that may leave jobs in > complete queue indefinitely in the event of backing storage failure. > > This behavior has been observed while running 100% write file fio > workload against an XFS volume created on top o

Re: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-07 Thread Milan Broz
On 07/08/2019 07:50, Ard Biesheuvel wrote: > Instead of instantiating a separate cipher to perform the encryption > needed to produce the IV, reuse the skcipher used for the block data > and invoke it one additional time for each block to encrypt a zero > vector and use the output as the IV. > > F

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-07 Thread Pascal Van Leeuwen
Ard, I've actually been following this discussion with some interest, as it has some relevance for some of the things I am doing at the moment as well. For example, for my CTS implementation I need to crypt one or two seperate blocks and for the inside-secure driver I sometimes need to do some s