Re: [dm-devel] dm-integrity

2020-01-14 Thread Gandalf Corvotempesta
Il giorno lun 13 gen 2020 alle ore 19:58 Song Liu ha scritto: > Right now, md_done_sync() doesn't really print any message. I think this is > easy to add. However, md check/recovery is at block granularity, so we > probably cannot print exact which sector got fixed. Well, having the exact sector

Re: [dm-devel] dm-integrity

2020-01-14 Thread Song Liu
+ dm-devel On Sun, Jan 12, 2020 at 5:43 AM Gandalf Corvotempesta wrote: > > I'm testing dm-integrity. > Simple question: when corrupted data are found, repair is done > immediately or on next scrub? > > This is what I have: > > [ 6727.395808] md: data-check of RAID array md0 > [ 6727.528589] devi

Re: [dm-devel] [PATCH] dm writecache: SB remove seq_count

2020-01-14 Thread Maged Mokhtar
On 08/01/2020 19:04, Mikulas Patocka wrote: BTW. I would be interested if this patch improves performance for you. Could you test it? (you also need my previous patch posted here https://www.redhat.com/archives/dm-devel/2020-January/msg00027.html ) Mikulas dm-writecache: use REQ_FUA when

Re: [dm-devel] [PATCH] dm writecache: SB remove seq_count

2020-01-14 Thread Maged Mokhtar
Hi On Thu, 2 Jan 2020, Maged Mokhtar wrote: Any feedback on this patch please. This will definitely not work for persistent memory - it could corrupt data if a crash happens. The CPU can flush data in arbitrary order and it may happen that the seq count is flushed before the pertaining d

Re: [dm-devel] dm-integrity

2020-01-14 Thread Piergiorgio Sartor
On Mon, Jan 13, 2020 at 10:11:00AM -0800, Song Liu wrote: > + dm-devel > > On Sun, Jan 12, 2020 at 5:43 AM Gandalf Corvotempesta > wrote: > > > > I'm testing dm-integrity. > > Simple question: when corrupted data are found, repair is done > > immediately or on next scrub? > > > > This is what I h

[dm-devel] [PATCH v2] dm mpath: Add timeout mechanism for queue_if_no_path

2020-01-14 Thread Gabriel Krisman Bertazi
From: Anatol Pomazau Add a configurable timeout mechanism to disable queue_if_no_path without assistance from multipathd. In reality, this reimplements the no_path_retry mechanism from multipathd in kernel space, which is interesting to prevent processes from hanging indefinitely in cases where

Re: [dm-devel] [PATCH] dm-writecache: fix incorrect flush sequence when doing commit

2020-01-14 Thread Maged Mokhtar
On 08/01/2020 17:46, Mikulas Patocka wrote: When commiting state, the function writecache_flush does the following: 1. write metadata (writecache_commit_flushed) 2. flush disk cache (writecache_commit_flushed) 3. wait for data writes to complete (writecache_wait_for_ios) 4. increase superblock

Re: [dm-devel] dm-integrity

2020-01-14 Thread Song Liu
On Mon, Jan 13, 2020 at 10:17 AM Piergiorgio Sartor wrote: > > On Mon, Jan 13, 2020 at 10:11:00AM -0800, Song Liu wrote: > > + dm-devel > > > > On Sun, Jan 12, 2020 at 5:43 AM Gandalf Corvotempesta > > wrote: > > > > > > I'm testing dm-integrity. > > > Simple question: when corrupted data are fou

Re: [dm-devel] [PATCH] dm writecache: SB remove seq_count

2020-01-14 Thread Mikulas Patocka
On Mon, 13 Jan 2020, Maged Mokhtar wrote: > > > > Hi > > > > > > On Thu, 2 Jan 2020, Maged Mokhtar wrote: > > > > > Any feedback on this patch please. > > > > This will definitely not work for persistent memory - it could corrupt > > data if a crash happens. The CPU can flush data in arbi

Re: [dm-devel] [PATCH v2] dm mpath: Add timeout mechanism for queue_if_no_path

2020-01-14 Thread Mike Snitzer
On Mon, Jan 13 2020 at 5:41P -0500, Gabriel Krisman Bertazi wrote: > From: Anatol Pomazau > > Add a configurable timeout mechanism to disable queue_if_no_path without > assistance from multipathd. In reality, this reimplements the > no_path_retry mechanism from multipathd in kernel space, whi

Re: [dm-devel] [PATCH v2] dm mpath: Add timeout mechanism for queue_if_no_path

2020-01-14 Thread Mike Snitzer
On Tue, Jan 14 2020 at 11:31am -0500, Gabriel Krisman Bertazi wrote: > Mike Snitzer writes: > > > On Mon, Jan 13 2020 at 5:41P -0500, > > Gabriel Krisman Bertazi wrote: > > > >> From: Anatol Pomazau > >> > >> Add a configurable timeout mechanism to disable queue_if_no_path without > >> assi

Re: [dm-devel] kernel BUG at drivers/md/persistent-data/dm-space-map-disk.c:178

2020-01-14 Thread Eric Biggers
On Tue, Jan 07, 2020 at 12:28:25PM +, Joe Thornber wrote: > On Tue, Jan 07, 2020 at 10:46:27AM +, Joe Thornber wrote: > > I'll get a patch to you later today. > > Eric, > > Patch below. I've run it through a bunch of tests in the dm test suite. But > obviously I have never hit your issu

Re: [dm-devel] kernel BUG at drivers/md/persistent-data/dm-space-map-disk.c:178

2020-01-14 Thread Mike Snitzer
On Tue, Jan 14, 2020 at 4:53 PM Eric Biggers wrote: > > On Tue, Jan 07, 2020 at 12:28:25PM +, Joe Thornber wrote: > > On Tue, Jan 07, 2020 at 10:46:27AM +, Joe Thornber wrote: > > > I'll get a patch to you later today. > > > > Eric, > > > > Patch below. I've run it through a bunch of test

[dm-devel] device blacklisting and suspend issue

2020-01-14 Thread Sreenivas.Honnur
I have two queries: 1. We have an issue with device blacklisting. We add an entry in /etc/multipath.conf" and do "service multipathd reload". After this to check if device is blacklisted we issue "multipathd show blacklist" command in a loop(with a delay of 1 second). Sometimes I see that thi