Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Jens Axboe
On 1/15/20 6:35 AM, Mikulas Patocka wrote: > Logical block size has type unsigned short. That means that it can be at > most 32768. However, there are architectures that can run with 64k pages > (for example arm64) and on these architectures, it may be possible to > create block devices with 64k

Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Ming Lei
On Wed, Jan 15, 2020 at 08:35:25AM -0500, Mikulas Patocka wrote: > Logical block size has type unsigned short. That means that it can be at > most 32768. However, there are architectures that can run with 64k pages > (for example arm64) and on these architectures, it may be possible to > create

Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Martin K. Petersen
Mikulas, > This patch changes the logical block size from unsigned short to > unsigned int to avoid the overflow. Looks fine. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com

[dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Mikulas Patocka
Logical block size has type unsigned short. That means that it can be at most 32768. However, there are architectures that can run with 64k pages (for example arm64) and on these architectures, it may be possible to create block devices with 64k block size. For exmaple (run this on an

[dm-devel] device blacklisting and suspend issue

2020-01-15 Thread Sreenivas.Honnur
I have two queries: 1. We have an issue with device blacklisting. We add an entry in /etc/multipath.conf" and do "service multipathd reload". After this to check if device is blacklisted we issue "multipathd show blacklist" command in a loop(with a delay of 1 second). Sometimes I see that

[dm-devel] [PATCH] dm-writecache: improve performance of large linear writes on SSDs

2020-01-15 Thread Mikulas Patocka
When dm-writecache is used with SSD as a cache device, it would submit separate bio for each written block. The I/Os would be merged by the disk scheduler, but this merging degrades performance. This patch makes dm-writecache submit larger bios - we can submit large bio as long as there is

Re: [dm-devel] [PATCH v2] dm mpath: Add timeout mechanism for queue_if_no_path

2020-01-15 Thread Gabriel Krisman Bertazi
Mike Snitzer writes: > On Mon, Jan 13 2020 at 5:41P -0500, > Gabriel Krisman Bertazi wrote: > >> From: Anatol Pomazau >> >> Add a configurable timeout mechanism to disable queue_if_no_path without >> assistance from multipathd. In reality, this reimplements the >> no_path_retry mechanism