Re: [dm-devel] [PATCH 4/4] libmpathpersist: ABI change: limit data-in/out size to 8192 bytes

2020-03-14 Thread Martin Wilck
On Sat, 2020-03-14 at 19:19 -0500, Benjamin Marzinski wrote: > On Sat, Mar 07, 2020 at 12:06:05AM +0100, mwi...@suse.com wrote: > > From: Martin Wilck > > > > Make sure that data structures used for PERSISTENT RESERVE IN/OUT > > fit into 8k buffers. > > > > This patch breaks the libmpathpersist

Re: [dm-devel] [PATCH 4/4] libmpathpersist: ABI change: limit data-in/out size to 8192 bytes

2020-03-14 Thread Benjamin Marzinski
On Sat, Mar 07, 2020 at 12:06:05AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Make sure that data structures used for PERSISTENT RESERVE IN/OUT > fit into 8k buffers. > > This patch breaks the libmpathpersist ABI. > I'm not super worried about this. I don't really see a way for use

Re: [dm-devel] [PATCH 2/4] libmpathpersist: format_transportids(): avoid PROUT overflow

2020-03-14 Thread Martin Wilck
On Sat, 2020-03-14 at 18:15 -0500, Benjamin Marzinski wrote: > On Sat, Mar 07, 2020 at 12:06:03AM +0100, mwi...@suse.com wrote: > > From: Martin Wilck > > > > This limits the PERSISTENT RESERVE OUT data size to max. 8192 > > bytes. > > > > Signed-off-by: Martin Wilck > > --- > > libmpathpersis

Re: [dm-devel] [PATCH 3/4] libmpathpersist: mpath_format_readfullstatus(): use real buffer size

2020-03-14 Thread Benjamin Marzinski
On Sat, Mar 07, 2020 at 12:06:04AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > This changes no semantics, but it will allow changing the size of > prin_readfd.private_buffer in a follow-up patch. > Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > libmpathpersis

Re: [dm-devel] [PATCH 2/4] libmpathpersist: format_transportids(): avoid PROUT overflow

2020-03-14 Thread Benjamin Marzinski
On Sat, Mar 07, 2020 at 12:06:03AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > This limits the PERSISTENT RESERVE OUT data size to max. 8192 bytes. > > Signed-off-by: Martin Wilck > --- > libmpathpersist/mpath_pr_ioctl.c | 26 -- > 1 file changed, 24 insertio

Re: [dm-devel] [PATCH 1/4] libmpathpersist: limit PRIN allocation length to 8192 bytes

2020-03-14 Thread Benjamin Marzinski
On Sat, Mar 07, 2020 at 12:06:02AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Some targets (notably the qemu-pr-helper) don't support PERSISTENT > RESERVE IN commands with more than 8192 bytes allocation length. > While I have found no explicit requirement in the SCSI specs that > th