Re: [dm-devel] [PATCH v2 4/4] libmpathpersist: ABI change: limit data-in/out size to 8192 bytes

2020-03-17 Thread Benjamin Marzinski
On Sun, Mar 15, 2020 at 10:05:21PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Make sure that data structures used for PERSISTENT RESERVE IN/OUT > fit into 8k buffers. > > This patch breaks the libmpathpersist ABI, because the offsets of > struct print_fulldescr_list.descriptors and o

Re: [dm-devel] [PATCH v2 2/4] libmpathpersist: format_transportids(): avoid PROUT overflow

2020-03-17 Thread Benjamin Marzinski
On Sun, Mar 15, 2020 at 10:05:19PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > This limits the PERSISTENT RESERVE OUT data size to max. 8192 bytes. > Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > libmpathpersist/mpath_pr_ioctl.c | 31

Re: [dm-devel] [PATCH] dm verity fec: Fix memory leak in verity_fec_ctr

2020-03-17 Thread James Bottomley
You two broke threading on this for what looks like non-trivial reasons. Threading is becoming very important to us with the mbox tools, so it's important to get right. The original problem is that the first message id is illegal under RFC 2822: > Message-Id: <20200317091212.GA18241@harshini.x

[dm-devel] [PATCH] dm verity fec: Fix memory leak in verity_fec_ctr

2020-03-17 Thread Shetty, Harshini X (EXT-Sony Mobile)
Fix below kmemleak detected in verity_fec_ctr. output_pool is allocated for each dm-target device. But it is not freed when dm-table for the target is removed.Hence Free the output buffer in destructor function verity_fec_dtr unreferenced object 0xa574d000 (size 4096): comm "init", pid 1