Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-19 Thread Christoph Hellwig
On Fri, Mar 13, 2020 at 04:08:58PM +0300, Kirill Tkhai wrote: > I just don't understand the reason nothing happens :( > I see newly-sent patches comes fast into block tree. > But there is only silence... I grepped over Documentation, > and there is no special rules about block tree. So, > it looks

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-19 Thread Martin K. Petersen
Christoph, >> Some comments? Some requests for reworking? Some personal reasons to >> ignore my patches? > > I'm still completely opposed to the magic overloading using a flag. > That is just a bad design waiting for trouble to happen. The observation was that Kirill's original patch set was a

[dm-devel] [PATCH] dm-integrity: fix a crash with unusually large

2020-03-19 Thread Mikulas Patocka
Hi I've found a bug in dm-integrity - if the user specified tag size greater than HASH_MAX_DIGESTSIZE (and lower or equal than MAX_TAG_SIZE), it crashes if the kmalloc call in integrity_metadata fails. I'm still not sure how to fix it: we can extend the size of the array checksums_onstack (but

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-19 Thread Kirill Tkhai
On 19.03.2020 13:28, Christoph Hellwig wrote: > On Fri, Mar 13, 2020 at 04:08:58PM +0300, Kirill Tkhai wrote: >> I just don't understand the reason nothing happens :( >> I see newly-sent patches comes fast into block tree. >> But there is only silence... I grepped over Documentation, >> and there i