Re: [dm-devel] [git pull] device mapper changes for 5.8

2020-06-05 Thread Mikulas Patocka
Hi I'd like to ask to remove these two patches: > dm crypt: sleep and retry on allocation errors > dm integrity: sleep and retry on allocation errors Retrying the request in dm-crypt is not safe because crypt_convert_block already advanced to the next block (even in the case of allo

Re: [dm-devel] [PATCH] libmultipath: fix condlog NULL argument in uevent_get_env_var

2020-06-05 Thread Martin Wilck
On Thu, 2020-06-04 at 18:20 -0500, Benjamin Marzinski wrote: > uevent_get_env_var() could call condlog with p == NULL. On gcc 10, > this triggers warnings like: > > In file included from uevent.c:47: > In function 'uevent_get_env_var', > inlined from 'uevent_get_wwid' at uevent.c:170:8: > debu

Re: [dm-devel] [git pull v2] device mapper changes for 5.8

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Fri, 5 Jun 2020 15:16:13 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-5.8/dm-changes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b25c6644bfd3affd7d0127ce95c5c96c155a7515 Thank you! -- D

Re: [dm-devel] [RFC 2/2] dm dust: introduce listbadblocks in the rst

2020-06-05 Thread Bryan Gurney
On Fri, Jun 5, 2020 at 3:48 AM yangerkun wrote: > > Since we support the listbadblocks command, introduce the detail in the > doc. > > Signed-off-by: yangerkun Thank you for the documentation. I have a few corrections listed below: > --- > .../admin-guide/device-mapper/dm-dust.rst| 16

[dm-devel] [git pull] device mapper changes for 5.8

2020-06-05 Thread Mike Snitzer
Hi Linus, For the following changes there is one dm-zoned-metadata.c conflict that linux-next has been carrying for a while. See commit d77e96f277 ("Merge remote-tracking branch 'device-mapper/for-next'") from next-20200605. It resolves conflict from linux-block's

[dm-devel] [bug report] dm zoned: per-device reclaim

2020-06-05 Thread Dan Carpenter
Hello Hannes Reinecke, The patch a99e0ceaa832: "dm zoned: per-device reclaim" from Jun 2, 2020, leads to the following static checker warning: drivers/md/dm-zoned-reclaim.c:428 dmz_do_reclaim() error: potentially dereferencing uninitialized 'rzone'. drivers/md/dm-zoned-reclaim.c

[dm-devel] [RFC 2/2] dm dust: introduce listbadblocks in the rst

2020-06-05 Thread yangerkun
Since we support the listbadblocks command, introduce the detail in the doc. Signed-off-by: yangerkun --- .../admin-guide/device-mapper/dm-dust.rst| 16 1 file changed, 16 insertions(+) diff --git a/Documentation/admin-guide/device-mapper/dm-dust.rst b/Documentation/ad

Re: [dm-devel] [RFC PATCH 0/2] multipath: change default devnode blacklist

2020-06-05 Thread Martin Wilck
Hi Ben, On Thu, 2020-06-04 at 19:30 -0500, Benjamin Marzinski wrote: > I recently got a request to add the Oracle ASM filer driver devices > to > multipath's builtin devnode blacklist. However, instead of having to > do > always this for each device type individually, I decided to make > multipat

[dm-devel] [RFC 1/2] dm dust: add interface to list all badblocks

2020-06-05 Thread yangerkun
This interface may help anyone want to know all badblocks without query block one by one. Signed-off-by: yangerkun --- drivers/md/dm-dust.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/md/dm-dust.c b/drivers/md/dm-dust.c index ff03b90072c5..903c0d158c6e 1006

[dm-devel] [PATCH] libmultipath: fix condlog NULL argument in uevent_get_env_var

2020-06-05 Thread Benjamin Marzinski
uevent_get_env_var() could call condlog with p == NULL. On gcc 10, this triggers warnings like: In file included from uevent.c:47: In function 'uevent_get_env_var', inlined from 'uevent_get_wwid' at uevent.c:170:8: debug.h:13:2: error: '%s' directive argument is null [-Werror=format-overflow=]

Re: [dm-devel] [RFC PATCH 0/2] multipath: change default devnode blacklist

2020-06-05 Thread Benjamin Marzinski
On Fri, Jun 05, 2020 at 07:20:26PM +, Martin Wilck wrote: > Hi Ben, > > On Thu, 2020-06-04 at 19:30 -0500, Benjamin Marzinski wrote: > > I recently got a request to add the Oracle ASM filer driver devices > > to > > multipath's builtin devnode blacklist. However, instead of having to > > do >

[dm-devel] [RFC PATCH 1/2] libmultipath: change filter_devnode arguments

2020-06-05 Thread Benjamin Marzinski
Instead of taking the blist and elist devnode vectors, filter device now takes a config struct. This change is necessary to enable future commits. It makes no functional changes to the code. Signed-off-by: Benjamin Marzinski --- libmultipath/blacklist.c | 8 libmultipath/blacklist.h

Re: [dm-devel] [RFC 1/2] dm dust: add interface to list all badblocks

2020-06-05 Thread Bryan Gurney
On Fri, Jun 5, 2020 at 3:48 AM yangerkun wrote: > > This interface may help anyone want to know all badblocks without query > block one by one. > > Signed-off-by: yangerkun > --- > drivers/md/dm-dust.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/drivers/md/dm-

[dm-devel] [RFC PATCH 2/2] libmultipath: change how default devnode blacklist works

2020-06-05 Thread Benjamin Marzinski
The number of devices that multipath needs to blacklist keeps growing, and the udev rules already have KERNEL!="sd*|dasd*|nvme*", GOTO="end_mpath" so they only work correctly with these device types. Instead of individually blacklisting every type of device that can't be multipathed, multipath's

[dm-devel] [RFC 0/2] introduce interface to list all badblocks

2020-06-05 Thread yangerkun
We can add/remove/query the badblocks, but no interface to list all badblocks when we want to know the badblocks we ever set still available. Add message listbadblocks to do this. To list all bad block list, run the following message command: $ sudo dmsetup message dust1 0 listbadblocks We w

[dm-devel] [RFC PATCH 0/2] multipath: change default devnode blacklist

2020-06-05 Thread Benjamin Marzinski
I recently got a request to add the Oracle ASM filer driver devices to multipath's builtin devnode blacklist. However, instead of having to do always this for each device type individually, I decided to make multipath blacklist all non scsi, nvme, and dasd devnodes by default. This is what the mul

[dm-devel] [PATCH] dm crypt: avoid truncating the logical block size

2020-06-05 Thread Eric Biggers
From: Eric Biggers queue_limits::logical_block_size got changed from unsigned short to unsigned int, but it was forgotten to update crypt_io_hints() to use the new type. Fix it. Fixes: ad6bf88a6c19 ("block: fix an integer overflow in logical block size") Cc: sta...@vger.kernel.org Signed-off-by

Re: [dm-devel] [PATCH] dm crypt: avoid truncating the logical block size

2020-06-05 Thread Mikulas Patocka
On Thu, 4 Jun 2020, Eric Biggers wrote: > From: Eric Biggers > > queue_limits::logical_block_size got changed from unsigned short to > unsigned int, but it was forgotten to update crypt_io_hints() to use the > new type. Fix it. > > Fixes: ad6bf88a6c19 ("block: fix an integer overflow in log

Re: [dm-devel] [PATCH 1/4] qat: fix misunderstood -EBUSY return code

2020-06-05 Thread Giovanni Cabiddu
Hi Mikulas, On Wed, Jun 03, 2020 at 04:31:54AM -0400, Mikulas Patocka wrote: > On Tue, 2 Jun 2020, Giovanni Cabiddu wrote: > > Hi Mikulas, > > > > thanks for your patch. See below. > > > > > + qat_req->backed_off = backed_off = > > > adf_should_back_off(ctx->inst->sym_tx); > > > +again: > > > +

Re: [dm-devel] [PATCH] dm zoned: Fix memory leak of newly allocated zone on xa_insert failure

2020-06-05 Thread Markus Elfring
> Currently if an xa_insert fails then there is a memory lead of the > recently allocated zone object. … I hope that a typo will be avoided for the final change description. Regards, Markus -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH][next] dm zoned: fix memory leak of newly allocated zone on xa_insert failure

2020-06-05 Thread Colin King
From: Colin Ian King Currently if an xa_insert fails then there is a memory lead of the recently allocated zone object. Fix this by kfree'ing zone before returning on the error return path. Addresses-Coverity: ("Resource leak") Fixes: 1a311efa3916 ("dm zoned: convert to xarray") Signed-off-by: C