Re: [dm-devel] crypto API and GFP_ATOMIC

2020-06-09 Thread Herbert Xu
On Tue, Jun 09, 2020 at 01:11:05PM -0400, Mikulas Patocka wrote: > > Do you have another idea how to solve this problem? I think the better approach would be to modify the drivers to not allocate any memory. In general, any memory needed by the driver to fulfil a request *should* be allocated

Re: [dm-devel] [PATCH v2 0/3] multipath: change default devnode blacklist

2020-06-09 Thread Martin Wilck
On Tue, 2020-06-09 at 16:35 -0500, Benjamin Marzinski wrote: > I recently got a request to add the Oracle ASM filer driver devices > to > multipath's builtin devnode blacklist. However, instead of having to > do > always this for each device type individually, I decided to make > multipath

[dm-devel] [PATCH v2 2/3] libmultipath: fix parser issue with comments in strings

2020-06-09 Thread Benjamin Marzinski
If a quoted string starts with '#' or '!', the parser will stop parsing the line, thinking that it's a comment. It should only be checking for comments outside of quoted strings. Fixed this and added unit tests to verify it. Signed-off-by: Benjamin Marzinski --- libmultipath/parser.c | 4 +++-

[dm-devel] [PATCH v2 1/3] libmultipath: remove _blacklist_exceptions functions

2020-06-09 Thread Benjamin Marzinski
_blacklist_exceptions() and _blacklist_exceptions_device() are exactly the same as _blacklist() and _blacklist_device(), so remove them, and give the remaining functions to a more general name. Signed-off-by: Benjamin Marzinski --- libmultipath/blacklist.c | 62

[dm-devel] [PATCH v2 3/3] libmultipath: invert regexes that start with exclamation point

2020-06-09 Thread Benjamin Marzinski
The number of devices that multipath needs to blacklist keeps growing, and the udev rules already have KERNEL!="sd*|dasd*|nvme*", GOTO="end_mpath" so they only work correctly with these device types. Instead of individually blacklisting every type of device that can't be multipathed,

Re: [dm-devel] [PATCH 0/2] multipath-tools: disable foreign libraries by default

2020-06-09 Thread Benjamin Marzinski
On Fri, May 08, 2020 at 09:33:00PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > Hi Christophe, > > This is a follow-up to the previous discussion with topic 'RFC: > multipath-tools: NVMe native multipath and default setting for > "enable_foreign"'. Upon Netapp's initiative, I'd asked

[dm-devel] crypto API and GFP_ATOMIC

2020-06-09 Thread Mikulas Patocka
Hi I've found out that a lot of hardware crypto drivers use GFP_ATOMIC. Some of them switch between GFP_ATOMIC and GFP_KERNEL based on the flag CRYPTO_TFM_REQ_MAY_SLEEP. dm-crypt and dm-integrity don't use CRYPTO_TFM_REQ_MAY_SLEEP (because GFP_KERNEL allocation requests can recurse back to

[dm-devel] [git pull v3] device mapper changes for 5.8

2020-06-09 Thread Mike Snitzer
[resending as v3 due to my From: email addr in v2 being inexplicably wrong] Hi Linus, I had some miscommunication with Mikulas on his -ENOMEM sleep and retry changes for dm-crypt and dm-integrity, he no longer thinks them appropriate: