Re: [dm-devel] [PATCH]libmultipath/dmparser: add missing path with good status when sync state with dm kernel

2020-07-07 Thread Chongyun Wu
Hello Martin, Thanks for your reply. Waiting for your patches I'd like to test it. And also, I'd like to tell more detail about this issue. > Is /dev/sdbk indeed a healthy path in this situation, or not? > Please run "multipathd show devices", too. Yes, /dev/sdbk can read and write, the

Re: [dm-devel] [PATCH v3] dm crypt: add flags to optionally bypass dm-crypt workqueues

2020-07-07 Thread Damien Le Moal
On 2020/07/07 2:37, Ignat Korchagin wrote: > Changes from v2: > * dropped nobacklog boolean - ciphers are OK to backlog requests > * moved some conditionals inline dropping the extra local variables > * renamed "noresched" -> "atomic" > > This is a follow up from [1]. Consider the following

[dm-devel] [PATCH 0/2] dm zoned fixes for 5.8

2020-07-07 Thread Damien Le Moal
Mike, A couple of fixes for dm-zoned for this cycle. The first patch fixes a possible hang under intensive write workload with a setup that has a very limited number of cache zones. The second patch fixes some compilation warnings showing when compiling with W=1. Damien Le Moal (2): dm zoned:

[dm-devel] [PATCH 1/2] dm zoned: Fix zone reclaim trigger

2020-07-07 Thread Damien Le Moal
Triggerring reclaim only based on the percentage of unmapped cache zones can fail to detect cases where reclaim is needed, e.g. if the target has only 2 or 3 cache zones and only one unmapped cache zone, the percentage of free cache zone is higher than DMZ_RECLAIM_LOW_UNMAP_ZONES (30%) and reclaim

[dm-devel] [PATCH 2/2] dm zoned: Remove set but unused variables

2020-07-07 Thread Damien Le Moal
In dmz_reclaim_work(), the variables nr_unmap_rnd and nr_rnd are set but unused. Remove them. Fixes: f97809aec589 ("dm zoned: per-device reclaim") Signed-off-by: Damien Le Moal --- drivers/md/dm-zoned-reclaim.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [dm-devel] [PATCH] multipath-tools: add info to man page for the historical-service-time path selector

2020-07-07 Thread Martin Wilck
On Tue, 2020-07-07 at 17:44 -0400, Gabriel Krisman Bertazi wrote: > Xose Vazquez Perez writes: > > > Cc: Khazhismel Kumykov > > Cc: Gabriel Krisman Bertazi > > Cc: Martin Wilck > > Cc: Benjamin Marzinski > > Cc: Christophe Varoqui > > Cc: DM-DEVEL ML > > Signed-off-by: Xose Vazquez Perez

Re: [dm-devel] [PATCH] multipath-tools: add info to man page for the historical-service-time path selector

2020-07-07 Thread Gabriel Krisman Bertazi
Xose Vazquez Perez writes: > Cc: Khazhismel Kumykov > Cc: Gabriel Krisman Bertazi > Cc: Martin Wilck > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez > --- > multipath/multipath.conf.5 | 4 > 1 file changed, 4 insertions(+) > >

[dm-devel] [PATCH] multipath-tools: add info to man page for the historical-service-time path selector

2020-07-07 Thread Xose Vazquez Perez
Cc: Khazhismel Kumykov Cc: Gabriel Krisman Bertazi Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 4 1 file changed, 4 insertions(+) diff --git a/multipath/multipath.conf.5

Re: [dm-devel] [PATCH] blk-mq: consider non-idle request as "inflight" in blk_mq_rq_inflight()

2020-07-07 Thread Jens Axboe
On 7/7/20 9:04 AM, Mike Snitzer wrote: > From: Ming Lei > > dm-multipath is the only user of blk_mq_queue_inflight(). When > dm-multipath calls blk_mq_queue_inflight() to check if it has > outstanding IO it can get a false negative. The reason for this is > blk_mq_rq_inflight() doesn't

[dm-devel] [PATCH] blk-mq: consider non-idle request as "inflight" in blk_mq_rq_inflight()

2020-07-07 Thread Mike Snitzer
From: Ming Lei dm-multipath is the only user of blk_mq_queue_inflight(). When dm-multipath calls blk_mq_queue_inflight() to check if it has outstanding IO it can get a false negative. The reason for this is blk_mq_rq_inflight() doesn't consider requests that are no longer MQ_RQ_IN_FLIGHT but

Re: [dm-devel] [PATCH 0/6] crypto: add CRYPTO_ALG_ALLOCATES_MEMORY

2020-07-07 Thread Mikulas Patocka
On Mon, 6 Jul 2020, Eric Biggers wrote: > On Wed, Jul 01, 2020 at 03:59:10AM -0400, Mikulas Patocka wrote: > > Thanks for cleaning this up. > > > > Mikulas > > Do you have any real comments on this? > > Are the usage restrictions okay for dm-crypt? > > - Eric I think that your patch

[dm-devel] [PATCH] libmultipath: add device to hwtable.c

2020-07-07 Thread mwilck
From: Steve Schremmer Add FUJITSU ETERNUS_AHB defaults. Signed-off-by: Steve Schremmer Reviewed-by: Martin Wilck --- libmultipath/hwtable.c | 16 1 file changed, 16 insertions(+) (MW: resending with format error fixed) diff --git a/libmultipath/hwtable.c

Re: [dm-devel] [PATCH] libmultipath: add device to hwtable.c

2020-07-07 Thread Martin Wilck
Hi Steve, On Mon, 2020-07-06 at 20:22 +, Schremmer, Steven wrote: > From: Steve Schremmer > > Add FUJITSU ETERNUS_AHB defaults. > > Signed-off-by: Steve Schremmer > --- > libmultipath/hwtable.c | 16 > 1 file changed, 16 insertions(+) > > diff --git

Re: [dm-devel] [PATCH]libmultipath/dmparser: add missing path with good status when sync state with dm kernel

2020-07-07 Thread Martin Wilck
Hello Chongyun, On Tue, 2020-07-07 at 03:08 +, Chongyun Wu wrote: > Hi Martin and Ben, > > Cloud you help to view below patch, thanks. > > > From b2786c81a78bf3868f300fd3177e852e718e7790 Mon Sep 17 00:00:00 > > 2001 > From: Chongyun Wu > Date: Mon, 6 Jul 2020 11:22:21 +0800 > Subject:

Re: [dm-devel] [PATCH 05/11] block: get rid of the trace rq insert wrapper

2020-07-07 Thread h...@lst.de
On Fri, Jul 03, 2020 at 11:29:25PM +, Chaitanya Kulkarni wrote: > Christoph, > > On 6/29/20 4:44 PM, Chaitanya Kulkarni wrote: > > Get rid of the wrapper for trace_block_rq_insert() and call the function > > directly. > > > > Signed-off-by: Chaitanya Kulkarni > > --- > > Can we re-consider