Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-12 Thread lixiaokeng
Hi Now the number of fd pointing /dev/mapper/control in multipathd process increases when iscsi device logs in. The reason is that wait_dmevents thread and uevqloop thread call _open_and_assign_control_fd concurrently. If lock add to _open_and_assign_control_fd fun in lvm2/libdm/libdm-iface.c, the

[dm-devel] [dm-level] master - libmultipath: fix use after free when iscsi logs in

2020-07-12 Thread lixiaokeng
When two iscsi ips log in and out alternately and the following scripts run at the same time, #!/bin/bash interval=5 while true do iscsiadm -m node -p 9.41.147.171 &> /dev/null iscsiadm -m node -p 9.41.148.172 &> /dev/null iscsiadm -m session &> /dev/null rescan-sc

Re: [dm-devel] [PATCH] dm-cache: document zeroing metadata device step

2020-07-12 Thread Matthew Wilcox
On Mon, Jul 13, 2020 at 03:40:39AM +0800, Austin Chang wrote: > + # When using dmsetup directly instead of volume manager like lvm2, > + # the first 4k of the metadata device should be zeroed to indicate > + # empty metadata. > + dd if=/dev/zero of=/dev/mapper/metadata bs=4k conv=notrunc ... d