Re: [dm-devel] [PATCH 69/74] libmultipath: disassemble_map(): get rid of "is_daemon" argument

2020-07-18 Thread Benjamin Marzinski
On Thu, Jul 09, 2020 at 12:51:40PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > The reason for the is_daemon parameter in disassemble_map() lies > deep in multipath-tools' past, in b96dead ("[multipathd] remove the > retry login in uev_remove_path()"): By not adding paths from >

Re: [dm-devel] [PATCH 66/74] libmultipath: update_pathvec_from_dm: handle pp->mpp mismatch

2020-07-18 Thread Benjamin Marzinski
On Thu, Jul 09, 2020 at 12:51:37PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > Treat this like a WWID mismatch. > > Signed-off-by: Martin Wilck > --- > libmultipath/structs_vec.c | 37 +++-- > 1 file changed, 23 insertions(+), 14 deletions(-) > >

Re: [dm-devel] [PATCH 64/74] multipathd: check_path(): set retrigger_delay if necessary

2020-07-18 Thread Benjamin Marzinski
On Thu, Jul 09, 2020 at 12:51:35PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > In a follow up patch, we will set INIT_MISSING_UDEV and set tick=1 > (minimal) at the same time. In this case, which is new, check_path() > must reset the delay when it first triggers an uevent. Maybe I'm

Re: [dm-devel] [PATCH 65/74] libmultipath: add update_pathvec_from_dm()

2020-07-18 Thread Benjamin Marzinski
On Thu, Jul 09, 2020 at 12:51:36PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > It can happen in particular during boot or startup that we encounter > paths as map members which haven't been discovered or fully initialized > yet, and are thus not in the pathvec. These paths need