Re: [dm-devel] [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-23 Thread David Sterba
On Wed, Jul 22, 2020 at 08:25:42AM +0200, Christoph Hellwig wrote: > Set up a readahead size by default, as very few users have a good > reason to change it. > > Signed-off-by: Christoph Hellwig > --- For the btrfs bits > fs/btrfs/disk-io.c| 1 - Acked-by: David Sterba -- dm-devel mailin

Re: [dm-devel] [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-23 Thread Richard Weinberger
- Ursprüngliche Mail - > Set up a readahead size by default, as very few users have a good > reason to change it. > > Signed-off-by: Christoph Hellwig > --- > block/blk-core.c | 1 - > drivers/mtd/mtdcore.c | 1 + > fs/9p/vfs_super.c | 4 ++-- > fs/afs/super.c| 1 - > fs/btrf

[dm-devel] libmultipath: fix null dereference

2020-07-23 Thread lutianxiong
Hi I got a multipath segfault while running iscsi login/logout and following scripts in parallel: #!/bin/bash interval=1 while true do multipath -F &> /dev/null multipath -r &> /dev/null multipath -v2 &> /dev/null multipath -ll &> /dev/null

Re: [dm-devel] [PATCH 09/14] bdi: remove BDI_CAP_CGROUP_WRITEBACK

2020-07-23 Thread Johannes Thumshirn
On 22/07/2020 08:27, Christoph Hellwig wrote: > it is know to support cgroup writeback, or the bdi comes from the block knwon ~^ Apart from that, Reviewed-by: Johannes Thumshirn -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 11/14] mm: use SWP_SYNCHRONOUS_IO more intelligently

2020-07-23 Thread Shakeel Butt
On Tue, Jul 21, 2020 at 11:27 PM Christoph Hellwig wrote: > > There is no point in trying to call bdev_read_page if SWP_SYNCHRONOUS_IO > is not set, as the device won't support it. > > Signed-off-by: Christoph Hellwig > --- > mm/page_io.c | 18 ++ > 1 file changed, 10 insertions(

Re: [dm-devel] [PATCH] libmultipath: free pp if store_path fails in disassemble_map

2020-07-23 Thread Benjamin Marzinski
On Thu, Jul 23, 2020 at 09:28:51AM +0800, Zhiqiang Liu wrote: > > > On 2020/7/23 4:53, Benjamin Marzinski wrote: > > On Wed, Jul 22, 2020 at 04:41:28PM +0800, Zhiqiang Liu wrote: > >> In disassemble_map func, one pp will be allocated and stored in pathvec > >> (only in client mode) and pgp->paths

[dm-devel] [PATCH v2] dm-integrity: revert adc0daad366b to fix recalculation

2020-07-23 Thread Mikulas Patocka
On Wed, 22 Jul 2020, Mikulas Patocka wrote: > > > On Wed, 22 Jul 2020, Mike Snitzer wrote: > > > On Wed, Jul 22 2020 at 2:46pm -0400, > > Mikulas Patocka wrote: > > > > > Hi Mike > > > > > > Please submit this to Linus and to RHEL-8. > > > > > > Mikulas > > > > > > > > > > > > From:

Re: [dm-devel] [PATCH v2] dm-integrity: revert adc0daad366b to fix recalculation

2020-07-23 Thread Mike Snitzer
On Thu, Jul 23 2020 at 10:42am -0400, Mikulas Patocka wrote: > In order to fix this race condition, we add a function dm_suspending that > is only true during the postsuspend phase and use it instead of > dm_suspended. > ... > Index: rhel8/drivers/md/dm.c >

Re: [dm-devel] [PATCH v2] dm-integrity: revert adc0daad366b to fix recalculation

2020-07-23 Thread Mikulas Patocka
On Thu, 23 Jul 2020, Mike Snitzer wrote: > On Thu, Jul 23 2020 at 10:42am -0400, > Mikulas Patocka wrote: > > > In order to fix this race condition, we add a function dm_suspending that > > is only true during the postsuspend phase and use it instead of > > dm_suspended. > > > > ... > > >

Re: [dm-devel] [PATCH] libmultipath: free pp if store_path fails in disassemble_map

2020-07-23 Thread Zhiqiang Liu
On 2020/7/23 21:22, Benjamin Marzinski wrote: > On Thu, Jul 23, 2020 at 09:28:51AM +0800, Zhiqiang Liu wrote: >> >> >> On 2020/7/23 4:53, Benjamin Marzinski wrote: >>> On Wed, Jul 22, 2020 at 04:41:28PM +0800, Zhiqiang Liu wrote: In disassemble_map func, one pp will be allocated and stored

[dm-devel] [PATCH V2] libmultipath: free pp if store_path fails in disassemble_map

2020-07-23 Thread Zhiqiang Liu
In disassemble_map func, one pp will be allocated and stored in pgp->paths. However, if store_path fails, pp will not be freed, then memory leak problem occurs. Here, we will call free_path to free pp when store_path fails. Signed-off-by: Zhiqiang Liu Signed-off-by: lixiaokeng --- V1->V2: updat