[dm-devel] [PATCH RFC] multipath-tools: *untested* use sysfs prio also for arrays with dual implicit/explicit alua support

2020-07-24 Thread Xose Vazquez Perez
Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Hannes Reinecke Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c index 897e48ca..5a82234f 100644 --- a/libmultipath/propsel.c +++ b/libmultipath/propsel.c @@ -595,7 +595,7 @@

Re: [dm-devel] [git pull] device mapper fix for 5.8-rc7

2020-07-24 Thread pr-tracker-bot
The pull request you sent on Fri, 24 Jul 2020 13:47:38 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-5.8/dm-fixes-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a38a19efcd9b7b536e2820df91e9f0be806f9a42 Thank you! --

[dm-devel] [git pull] device mapper fix for 5.8-rc7

2020-07-24 Thread Mike Snitzer
Hi Linus, The following changes since commit 6958c1c640af8c3f40fa8a2eee3b5b905d95b677: dm: use noio when sending kobject event (2020-07-08 12:50:51 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git

Re: [dm-devel] [PATCH V2] libmultipath: free pp if store_path fails in disassemble_map

2020-07-24 Thread Benjamin Marzinski
On Fri, Jul 24, 2020 at 09:40:18AM +0800, Zhiqiang Liu wrote: > In disassemble_map func, one pp will be allocated and stored in > pgp->paths. However, if store_path fails, pp will not be freed, > then memory leak problem occurs. > > Here, we will call free_path to free pp when store_path fails. >

[dm-devel] [PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-24 Thread Christoph Hellwig
Ever since the switch to blk-mq, a lower device not used for VM writeback will not be marked congested, so the check will never trigger. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_nl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c

[dm-devel] [PATCH 13/14] bdi: invert BDI_CAP_NO_ACCT_WB

2020-07-24 Thread Christoph Hellwig
Replace BDI_CAP_NO_ACCT_WB with a positive BDI_CAP_WRITEBACK_ACCT to make the checks more obvious. Also remove the pointless bdi_cap_account_writeback wrapper that just obsfucates the check. Signed-off-by: Christoph Hellwig --- fs/fuse/inode.c | 3 ++- include/linux/backing-dev.h

[dm-devel] [PATCH 01/14] fs: remove the unused SB_I_MULTIROOT flag

2020-07-24 Thread Christoph Hellwig
The last user of SB_I_MULTIROOT is disappeared with commit f2aedb713c28 ("NFS: Add fs_context support.") Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- fs/namei.c | 4 ++-- include/linux/fs.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[dm-devel] [PATCH 14/14] bdi: replace BDI_CAP_NO_{WRITEBACK, ACCT_DIRTY} with a single flag

2020-07-24 Thread Christoph Hellwig
Replace the two negative flags that are always used together with a single positive flag that indicates the writeback capability instead of two related non-capabilities. Also remove the pointless wrappers to just check the flag. Signed-off-by: Christoph Hellwig --- fs/9p/vfs_file.c

[dm-devel] [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-24 Thread Christoph Hellwig
Set up a readahead size by default, as very few users have a good reason to change it. Signed-off-by: Christoph Hellwig Acked-by: David Sterba [btrfs] Acked-by: Richard Weinberger [ubifs, mtd] --- block/blk-core.c | 1 - drivers/mtd/mtdcore.c | 1 + fs/9p/vfs_super.c | 4 ++--

[dm-devel] [PATCH 09/14] bdi: remove BDI_CAP_CGROUP_WRITEBACK

2020-07-24 Thread Christoph Hellwig
Just checking SB_I_CGROUPWB for cgroup writeback support is enough. Either the file system allocates its own bdi (e.g. btrfs), in which case it is known to support cgroup writeback, or the bdi comes from the block layer, which always supports cgroup writeback. Signed-off-by: Christoph Hellwig

[dm-devel] [PATCH 07/14] block: make QUEUE_SYSFS_BIT_FNS a little more useful

2020-07-24 Thread Christoph Hellwig
Generate the queue_sysfs_entry given that we have all the required information for it, and rename the generated show and store methods to match the other ones in the file. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- block/blk-sysfs.c | 31

[dm-devel] [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-07-24 Thread Christoph Hellwig
Drivers shouldn't really mess with the readahead size, as that is a VM concept. Instead set it based on the optimal I/O size by lifting the algorithm from the md driver when registering the disk. Also set bdi->io_pages there as well by applying the same scheme based on max_sectors.

[dm-devel] [PATCH 08/14] block: add helper macros for queue sysfs entries

2020-07-24 Thread Christoph Hellwig
Add two helpers macros to avoid boilerplate code for the queue sysfs entries. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- block/blk-sysfs.c | 248 +++--- 1 file changed, 58 insertions(+), 190 deletions(-) diff --git

[dm-devel] [PATCH 12/14] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag

2020-07-24 Thread Christoph Hellwig
The BDI_CAP_STABLE_WRITES is one of the few bits of information in the backing_dev_info shared between the block drivers and the writeback code. To help untangling the dependency replace it with a queue flag and a superblock flag derived from it. This also helps with the case of e.g. a file

[dm-devel] [PATCH 11/14] mm: use SWP_SYNCHRONOUS_IO more intelligently

2020-07-24 Thread Christoph Hellwig
There is no point in trying to call bdev_read_page if SWP_SYNCHRONOUS_IO is not set, as the device won't support it. Signed-off-by: Christoph Hellwig --- mm/page_io.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index

[dm-devel] [PATCH 05/14] md: update the optimal I/O size on reshape

2020-07-24 Thread Christoph Hellwig
The raid5 and raid10 drivers currently update the read-ahead size, but not the optimal I/O size on reshape. To prepare for deriving the read-ahead size from the optimal I/O size make sure it is updated as well. Signed-off-by: Christoph Hellwig --- drivers/md/raid10.c | 22

[dm-devel] [PATCH 03/14] drbd: remove RB_CONGESTED_REMOTE

2020-07-24 Thread Christoph Hellwig
This case isn't ever used. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/block/drbd/drbd_req.c | 4 include/linux/drbd.h | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index

[dm-devel] [PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-24 Thread Christoph Hellwig
BDI_CAP_SYNCHRONOUS_IO is only checked in the swap code, and used to decided if ->rw_page can be used on a block device. Just check up for the method instead. The only complication is that zram needs a second set of block_device_operations as it can switch between modes that actually support

[dm-devel] bdi cleanups v3

2020-07-24 Thread Christoph Hellwig
Hi Jens, this series contains a bunch of different BDI cleanups. The biggest item is to isolate block drivers from the BDI in preparation of changing the lifetime of the block device BDI in a follow up series. Changes since v2: - fix a rw_page return value check - fix various changelogs