Re: [dm-devel] [dm- devel][PATCH] tests/hwtable: fix a memory free in replicate_config

2020-08-03 Thread Benjamin Marzinski
On Mon, Aug 03, 2020 at 10:43:54AM +0800, Zhiqiang Liu wrote: > > In replicate_config func, hwtable is allocated by calling get_used_hwes > func, however it is not freed. > > Signed-off-by: Zhiqiang Liu Reviewed-by: Benjamin Marzinski > --- > tests/hwtable.c | 1 + > 1 file changed, 1

Re: [dm-devel] [dm- devel][PATCH] vector: add lower bound check of E in VECTOR_SLOT

2020-08-03 Thread Benjamin Marzinski
On Mon, Aug 03, 2020 at 10:41:48AM +0800, Zhiqiang Liu wrote: > > In VECTOR_SLOT(V, E), we add the lower bound check of E. > E cannot be less than zero. > > Signed-off-by: Zhiqiang Liu Reviewed-by: Benjamin Marzinski > --- > libmultipath/vector.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [dm-devel] [dm- devel][PATCH] vector: fix upper boundary check of vector size in vector_del_slot

2020-08-03 Thread Benjamin Marzinski
On Mon, Aug 03, 2020 at 10:39:29AM +0800, Zhiqiang Liu wrote: > > In vector_del_slot func, legal value of input slot is in range of > [0, VECTOR_SIZE(v)), it means slot value should be less then VECTOR_SIZE(v). > > > Signed-off-by: Zhiqiang Liu Reviewed-by: Benjamin Marzinski > --- >

Re: [dm-devel] [PATCH] libmultipath: fix null dereference in add

2020-08-03 Thread Benjamin Marzinski
On Mon, Aug 03, 2020 at 07:57:01PM +0800, lixiaokeng wrote: > I got a multipath segfault while running iscsi login/logout and following > scripts in parallel: > > #!/bin/bash > interval=1 > while true > do > multipath -F &> /dev/null > multipath -r &> /dev/null >

[dm-devel] [PATCH] libmultipath: fix null dereference in add

2020-08-03 Thread lixiaokeng
I got a multipath segfault while running iscsi login/logout and following scripts in parallel: #!/bin/bash interval=1 while true do multipath -F &> /dev/null multipath -r &> /dev/null multipath -v2 &> /dev/null multipath -ll &> /dev/null

[dm-devel] [PATCH] dm-ebs: Fix incorrect checking for REQ_OP_FLUSH.

2020-08-03 Thread John Dorminy
REQ_OP_FLUSH was being treated as a flag, but the operation part of bio->bi_opf must be treated as a whole. Change to accessing the operation part via bio_op(bio) and checking for equality. Signed-off-by: John Dorminy --- drivers/md/dm-ebs-target.c | 2 +- 1 file changed, 1 insertion(+), 1