Re: [dm-devel] [PATCH 00/42] multipath-tools series part III: duplicate alias

2020-08-04 Thread Martin Wilck
On Mon, 2020-07-20 at 15:30 -0500, Benjamin Marzinski wrote: > On Thu, Jul 09, 2020 at 12:35:10PM +0200, mwi...@suse.com wrote: > > From: Martin Wilck > > > > Hi Christophe, hi Ben, > > > > This is part II of a larger patch series for multpath-tools I've > > been preparing. > > It contains

Re: [dm-devel] [PATCH 12/35] libmultipath: strlcpy()/strlcat(): use restrict qualifier

2020-08-04 Thread Martin Wilck
On Tue, 2020-08-04 at 12:29 -0500, Benjamin Marzinski wrote: > On Tue, Aug 04, 2020 at 05:36:31PM +0200, Martin Wilck wrote: > > On Thu, 2020-07-16 at 17:18 -0500, Benjamin Marzinski wrote: > > > On Thu, Jul 09, 2020 at 12:15:57PM +0200, mwi...@suse.com wrote: > > > > From: Martin Wilck > > > >

[dm-devel] [PATCH] dm: don't call report zones for more than the user requested

2020-08-04 Thread Johannes Thumshirn
Don't call report zones for more zones than the user actually requested, otherwise this can lead to out-of-bounds accesses in the callback functions. Such a situation can happen if the target's ->report_zones() callback function returns 0 because we've reached the end of the target and then

Re: [dm-devel] [PATCH] dm: don't call report zones for more than the user requested

2020-08-04 Thread Johannes Thumshirn
On 04/08/2020 12:17, Damien Le Moal wrote: > > Looks good. I think this needs a Cc: stable. Indeed, Mike can you add these two when applying or do you want me to resend? Fixes: d41003513e61 ("block: rework zone reporting") Cc: sta...@vger.kernel.org # v5.5+ -- dm-devel mailing list

Re: [dm-devel] [PATCH 08/35] libmultipath: create bitfield abstraction

2020-08-04 Thread Martin Wilck
On Tue, 2020-08-04 at 11:26 -0500, Benjamin Marzinski wrote: > On Tue, Aug 04, 2020 at 05:18:18PM +0200, Martin Wilck wrote: > > On Tue, 2020-08-04 at 17:04 +0200, Martin Wilck wrote: > > > On Thu, 2020-07-16 at 16:17 -0500, Benjamin Marzinski wrote: > > > > On Thu, Jul 09, 2020 at 12:15:53PM

Re: [dm-devel] [PATCH 12/35] libmultipath: strlcpy()/strlcat(): use restrict qualifier

2020-08-04 Thread Benjamin Marzinski
On Tue, Aug 04, 2020 at 05:36:31PM +0200, Martin Wilck wrote: > On Thu, 2020-07-16 at 17:18 -0500, Benjamin Marzinski wrote: > > On Thu, Jul 09, 2020 at 12:15:57PM +0200, mwi...@suse.com wrote: > > > From: Martin Wilck > > > > > > Also remove the redundant local variables. It's not necessary to

Re: [dm-devel] [PATCH 08/35] libmultipath: create bitfield abstraction

2020-08-04 Thread Benjamin Marzinski
On Tue, Aug 04, 2020 at 05:18:18PM +0200, Martin Wilck wrote: > On Tue, 2020-08-04 at 17:04 +0200, Martin Wilck wrote: > > On Thu, 2020-07-16 at 16:17 -0500, Benjamin Marzinski wrote: > > > On Thu, Jul 09, 2020 at 12:15:53PM +0200, mwi...@suse.com wrote: > > > > From: Martin Wilck > > > > +struct

Re: [dm-devel] [RFC PATCH v5 00/11] Integrity Policy Enforcement LSM (IPE)

2020-08-04 Thread Deven Bowers
On 8/2/2020 9:43 AM, James Bottomley wrote: On Sun, 2020-08-02 at 16:31 +0200, Pavel Machek wrote: On Sun 2020-08-02 10:03:00, Sasha Levin wrote: On Sun, Aug 02, 2020 at 01:55:45PM +0200, Pavel Machek wrote: Hi! IPE is a Linux Security Module which allows for a configurable policy to

Re: [dm-devel] [PATCH 12/35] libmultipath: strlcpy()/strlcat(): use restrict qualifier

2020-08-04 Thread Martin Wilck
On Thu, 2020-07-16 at 17:18 -0500, Benjamin Marzinski wrote: > On Thu, Jul 09, 2020 at 12:15:57PM +0200, mwi...@suse.com wrote: > > From: Martin Wilck > > > > Also remove the redundant local variables. It's not necessary to > > make "restrict" work, but it makes the intention more clear. > > >

Re: [dm-devel] [PATCH 08/35] libmultipath: create bitfield abstraction

2020-08-04 Thread Martin Wilck
On Tue, 2020-08-04 at 17:04 +0200, Martin Wilck wrote: > On Thu, 2020-07-16 at 16:17 -0500, Benjamin Marzinski wrote: > > On Thu, Jul 09, 2020 at 12:15:53PM +0200, mwi...@suse.com wrote: > > > From: Martin Wilck > > > > > > In e32d521d ("libmultipath: coalesce_paths: fix size mismatch > > >

Re: [dm-devel] [PATCH 08/35] libmultipath: create bitfield abstraction

2020-08-04 Thread Martin Wilck
On Thu, 2020-07-16 at 16:17 -0500, Benjamin Marzinski wrote: > On Thu, Jul 09, 2020 at 12:15:53PM +0200, mwi...@suse.com wrote: > > From: Martin Wilck > > > > In e32d521d ("libmultipath: coalesce_paths: fix size mismatch > > handling"), > > we introduced simple bitmap handling functions. We can

Re: [dm-devel] [PATCH] dm-ebs: Fix incorrect checking for REQ_OP_FLUSH.

2020-08-04 Thread Heinz Mauelshagen
Acked-by: Heinz Mauelshagen On 8/1/20 12:46 AM, John Dorminy wrote: REQ_OP_FLUSH was being treated as a flag, but the operation part of bio->bi_opf must be treated as a whole. Change to accessing the operation part via bio_op(bio) and checking for equality. Signed-off-by: John Dorminy ---

Re: [dm-devel] dm: don't call report zones for more than the user requested

2020-08-04 Thread Mike Snitzer
On Tue, Aug 04 2020 at 7:26am -0400, Johannes Thumshirn wrote: > On 04/08/2020 12:17, Damien Le Moal wrote: > > > > Looks good. I think this needs a Cc: stable. > > Indeed, Mike can you add these two when applying or do you want me to resend? > > Fixes: d41003513e61 ("block: rework zone

Re: [dm-devel] [PATCH] dm: don't call report zones for more than the user requested

2020-08-04 Thread Damien Le Moal
On 2020/08/04 18:25, Johannes Thumshirn wrote: > Don't call report zones for more zones than the user actually requested, > otherwise this can lead to out-of-bounds accesses in the callback > functions. > > Such a situation can happen if the target's ->report_zones() callback > function returns 0