Re: [dm-devel] [PATCH v2 13/21] libmultipath: provide defaults for {get, put}_multipath_config

2020-09-26 Thread Benjamin Marzinski
On Sat, Sep 26, 2020 at 11:43:46AM +0200, Martin Wilck wrote: > On Fri, 2020-09-25 at 16:57 -0500, Benjamin Marzinski wrote: > > On Fri, Sep 25, 2020 at 10:00:10PM +0200, Martin Wilck wrote: > > > > > > I suggest to track the verbosity independently in a different > > > variable, > > > and just

Re: [dm-devel] [PATCH v2 2/2] multipath: Extend program description in manpage

2020-09-26 Thread Martin Wilck
On Sat, 2020-09-26 at 18:29 +0200, Frank Meinl wrote: > Add two paragraphs which list some advantages of multipath and > explain > the benefit for single path devices. The text has been partly > composed > by Benjamin Marzinski. - Refer to >

Re: [dm-devel] [PATCH v2 1/2] libmultipath: Allow discovery of USB devices

2020-09-26 Thread Martin Wilck
On Sat, 2020-09-26 at 18:26 +0200, Frank Meinl wrote: > This change adds a new configuration option allow_usb_devices. It is > disabled by default, so that the behavior of existing setups is not > changed. If enabled (via multipath.conf), USB devices will be found > during device discovery and can

Re: [dm-devel] [PATCH 01/23] multipathd: uxlsnr: avoid deadlock on exit

2020-09-26 Thread Martin Wilck
On Fri, 2020-09-25 at 20:52 -0500, Benjamin Marzinski wrote: > > O.k. I'm getting way into the theoretical weeds here, but I believe > that > realloc() is technically allowed to return NULL when it shrinks > allocated memory. In this case num_clients would be too big. Later > in > this function,

Re: [dm-devel] [PATCH v2 13/21] libmultipath: provide defaults for {get, put}_multipath_config

2020-09-26 Thread Martin Wilck
On Fri, 2020-09-25 at 16:57 -0500, Benjamin Marzinski wrote: > On Fri, Sep 25, 2020 at 10:00:10PM +0200, Martin Wilck wrote: > > > > I suggest to track the verbosity independently in a different > > variable, > > and just set it from init_config() if it was actually set in the > > config file.