Re: [dm-devel] [PATCH 4/5] libmultipath: only read 0xc9 vpd page for devices with rdac checker

2020-11-02 Thread Benjamin Marzinski
On Mon, Nov 02, 2020 at 07:11:06PM -0600, Benjamin Marzinski wrote: > On Fri, Oct 30, 2020 at 09:12:46PM +, Martin Wilck wrote: > > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > > Only rdac arrays support 0xC9 vpd page inquiries. All other arrays > > > will > > > return a fai

Re: [dm-devel] [PATCH 2/5] libmultipath: add eh_deadline multipath.conf parameter

2020-11-02 Thread Benjamin Marzinski
On Fri, Oct 30, 2020 at 09:00:48PM +, Martin Wilck wrote: > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > There are times a fc rport is never lost, meaning that > > fast_io_fail_tmo > > and dev_loss_tmo never trigger, but scsi commands still hang. This > > can > > cause probl

Re: [dm-devel] [PATCH 4/5] libmultipath: only read 0xc9 vpd page for devices with rdac checker

2020-11-02 Thread Benjamin Marzinski
On Fri, Oct 30, 2020 at 09:12:46PM +, Martin Wilck wrote: > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > Only rdac arrays support 0xC9 vpd page inquiries. All other arrays > > will > > return a failure. Since all rdac arrays in the the built-in device > > configuration expli

Re: [dm-devel] [PATCH v2 29/29] libmultipath: fix race between log_safe and log_thread_stop()

2020-11-02 Thread Benjamin Marzinski
On Mon, Oct 26, 2020 at 06:24:57PM +0100, Martin Wilck wrote: > On Mon, 2020-10-26 at 17:22 +0100, Martin Wilck wrote: > > On Mon, 2020-10-19 at 21:20 -0500, Benjamin Marzinski wrote: > > > On Fri, Oct 16, 2020 at 12:45:01PM +0200, mwi...@suse.com wrote: > > > > From: Martin Wilck > > > > > > > >

Re: [dm-devel] Thoughts about multipathd's log thread

2020-11-02 Thread Benjamin Marzinski
On Mon, Nov 02, 2020 at 01:17:28PM +0100, Martin Wilck wrote: > (sending again, with dm-devel on cc. Sorry!) > > Hi Ben, hi Christophe, > > AFAIU, the purpose of the log thread is to avoid blocking while writing > log messages to the syslog socket. The thread has been in place for a > long time.

Re: [dm-devel] [PATCH v3] libmultipath: fix memory leaks in coalesce_paths

2020-11-02 Thread Benjamin Marzinski
On Mon, Nov 02, 2020 at 10:41:22AM +0800, lixiaokeng wrote: > When multipath -F are executed first and multipath -v2 or > -d are executed later, asan will warn memory leaks. The > reason is that the mpp allocated in coalesce_paths isn't > freed. Here we use newmp to store mpp. If mpvec is NULL, > w

Re: [dm-devel] [PATCH v3 0/4] add library to check if device is a valid path

2020-11-02 Thread Benjamin Marzinski
On Sun, Nov 01, 2020 at 09:33:09PM +, Martin Wilck wrote: > On Wed, 2020-10-21 at 16:39 -0500, Benjamin Marzinski wrote: > > The main part of the this patchset is the first patch, which adds a > > new library interface to check whether devices are valid paths. This > > was designed for use in t

Re: [dm-devel] [PATCH 0/5] Fixes for musl libc / alpine

2020-11-02 Thread Benjamin Marzinski
On Tue, Oct 27, 2020 at 11:45:31PM +0100, mwi...@suse.com wrote: > From: Martin Wilck Reviewed-by: Benjamin Marzinski for the set. > > Hi Christophe, Ben, all, > > this series of patches fixes the compilation and unit-test > problems of latest upstream with musl libc. > > Regards, > Martin

Re: [dm-devel] [PATCH 4/5] libmultipath tests: fix strerror() difference between musl and glibc

2020-11-02 Thread Benjamin Marzinski
On Tue, Oct 27, 2020 at 11:45:35PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > If an error occurs with errno=0, strerror() on musl returns a different > string than "Success". Make sure the test doesn't fail for that reason. > > Signed-off-by: Martin Wilck > --- > tests/alias.c|

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-02 Thread Benjamin Marzinski
On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote: > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > The multipathd tur checker thread is designed to be able to finish at > > any time, even after the tur checker itself has been freed. The > > multipathd shutdown code mak

Re: [dm-devel] [RFC 0/3] Add support of iopoll for dm device

2020-11-02 Thread Mike Snitzer
On Sun, Nov 01 2020 at 10:14pm -0500, JeffleXu wrote: > > On 10/27/20 2:53 AM, Mike Snitzer wrote: > >What you detailed there isn't properly modeling what it needs to. > >A given dm_target_io could result in quite a few bios (e.g. for > >dm-striped we clone each bio for each of N stripes). So t

[dm-devel] Thoughts about multipathd's log thread

2020-11-02 Thread Martin Wilck
(sending again, with dm-devel on cc. Sorry!) Hi Ben, hi Christophe, AFAIU, the purpose of the log thread is to avoid blocking while writing log messages to the syslog socket. The thread has been in place for a long time. However, the large majority of multipath installations today runs on systemd

Re: [dm-devel] [PATCH v3] libmultipath: fix memory leaks in coalesce_paths

2020-11-02 Thread Martin Wilck
On Mon, 2020-11-02 at 10:41 +0800, lixiaokeng wrote: > When multipath -F are executed first and multipath -v2 or > -d are executed later, asan will warn memory leaks. The > reason is that the mpp allocated in coalesce_paths isn't > freed. Here we use newmp to store mpp. If mpvec is NULL, > we free