Re: [dm-devel] [RFC 0/3] Add support of iopoll for dm device

2020-11-09 Thread JeffleXu
On 11/10/20 2:15 AM, Mike Snitzer wrote: On Sat, Nov 07 2020 at 8:09pm -0500, JeffleXu wrote: On 11/7/20 1:45 AM, Mike Snitzer wrote: On Thu, Nov 05 2020 at 9:51pm -0500, JeffleXu wrote: blk-mq.c: blk_mq_submit_bio     if (bio->orig)         init blk_poll_data and insert it into bio

Re: [dm-devel] [PATCH 17/24] rbd: use set_capacity_and_notify

2020-11-09 Thread Ilya Dryomov
On Fri, Nov 6, 2020 at 8:04 PM Christoph Hellwig wrote: > > Use set_capacity_and_notify to set the size of both the disk and block > device. This also gets the uevent notifications for the resize for free. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rbd.c | 3 +-- > 1 file change

Re: [dm-devel] [PATCH 23/24] virtio-blk: remove a spurious call to revalidate_disk_size

2020-11-09 Thread Stefan Hajnoczi
On Fri, Nov 06, 2020 at 08:03:35PM +0100, Christoph Hellwig wrote: > revalidate_disk_size just updates the block device size from the disk > size. Thus calling it from revalidate_disk_size doesn't actually do > anything. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/virtio_blk.c |

Re: [dm-devel] [PATCH 23/24] virtio-blk: remove a spurious call to revalidate_disk_size

2020-11-09 Thread Michael S. Tsirkin
On Fri, Nov 06, 2020 at 08:03:35PM +0100, Christoph Hellwig wrote: > revalidate_disk_size just updates the block device size from the disk > size. Thus calling it from revalidate_disk_size doesn't actually do > anything. > > Signed-off-by: Christoph Hellwig Acked-by: Michael S. Tsirkin > ---

Re: [dm-devel] [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

2020-11-09 Thread Sagi Grimberg
[ .. ] Originally nvme multipath would update/change the size of the multipath device according to the underlying path devices. With this patch the size of the multipath device will _not_ change if there is a change on the underlying devices. Yes, it will.  Take a close look at nvme_update_

Re: [dm-devel] [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

2020-11-09 Thread Hannes Reinecke
On 11/10/20 12:28 AM, Sagi Grimberg wrote: [ .. ] Originally nvme multipath would update/change the size of the multipath device according to the underlying path devices. With this patch the size of the multipath device will _not_ change if there is a change on the underlying devices. Yes,

[dm-devel] [PATCH] dm: add support for DM_TARGET_NOWAIT for various targets

2020-11-09 Thread Jeffle Xu
This is one prep patch for supporting iopoll for dm device. The direct IO routine will set REQ_NOWAIT flag for REQ_HIPRI IO (that is, IO will do iopoll) in bio_set_polled(). Then in the IO submission routine, the ability of handling REQ_NOWAIT of the block device will be checked for REQ_HIPRI IO i

Re: [dm-devel] [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

2020-11-09 Thread Christoph Hellwig
On Mon, Nov 09, 2020 at 08:53:58AM +0100, Hannes Reinecke wrote: >> index 376096bfc54a83..4e86c9aafd88a7 100644 >> --- a/drivers/nvme/host/core.c >> +++ b/drivers/nvme/host/core.c >> @@ -2053,7 +2053,7 @@ static void nvme_update_disk_info(struct gendisk *disk, >> capacity = 0;

Re: [dm-devel] [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

2020-11-09 Thread Hannes Reinecke
On 11/9/20 9:53 AM, Christoph Hellwig wrote: On Mon, Nov 09, 2020 at 08:53:58AM +0100, Hannes Reinecke wrote: index 376096bfc54a83..4e86c9aafd88a7 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2053,7 +2053,7 @@ static void nvme_update_disk_info(struct gendisk *disk,

[dm-devel] [PATCH] mpathpersist: Fix Register and Ignore with 0x00 SARK

2020-11-09 Thread Benjamin Marzinski
When the Register and Ignore command is run with sg_persist, if a 0x00 Service Action Reservation Key is given or the --param-sark option is not used at all, sg_persist will clear the registration. mpathpersist will fail with an error. This patch fixes mpathpersist to work like sg_persist in this

Re: [dm-devel] [PATCH v4] libmultipath: fix memory leaks in coalesce_paths

2020-11-09 Thread Benjamin Marzinski
On Mon, Nov 09, 2020 at 12:32:05PM +0800, lixiaokeng wrote: > When multipath -F are executed first and multipath -v2 or > -d are executed later, asan will warn memory leaks. The > reason is that the mpp allocated in coalesce_paths isn't > freed. Here we use newmp to store mpp. If newmp need not > b

Re: [dm-devel] [RFC 0/3] Add support of iopoll for dm device

2020-11-09 Thread Mike Snitzer
On Sat, Nov 07 2020 at 8:09pm -0500, JeffleXu wrote: > > On 11/7/20 1:45 AM, Mike Snitzer wrote: > >On Thu, Nov 05 2020 at 9:51pm -0500, > >JeffleXu wrote: > > > >>blk-mq.c: blk_mq_submit_bio > >> > >>     if (bio->orig) > >> > >>         init blk_poll_data and insert it into bio->orig's @coo

Re: [dm-devel] cleanup updating the size of block devices

2020-11-09 Thread Josef Bacik
On 11/6/20 2:03 PM, Christoph Hellwig wrote: Hi Jens, this series builds on top of the work that went into the last merge window, and make sure we have a single coherent interfac for updating the size of a block device. You can add Reviewed-by: Josef Bacik for the nbd bits, thanks, Josef

Re: [dm-devel] [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

2020-11-09 Thread Hannes Reinecke
On 11/6/20 8:03 PM, Christoph Hellwig wrote: There is no good reason to call revalidate_disk_size separately. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/cor

Re: [dm-devel] [PATCH 18/24] rnbd: use set_capacity_and_notify

2020-11-09 Thread Jinpu Wang
On Fri, Nov 6, 2020 at 8:04 PM Christoph Hellwig wrote: > > Use set_capacity_and_notify to set the size of both the disk and block > device. This also gets the uevent notifications for the resize for free. > > Signed-off-by: Christoph Hellwig Thanks, Christoph! Acked-by: Jack Wang > --- > driv